Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Replace projectRoots with projectRoot + watchRoots

Browse Source 
Summary:
We use projectRoots to limit crawling of jest-haste-map in large codebases. Since this implies multiple projects roots, it makes it very hard (or impossible) to reliably cache dependency resolutions.

If we can replace this with a single project root and a set of watch roots, we can have relative path resolutions for all dependencies which van be cached.

Reviewed By: rafeca

Differential Revision: D8450498

fbshipit-source-id: 830c21e847c3236e42d5414a8587508cb73864bd
This commit is contained in:
Alexey Kureev
2018-06-19 13:47:32 -07:00
committed by Facebook Github Bot
parent d7e0fe2c2c
commit c5ce762697
6 changed files with 23 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files
local-cli/server/middleware/openStackFrameInEditorMiddleware.js
+2 -2
View File
@@ -11,11 +11,11 @@
const launchEditor = require('../util/launchEditor');
module.exports = function({projectRoots}) {
module.exports = function({watchFolders}) {
return function(req, res, next) {
if (req.url === '/open-stack-frame') {
const frame = JSON.parse(req.rawBody);
launchEditor(frame.file, frame.lineNumber, projectRoots);
launchEditor(frame.file, frame.lineNumber, watchFolders);
res.end('OK');
} else {
next();