From c467843ed0eacf980b181b2413a4471f1ea9b6c5 Mon Sep 17 00:00:00 2001 From: Gijs Weterings Date: Mon, 17 Aug 2026 09:21:41 -0700 Subject: [PATCH] Fix DOMHighResTimeStamp round-trip truncation in timing primitives (#57975) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Summary: Pull Request resolved: https://github.com/react/react-native/pull/57975 `HighResDuration::fromDOMHighResTimeStamp` and `HighResTimeStamp::fromDOMHighResTimeStamp` converted milliseconds back to nanoseconds with `static_cast(units * 1e6)`, which truncates toward zero. `toDOMHighResTimeStamp()` divides the nanosecond count by 1e6 (one rounding) and multiplying back by 1e6 rounds again, so the product frequently lands a hair below the original integer (e.g. `537648854729249.97`). Truncation then chops off a whole nanosecond, so `fromDOMHighResTimeStamp(toDOMHighResTimeStamp(x)) != x` for roughly 2% of random `now()` values. That is the source of an intermittent `BridgingTest/highResTimeStampTest` failure, which reported: ``` Expected equality of these values: timestamp Which is: 8-byte object <22-02 00-21 FD-E8 01-00> bridging::fromJs( rt, bridging::toJs(rt, timestamp), invoker) Which is: 8-byte object <21-02 00-21 FD-E8 01-00> ``` Round to the nearest nanosecond instead of truncating. Nanosecond values below 2^53 are exactly representable in a double, so the round trip is now exact for every value below 2.25e15 ns (26 days of monotonic clock); beyond that the double's ULP exceeds 0.5 ns and residual error is at most 2 ns, which is a floor of the DOM representation itself. Rounding is also the correct semantic independently of the round trip — truncation gives a systematic downward bias and is asymmetric across zero, which affects the other callers (`RCTHighResTimeStampFromSeconds` for touch timestamps, `RuntimeTargetConsole` `console.timeStamp`, and `PerformanceTracer`). The rounding is `std::llround`, which costs both overloads their `constexpr`: `` rounding functions do not become usable in a constant expression until C++23 (P0533), and this header is compiled as C++20 everywhere (`-std=c++20` in `rn_defs.bzl`, `react-native-flags.cmake`, the podspecs and `Package.swift`). Both carry a `TODO` to restore `constexpr` once the C++23 rollout reaches them. Dropping it is safe here. All 14 call sites are plain runtime calls — none is in a constant-expression context, none assigns to a `constexpr` variable or feeds a `static_assert` — and both functions are defined inside the class body, so they stay implicitly `inline` and neither linkage nor ABI changes. `fromDOMHighResTimeStamp` converts a `double` arriving from JS, so constant-evaluating it was never meaningful in the first place. This does narrow the published API surface, so the C++ API snapshots are regenerated: the only change across all nine `.api` files is the `constexpr` keyword dropping off these two declarations, 18 lines in total. `HighResTimeStamp::fromDOMHighResTimeStamp` now delegates to `HighResDuration`'s so there is a single implementation. `highResTimeStampTest` previously asserted on `HighResTimeStamp::now()`, whose magnitude is host-uptime-dependent, so it only tripped the bug on about 2% of runs. It now round-trips five fixed nanosecond values (including the exact value from the failing run), which exercises the bug on every run. No test was skipped, disabled, or loosened. Changelog: [General][Fixed] - Round instead of truncate when converting a `DOMHighResTimeStamp` back to nanoseconds, so `HighResTimeStamp` and `HighResDuration` round trips are exact Reviewed By: javache Differential Revision: D116286868 fbshipit-source-id: 1adafd1b57b1185f51f08fa4dc55d96b88c176cd --- .../react/bridging/tests/BridgingTest.cpp | 33 ++++++++---- .../ReactCommon/react/timing/primitives.h | 19 ++++--- .../react/timing/tests/PrimitivesTest.cpp | 53 +++++++++++++++++++ .../api-snapshots/ReactAndroidDebugCxx.api | 4 +- .../api-snapshots/ReactAndroidNewarchCxx.api | 4 +- .../api-snapshots/ReactAndroidReleaseCxx.api | 4 +- .../api-snapshots/ReactAppleDebugCxx.api | 4 +- .../api-snapshots/ReactAppleNewarchCxx.api | 4 +- .../api-snapshots/ReactAppleReleaseCxx.api | 4 +- .../api-snapshots/ReactCommonDebugCxx.api | 4 +- .../api-snapshots/ReactCommonNewarchCxx.api | 4 +- .../api-snapshots/ReactCommonReleaseCxx.api | 4 +- 12 files changed, 107 insertions(+), 34 deletions(-) diff --git a/packages/react-native/ReactCommon/react/bridging/tests/BridgingTest.cpp b/packages/react-native/ReactCommon/react/bridging/tests/BridgingTest.cpp index cec7c92657c..acf0c1e5b6b 100644 --- a/packages/react-native/ReactCommon/react/bridging/tests/BridgingTest.cpp +++ b/packages/react-native/ReactCommon/react/bridging/tests/BridgingTest.cpp @@ -5,6 +5,7 @@ * LICENSE file in the root directory of this source tree. */ +#include #include #include @@ -955,17 +956,29 @@ TEST_F(BridgingTest, asyncArrayBufferBridgingTest) { } TEST_F(BridgingTest, highResTimeStampTest) { - HighResTimeStamp timestamp = HighResTimeStamp::now(); - EXPECT_EQ( - timestamp, - bridging::fromJs( - rt, bridging::toJs(rt, timestamp), invoker)); + // Nanosecond counts that are not a whole number of milliseconds, spanning the + // magnitudes a monotonic clock reports (seconds to weeks since boot). Fixed + // values are used instead of `HighResTimeStamp::now()` so that the precision + // of the round trip does not depend on the uptime of the host running this + // test. + for (int64_t nanoseconds : + {1LL, 999'999LL, 1'000'001LL, 12'345'678'901LL, 537'648'854'729'250LL}) { + auto timestamp = HighResTimeStamp::fromChronoSteadyClockTimePoint( + std::chrono::steady_clock::time_point( + std::chrono::nanoseconds(nanoseconds))); + EXPECT_EQ( + timestamp, + bridging::fromJs( + rt, bridging::toJs(rt, timestamp), invoker)) + << "timestamp of " << nanoseconds << "ns did not round trip"; - auto duration = HighResDuration::fromNanoseconds(1); - EXPECT_EQ( - duration, - bridging::fromJs( - rt, bridging::toJs(rt, duration), invoker)); + auto duration = HighResDuration::fromNanoseconds(nanoseconds); + EXPECT_EQ( + duration, + bridging::fromJs( + rt, bridging::toJs(rt, duration), invoker)) + << "duration of " << nanoseconds << "ns did not round trip"; + } EXPECT_EQ(1.0, bridging::toJs(rt, HighResDuration::fromNanoseconds(1e6))); EXPECT_EQ( diff --git a/packages/react-native/ReactCommon/react/timing/primitives.h b/packages/react-native/ReactCommon/react/timing/primitives.h index 440e227a334..fbf7cae0747 100644 --- a/packages/react-native/ReactCommon/react/timing/primitives.h +++ b/packages/react-native/ReactCommon/react/timing/primitives.h @@ -9,6 +9,7 @@ #include #include +#include #include #ifdef __APPLE__ @@ -60,10 +61,15 @@ class HighResDuration { } // @see https://developer.mozilla.org/en-US/docs/Web/API/DOMHighResTimeStamp - static constexpr HighResDuration fromDOMHighResTimeStamp(double units) + // TODO: restore `constexpr` once this builds as C++23, where `std::llround` + // becomes usable in a constant expression (P0533). + static HighResDuration fromDOMHighResTimeStamp(double units) { - auto nanoseconds = static_cast(units * 1e6); - return fromNanoseconds(nanoseconds); + // Both the conversion to milliseconds and the multiplication back are + // inexact, so the product often lands just below the original count. + // Rounding to the nearest nanosecond (rather than truncating towards zero) + // is what makes the round trip through a DOMHighResTimeStamp lossless. + return fromNanoseconds(std::llround(units * 1e6)); } // @see https://developer.mozilla.org/en-US/docs/Web/API/DOMHighResTimeStamp @@ -225,10 +231,11 @@ class HighResTimeStamp { } // @see https://developer.mozilla.org/en-US/docs/Web/API/DOMHighResTimeStamp - static constexpr HighResTimeStamp fromDOMHighResTimeStamp(double units) + // TODO: restore `constexpr` together with + // `HighResDuration::fromDOMHighResTimeStamp`, which this delegates to. + static HighResTimeStamp fromDOMHighResTimeStamp(double units) { - auto nanoseconds = static_cast(units * 1e6); - return HighResTimeStamp(std::chrono::steady_clock::time_point(std::chrono::nanoseconds(nanoseconds))); + return HighResTimeStamp(std::chrono::steady_clock::time_point(HighResDuration::fromDOMHighResTimeStamp(units))); } // @see https://developer.mozilla.org/en-US/docs/Web/API/DOMHighResTimeStamp diff --git a/packages/react-native/ReactCommon/react/timing/tests/PrimitivesTest.cpp b/packages/react-native/ReactCommon/react/timing/tests/PrimitivesTest.cpp index f94a379c036..40709690706 100644 --- a/packages/react-native/ReactCommon/react/timing/tests/PrimitivesTest.cpp +++ b/packages/react-native/ReactCommon/react/timing/tests/PrimitivesTest.cpp @@ -7,10 +7,21 @@ #include +#include + #include "../primitives.h" namespace facebook::react { +// Nanosecond counts that are not a whole number of milliseconds, spanning the +// magnitudes a monotonic clock reports (seconds to weeks since boot). +constexpr std::array kRoundTripNanoseconds{ + 1, + 999'999, + 1'000'001, + 12'345'678'901, + 537'648'854'729'250}; + TEST(HighResDuration, CorrectlyConvertsToDOMHighResTimeStamp) { EXPECT_EQ( HighResDuration::fromNanoseconds(10).toDOMHighResTimeStamp(), 0.00001); @@ -30,6 +41,48 @@ TEST(HighResDuration, CorrectlyConvertsToDOMHighResTimeStamp) { HighResDuration::fromMilliseconds(10).toDOMHighResTimeStamp(), 10.0); } +TEST(HighResDuration, CorrectlyConvertsFromDOMHighResTimeStamp) { + EXPECT_EQ( + HighResDuration::fromDOMHighResTimeStamp(0.00001).toNanoseconds(), 10); + EXPECT_EQ( + HighResDuration::fromDOMHighResTimeStamp(1.000001).toNanoseconds(), + 1000001); + EXPECT_EQ( + HighResDuration::fromDOMHighResTimeStamp(-1.000001).toNanoseconds(), + -1000001); + EXPECT_EQ(HighResDuration::fromDOMHighResTimeStamp(0).toNanoseconds(), 0); +} + +TEST(HighResDuration, RoundTripsThroughDOMHighResTimeStamp) { + // A DOMHighResTimeStamp is a double holding milliseconds, so converting back + // to nanoseconds has to round: neither conversion is exact, and truncating + // would drop a nanosecond whenever the result lands just below the original + // value. + for (int64_t nanoseconds : kRoundTripNanoseconds) { + for (int64_t signedNanoseconds : {nanoseconds, -nanoseconds}) { + auto duration = HighResDuration::fromNanoseconds(signedNanoseconds); + EXPECT_EQ( + HighResDuration::fromDOMHighResTimeStamp( + duration.toDOMHighResTimeStamp()), + duration) + << "duration of " << signedNanoseconds << "ns did not round trip"; + } + } +} + +TEST(HighResTimeStamp, RoundTripsThroughDOMHighResTimeStamp) { + for (int64_t nanoseconds : kRoundTripNanoseconds) { + auto timestamp = HighResTimeStamp::fromChronoSteadyClockTimePoint( + std::chrono::steady_clock::time_point( + std::chrono::nanoseconds(nanoseconds))); + EXPECT_EQ( + HighResTimeStamp::fromDOMHighResTimeStamp( + timestamp.toDOMHighResTimeStamp()), + timestamp) + << "timestamp of " << nanoseconds << "ns did not round trip"; + } +} + TEST(HighResDuration, ComparisonOperators) { auto duration1 = HighResDuration::fromNanoseconds(10); auto duration2 = HighResDuration::fromNanoseconds(20); diff --git a/scripts/cxx-api/api-snapshots/ReactAndroidDebugCxx.api b/scripts/cxx-api/api-snapshots/ReactAndroidDebugCxx.api index 3147ca3a4c2..7a09696325a 100644 --- a/scripts/cxx-api/api-snapshots/ReactAndroidDebugCxx.api +++ b/scripts/cxx-api/api-snapshots/ReactAndroidDebugCxx.api @@ -2457,10 +2457,10 @@ class facebook::react::HighResDuration { public constexpr int64_t toNanoseconds() const; public constexpr operator std::chrono::steady_clock::duration() const; public static constexpr facebook::react::HighResDuration fromChrono(std::chrono::steady_clock::duration chronoDuration); - public static constexpr facebook::react::HighResDuration fromDOMHighResTimeStamp(double units); public static constexpr facebook::react::HighResDuration fromMilliseconds(int64_t units); public static constexpr facebook::react::HighResDuration fromNanoseconds(int64_t units); public static constexpr facebook::react::HighResDuration zero(); + public static facebook::react::HighResDuration fromDOMHighResTimeStamp(double units); } class facebook::react::HighResTimeStamp { @@ -2476,10 +2476,10 @@ class facebook::react::HighResTimeStamp { public constexpr facebook::react::HighResTimeStamp& operator-=(const facebook::react::HighResDuration& rhs); public constexpr std::chrono::steady_clock::time_point toChronoSteadyClockTimePoint() const; public static constexpr facebook::react::HighResTimeStamp fromChronoSteadyClockTimePoint(std::chrono::steady_clock::time_point chronoTimePoint); - public static constexpr facebook::react::HighResTimeStamp fromDOMHighResTimeStamp(double units); public static constexpr facebook::react::HighResTimeStamp max() noexcept; public static constexpr facebook::react::HighResTimeStamp min() noexcept; public static facebook::react::HighResDuration unsafeOriginFromUnixTimeStamp() noexcept; + public static facebook::react::HighResTimeStamp fromDOMHighResTimeStamp(double units); public static facebook::react::HighResTimeStamp now() noexcept; public static void setTimeStampProviderForTesting(std::function&& timeStampProvider); } diff --git a/scripts/cxx-api/api-snapshots/ReactAndroidNewarchCxx.api b/scripts/cxx-api/api-snapshots/ReactAndroidNewarchCxx.api index 3a93693562b..203eb8d6584 100644 --- a/scripts/cxx-api/api-snapshots/ReactAndroidNewarchCxx.api +++ b/scripts/cxx-api/api-snapshots/ReactAndroidNewarchCxx.api @@ -2440,10 +2440,10 @@ class facebook::react::HighResDuration { public constexpr int64_t toNanoseconds() const; public constexpr operator std::chrono::steady_clock::duration() const; public static constexpr facebook::react::HighResDuration fromChrono(std::chrono::steady_clock::duration chronoDuration); - public static constexpr facebook::react::HighResDuration fromDOMHighResTimeStamp(double units); public static constexpr facebook::react::HighResDuration fromMilliseconds(int64_t units); public static constexpr facebook::react::HighResDuration fromNanoseconds(int64_t units); public static constexpr facebook::react::HighResDuration zero(); + public static facebook::react::HighResDuration fromDOMHighResTimeStamp(double units); } class facebook::react::HighResTimeStamp { @@ -2459,10 +2459,10 @@ class facebook::react::HighResTimeStamp { public constexpr facebook::react::HighResTimeStamp& operator-=(const facebook::react::HighResDuration& rhs); public constexpr std::chrono::steady_clock::time_point toChronoSteadyClockTimePoint() const; public static constexpr facebook::react::HighResTimeStamp fromChronoSteadyClockTimePoint(std::chrono::steady_clock::time_point chronoTimePoint); - public static constexpr facebook::react::HighResTimeStamp fromDOMHighResTimeStamp(double units); public static constexpr facebook::react::HighResTimeStamp max() noexcept; public static constexpr facebook::react::HighResTimeStamp min() noexcept; public static facebook::react::HighResDuration unsafeOriginFromUnixTimeStamp() noexcept; + public static facebook::react::HighResTimeStamp fromDOMHighResTimeStamp(double units); public static facebook::react::HighResTimeStamp now() noexcept; } diff --git a/scripts/cxx-api/api-snapshots/ReactAndroidReleaseCxx.api b/scripts/cxx-api/api-snapshots/ReactAndroidReleaseCxx.api index 6c590266be4..7069aa6ed83 100644 --- a/scripts/cxx-api/api-snapshots/ReactAndroidReleaseCxx.api +++ b/scripts/cxx-api/api-snapshots/ReactAndroidReleaseCxx.api @@ -2455,10 +2455,10 @@ class facebook::react::HighResDuration { public constexpr int64_t toNanoseconds() const; public constexpr operator std::chrono::steady_clock::duration() const; public static constexpr facebook::react::HighResDuration fromChrono(std::chrono::steady_clock::duration chronoDuration); - public static constexpr facebook::react::HighResDuration fromDOMHighResTimeStamp(double units); public static constexpr facebook::react::HighResDuration fromMilliseconds(int64_t units); public static constexpr facebook::react::HighResDuration fromNanoseconds(int64_t units); public static constexpr facebook::react::HighResDuration zero(); + public static facebook::react::HighResDuration fromDOMHighResTimeStamp(double units); } class facebook::react::HighResTimeStamp { @@ -2474,10 +2474,10 @@ class facebook::react::HighResTimeStamp { public constexpr facebook::react::HighResTimeStamp& operator-=(const facebook::react::HighResDuration& rhs); public constexpr std::chrono::steady_clock::time_point toChronoSteadyClockTimePoint() const; public static constexpr facebook::react::HighResTimeStamp fromChronoSteadyClockTimePoint(std::chrono::steady_clock::time_point chronoTimePoint); - public static constexpr facebook::react::HighResTimeStamp fromDOMHighResTimeStamp(double units); public static constexpr facebook::react::HighResTimeStamp max() noexcept; public static constexpr facebook::react::HighResTimeStamp min() noexcept; public static facebook::react::HighResDuration unsafeOriginFromUnixTimeStamp() noexcept; + public static facebook::react::HighResTimeStamp fromDOMHighResTimeStamp(double units); public static facebook::react::HighResTimeStamp now() noexcept; } diff --git a/scripts/cxx-api/api-snapshots/ReactAppleDebugCxx.api b/scripts/cxx-api/api-snapshots/ReactAppleDebugCxx.api index fc31ab6a1d4..554e89df9e3 100644 --- a/scripts/cxx-api/api-snapshots/ReactAppleDebugCxx.api +++ b/scripts/cxx-api/api-snapshots/ReactAppleDebugCxx.api @@ -4915,10 +4915,10 @@ class facebook::react::HighResDuration { public constexpr int64_t toNanoseconds() const; public constexpr operator std::chrono::steady_clock::duration() const; public static constexpr facebook::react::HighResDuration fromChrono(std::chrono::steady_clock::duration chronoDuration); - public static constexpr facebook::react::HighResDuration fromDOMHighResTimeStamp(double units); public static constexpr facebook::react::HighResDuration fromMilliseconds(int64_t units); public static constexpr facebook::react::HighResDuration fromNanoseconds(int64_t units); public static constexpr facebook::react::HighResDuration zero(); + public static facebook::react::HighResDuration fromDOMHighResTimeStamp(double units); } class facebook::react::HighResTimeStamp { @@ -4934,10 +4934,10 @@ class facebook::react::HighResTimeStamp { public constexpr facebook::react::HighResTimeStamp& operator-=(const facebook::react::HighResDuration& rhs); public constexpr std::chrono::steady_clock::time_point toChronoSteadyClockTimePoint() const; public static constexpr facebook::react::HighResTimeStamp fromChronoSteadyClockTimePoint(std::chrono::steady_clock::time_point chronoTimePoint); - public static constexpr facebook::react::HighResTimeStamp fromDOMHighResTimeStamp(double units); public static constexpr facebook::react::HighResTimeStamp max() noexcept; public static constexpr facebook::react::HighResTimeStamp min() noexcept; public static facebook::react::HighResDuration unsafeOriginFromUnixTimeStamp() noexcept; + public static facebook::react::HighResTimeStamp fromDOMHighResTimeStamp(double units); public static facebook::react::HighResTimeStamp now() noexcept; public static void setTimeStampProviderForTesting(std::function&& timeStampProvider); } diff --git a/scripts/cxx-api/api-snapshots/ReactAppleNewarchCxx.api b/scripts/cxx-api/api-snapshots/ReactAppleNewarchCxx.api index 8b4ad148a0c..b7b6b8a85f1 100644 --- a/scripts/cxx-api/api-snapshots/ReactAppleNewarchCxx.api +++ b/scripts/cxx-api/api-snapshots/ReactAppleNewarchCxx.api @@ -4891,10 +4891,10 @@ class facebook::react::HighResDuration { public constexpr int64_t toNanoseconds() const; public constexpr operator std::chrono::steady_clock::duration() const; public static constexpr facebook::react::HighResDuration fromChrono(std::chrono::steady_clock::duration chronoDuration); - public static constexpr facebook::react::HighResDuration fromDOMHighResTimeStamp(double units); public static constexpr facebook::react::HighResDuration fromMilliseconds(int64_t units); public static constexpr facebook::react::HighResDuration fromNanoseconds(int64_t units); public static constexpr facebook::react::HighResDuration zero(); + public static facebook::react::HighResDuration fromDOMHighResTimeStamp(double units); } class facebook::react::HighResTimeStamp { @@ -4910,10 +4910,10 @@ class facebook::react::HighResTimeStamp { public constexpr facebook::react::HighResTimeStamp& operator-=(const facebook::react::HighResDuration& rhs); public constexpr std::chrono::steady_clock::time_point toChronoSteadyClockTimePoint() const; public static constexpr facebook::react::HighResTimeStamp fromChronoSteadyClockTimePoint(std::chrono::steady_clock::time_point chronoTimePoint); - public static constexpr facebook::react::HighResTimeStamp fromDOMHighResTimeStamp(double units); public static constexpr facebook::react::HighResTimeStamp max() noexcept; public static constexpr facebook::react::HighResTimeStamp min() noexcept; public static facebook::react::HighResDuration unsafeOriginFromUnixTimeStamp() noexcept; + public static facebook::react::HighResTimeStamp fromDOMHighResTimeStamp(double units); public static facebook::react::HighResTimeStamp now() noexcept; } diff --git a/scripts/cxx-api/api-snapshots/ReactAppleReleaseCxx.api b/scripts/cxx-api/api-snapshots/ReactAppleReleaseCxx.api index ac3b8b41aff..4a07179e470 100644 --- a/scripts/cxx-api/api-snapshots/ReactAppleReleaseCxx.api +++ b/scripts/cxx-api/api-snapshots/ReactAppleReleaseCxx.api @@ -4913,10 +4913,10 @@ class facebook::react::HighResDuration { public constexpr int64_t toNanoseconds() const; public constexpr operator std::chrono::steady_clock::duration() const; public static constexpr facebook::react::HighResDuration fromChrono(std::chrono::steady_clock::duration chronoDuration); - public static constexpr facebook::react::HighResDuration fromDOMHighResTimeStamp(double units); public static constexpr facebook::react::HighResDuration fromMilliseconds(int64_t units); public static constexpr facebook::react::HighResDuration fromNanoseconds(int64_t units); public static constexpr facebook::react::HighResDuration zero(); + public static facebook::react::HighResDuration fromDOMHighResTimeStamp(double units); } class facebook::react::HighResTimeStamp { @@ -4932,10 +4932,10 @@ class facebook::react::HighResTimeStamp { public constexpr facebook::react::HighResTimeStamp& operator-=(const facebook::react::HighResDuration& rhs); public constexpr std::chrono::steady_clock::time_point toChronoSteadyClockTimePoint() const; public static constexpr facebook::react::HighResTimeStamp fromChronoSteadyClockTimePoint(std::chrono::steady_clock::time_point chronoTimePoint); - public static constexpr facebook::react::HighResTimeStamp fromDOMHighResTimeStamp(double units); public static constexpr facebook::react::HighResTimeStamp max() noexcept; public static constexpr facebook::react::HighResTimeStamp min() noexcept; public static facebook::react::HighResDuration unsafeOriginFromUnixTimeStamp() noexcept; + public static facebook::react::HighResTimeStamp fromDOMHighResTimeStamp(double units); public static facebook::react::HighResTimeStamp now() noexcept; } diff --git a/scripts/cxx-api/api-snapshots/ReactCommonDebugCxx.api b/scripts/cxx-api/api-snapshots/ReactCommonDebugCxx.api index a55267301fe..ac7b12edbf9 100644 --- a/scripts/cxx-api/api-snapshots/ReactCommonDebugCxx.api +++ b/scripts/cxx-api/api-snapshots/ReactCommonDebugCxx.api @@ -1640,10 +1640,10 @@ class facebook::react::HighResDuration { public constexpr int64_t toNanoseconds() const; public constexpr operator std::chrono::steady_clock::duration() const; public static constexpr facebook::react::HighResDuration fromChrono(std::chrono::steady_clock::duration chronoDuration); - public static constexpr facebook::react::HighResDuration fromDOMHighResTimeStamp(double units); public static constexpr facebook::react::HighResDuration fromMilliseconds(int64_t units); public static constexpr facebook::react::HighResDuration fromNanoseconds(int64_t units); public static constexpr facebook::react::HighResDuration zero(); + public static facebook::react::HighResDuration fromDOMHighResTimeStamp(double units); } class facebook::react::HighResTimeStamp { @@ -1659,10 +1659,10 @@ class facebook::react::HighResTimeStamp { public constexpr facebook::react::HighResTimeStamp& operator-=(const facebook::react::HighResDuration& rhs); public constexpr std::chrono::steady_clock::time_point toChronoSteadyClockTimePoint() const; public static constexpr facebook::react::HighResTimeStamp fromChronoSteadyClockTimePoint(std::chrono::steady_clock::time_point chronoTimePoint); - public static constexpr facebook::react::HighResTimeStamp fromDOMHighResTimeStamp(double units); public static constexpr facebook::react::HighResTimeStamp max() noexcept; public static constexpr facebook::react::HighResTimeStamp min() noexcept; public static facebook::react::HighResDuration unsafeOriginFromUnixTimeStamp() noexcept; + public static facebook::react::HighResTimeStamp fromDOMHighResTimeStamp(double units); public static facebook::react::HighResTimeStamp now() noexcept; public static void setTimeStampProviderForTesting(std::function&& timeStampProvider); } diff --git a/scripts/cxx-api/api-snapshots/ReactCommonNewarchCxx.api b/scripts/cxx-api/api-snapshots/ReactCommonNewarchCxx.api index a656f67538e..088372f7849 100644 --- a/scripts/cxx-api/api-snapshots/ReactCommonNewarchCxx.api +++ b/scripts/cxx-api/api-snapshots/ReactCommonNewarchCxx.api @@ -1624,10 +1624,10 @@ class facebook::react::HighResDuration { public constexpr int64_t toNanoseconds() const; public constexpr operator std::chrono::steady_clock::duration() const; public static constexpr facebook::react::HighResDuration fromChrono(std::chrono::steady_clock::duration chronoDuration); - public static constexpr facebook::react::HighResDuration fromDOMHighResTimeStamp(double units); public static constexpr facebook::react::HighResDuration fromMilliseconds(int64_t units); public static constexpr facebook::react::HighResDuration fromNanoseconds(int64_t units); public static constexpr facebook::react::HighResDuration zero(); + public static facebook::react::HighResDuration fromDOMHighResTimeStamp(double units); } class facebook::react::HighResTimeStamp { @@ -1643,10 +1643,10 @@ class facebook::react::HighResTimeStamp { public constexpr facebook::react::HighResTimeStamp& operator-=(const facebook::react::HighResDuration& rhs); public constexpr std::chrono::steady_clock::time_point toChronoSteadyClockTimePoint() const; public static constexpr facebook::react::HighResTimeStamp fromChronoSteadyClockTimePoint(std::chrono::steady_clock::time_point chronoTimePoint); - public static constexpr facebook::react::HighResTimeStamp fromDOMHighResTimeStamp(double units); public static constexpr facebook::react::HighResTimeStamp max() noexcept; public static constexpr facebook::react::HighResTimeStamp min() noexcept; public static facebook::react::HighResDuration unsafeOriginFromUnixTimeStamp() noexcept; + public static facebook::react::HighResTimeStamp fromDOMHighResTimeStamp(double units); public static facebook::react::HighResTimeStamp now() noexcept; } diff --git a/scripts/cxx-api/api-snapshots/ReactCommonReleaseCxx.api b/scripts/cxx-api/api-snapshots/ReactCommonReleaseCxx.api index fb242064a36..d248d7df3aa 100644 --- a/scripts/cxx-api/api-snapshots/ReactCommonReleaseCxx.api +++ b/scripts/cxx-api/api-snapshots/ReactCommonReleaseCxx.api @@ -1638,10 +1638,10 @@ class facebook::react::HighResDuration { public constexpr int64_t toNanoseconds() const; public constexpr operator std::chrono::steady_clock::duration() const; public static constexpr facebook::react::HighResDuration fromChrono(std::chrono::steady_clock::duration chronoDuration); - public static constexpr facebook::react::HighResDuration fromDOMHighResTimeStamp(double units); public static constexpr facebook::react::HighResDuration fromMilliseconds(int64_t units); public static constexpr facebook::react::HighResDuration fromNanoseconds(int64_t units); public static constexpr facebook::react::HighResDuration zero(); + public static facebook::react::HighResDuration fromDOMHighResTimeStamp(double units); } class facebook::react::HighResTimeStamp { @@ -1657,10 +1657,10 @@ class facebook::react::HighResTimeStamp { public constexpr facebook::react::HighResTimeStamp& operator-=(const facebook::react::HighResDuration& rhs); public constexpr std::chrono::steady_clock::time_point toChronoSteadyClockTimePoint() const; public static constexpr facebook::react::HighResTimeStamp fromChronoSteadyClockTimePoint(std::chrono::steady_clock::time_point chronoTimePoint); - public static constexpr facebook::react::HighResTimeStamp fromDOMHighResTimeStamp(double units); public static constexpr facebook::react::HighResTimeStamp max() noexcept; public static constexpr facebook::react::HighResTimeStamp min() noexcept; public static facebook::react::HighResDuration unsafeOriginFromUnixTimeStamp() noexcept; + public static facebook::react::HighResTimeStamp fromDOMHighResTimeStamp(double units); public static facebook::react::HighResTimeStamp now() noexcept; }