mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
Fix Native Rotation Android (#18872)
Summary: Fixes #14161 Android crashes in some cases if an animated transform config contains a string value, like a rotation. This PR fixes that by ensuring all values sent to the native side are doubles. It adds `__transformDataType` to AnimatedTransform.js. Added integration test `ReactAndroid/src/androidText/js/AnimatedTransformTestModule.js` This test fails with the following error `INSTRUMENTATION_RESULT: longMsg=java.lang.ClassCastException: java.lang.String cannot be cast to java.lang.Double`, if the changes to AnimatedTransform.js are reverted. [Android] [Fixed] - Fixes Android crash on animated style with string rotation Pull Request resolved: https://github.com/facebook/react-native/pull/18872 Differential Revision: D13894676 Pulled By: cpojer fbshipit-source-id: 297e8132563460802e53f3ac551c3ba9ed943736
This commit is contained in:
@@ -35,6 +35,11 @@ require('TimePickerDialogTestModule');
|
||||
const AppRegistry = require('AppRegistry');
|
||||
|
||||
const apps = [
|
||||
{
|
||||
appKey: 'AnimatedTransformTestApp',
|
||||
component: () =>
|
||||
require('AnimatedTransformTestModule').AnimatedTransformTestApp,
|
||||
},
|
||||
{
|
||||
appKey: 'CatalystRootViewTestApp',
|
||||
component: () =>
|
||||
|
||||
Reference in New Issue
Block a user