From c3a07b6dcc56260b288dc11ed168fd723c7c4256 Mon Sep 17 00:00:00 2001 From: Emily Janzer Date: Fri, 4 Oct 2019 10:51:46 -0700 Subject: [PATCH] Use volatile for sDidInit in ReactBridge Summary: In D17747958 I added a function to check the value of a static variable, but forgot to make sure it was accessed in a thread-safe manner. Adding `volatile` to the flag Reviewed By: makovkastar Differential Revision: D17763888 fbshipit-source-id: f227b69de1a0df6493424da3b276529555999f70 --- .../src/main/java/com/facebook/react/bridge/ReactBridge.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ReactAndroid/src/main/java/com/facebook/react/bridge/ReactBridge.java b/ReactAndroid/src/main/java/com/facebook/react/bridge/ReactBridge.java index a1848a73e88..ec7f09d633d 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/bridge/ReactBridge.java +++ b/ReactAndroid/src/main/java/com/facebook/react/bridge/ReactBridge.java @@ -16,7 +16,7 @@ public class ReactBridge { private static volatile long sLoadStartTime = 0; private static volatile long sLoadEndTime = 0; - private static boolean sDidInit = false; + private static volatile boolean sDidInit = false; public static boolean isInitialized() { return sDidInit;