Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Make android modal to appear underneath translucent StatusBar (#26706)

Browse Source 
Summary:
As described in https://github.com/facebook/react-native/issues/26559 , the modal is not appearing underneath translucent StatusBar so you can see previous view underneath the StatusBar instead. As a solution you can now provide prop to set the modal to have translucent StatusBar and therefore the content will appear underneath. I tried to reuse layout flags that are possibly set if you use StatusBar component but sadly values in them do not reflect the props set by StatusBar component.

## Changelog

[Android] [added] - Added statusBarTranslucent prop to Modal component, to indicate if StatusBar should appear translucent.
Pull Request resolved: https://github.com/facebook/react-native/pull/26706

Test Plan:
### With StatusBar translucent

![image](https://user-images.githubusercontent.com/3984319/66131336-8bfdf200-e5f3-11e9-940e-c6bb3f67ea6f.png)

``` <Modal statusBarTranslucent>```
### Without

![image](https://user-images.githubusercontent.com/3984319/66131403-a768fd00-e5f3-11e9-9814-ff7592b4ceac.png)

``` <Modal>```

Differential Revision: D17872874

Pulled By: mdvacca

fbshipit-source-id: 8c4b48a75cddf86c4429b62d0c63313e7a2dd1b8
This commit is contained in:
Pavol Fulop
2019-10-10 22:12:32 -07:00
committed by Facebook Github Bot
parent 7c20dc65d9
commit c35a419e5d
6 changed files with 41 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ReactAndroid/src/main/java/com/facebook/react/viewmanagers/ModalHostViewManagerInterface.java
+1
View File
@@ -17,6 +17,7 @@ public interface ModalHostViewManagerInterface<T extends View> {
void setAnimationType(T view, @Nullable String value);
void setPresentationStyle(T view, @Nullable String value);
void setTransparent(T view, boolean value);
void setStatusBarTranslucent(T view, boolean value);
void setHardwareAccelerated(T view, boolean value);
void setAnimated(T view, boolean value);
void setSupportedOrientations(T view, @Nullable ReadableArray value);