From c336bfa76e23fa058aacd5173229315c65217d22 Mon Sep 17 00:00:00 2001 From: Christoph Purrer Date: Tue, 10 Mar 2026 04:01:45 -0700 Subject: [PATCH] Remove unused headers in ReactCommon (#56006) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/56006 Remove `folly` and `sstream` headers in places where it is not needed Changelog: [Internal] Reviewed By: mdvacca, sammy-SC Differential Revision: D95709383 fbshipit-source-id: 5b09e7c9603aa4412f2f2a899bd2691bd7725e03 --- .../ReactCommon/jserrorhandler/JsErrorHandler.cpp | 1 + .../react-native/ReactCommon/jserrorhandler/JsErrorHandler.h | 2 +- .../ReactCommon/react/networking/NetworkReporter.h | 1 - .../react/performance/cdpmetrics/CdpPerfIssuesReporter.h | 1 - .../react/renderer/animationbackend/AnimationBackend.h | 1 - .../renderer/animationbackend/AnimationBackendCommitHook.h | 1 - .../ReactCommon/react/renderer/attributedstring/conversions.h | 1 - .../ReactCommon/react/renderer/components/image/conversions.h | 1 - .../renderer/components/scrollview/ScrollViewEventEmitter.h | 1 - .../react/renderer/components/scrollview/conversions.h | 1 - .../react/renderer/components/text/stateConversions.h | 1 - .../renderer/components/view/accessibilityPropsConversions.h | 1 - .../ReactCommon/react/renderer/graphics/ColorStop.h | 3 +++ .../ReactCommon/react/renderer/graphics/LinearGradient.h | 3 +++ .../ReactCommon/react/renderer/graphics/RadialGradient.h | 4 ++++ .../ReactCommon/react/renderer/uimanager/UIManagerBinding.h | 1 - 16 files changed, 12 insertions(+), 12 deletions(-) diff --git a/packages/react-native/ReactCommon/jserrorhandler/JsErrorHandler.cpp b/packages/react-native/ReactCommon/jserrorhandler/JsErrorHandler.cpp index 3ed51ff06c4..4dc291ed1a0 100644 --- a/packages/react-native/ReactCommon/jserrorhandler/JsErrorHandler.cpp +++ b/packages/react-native/ReactCommon/jserrorhandler/JsErrorHandler.cpp @@ -10,6 +10,7 @@ #include #include #include +#include #include #include "StackTraceParser.h" diff --git a/packages/react-native/ReactCommon/jserrorhandler/JsErrorHandler.h b/packages/react-native/ReactCommon/jserrorhandler/JsErrorHandler.h index 2a7919f4c6a..40d61f442f2 100644 --- a/packages/react-native/ReactCommon/jserrorhandler/JsErrorHandler.h +++ b/packages/react-native/ReactCommon/jserrorhandler/JsErrorHandler.h @@ -8,7 +8,7 @@ #pragma once #include -#include +#include #include namespace facebook::react { diff --git a/packages/react-native/ReactCommon/react/networking/NetworkReporter.h b/packages/react-native/ReactCommon/react/networking/NetworkReporter.h index 1a5cc3318fc..e76adbf6afe 100644 --- a/packages/react-native/ReactCommon/react/networking/NetworkReporter.h +++ b/packages/react-native/ReactCommon/react/networking/NetworkReporter.h @@ -9,7 +9,6 @@ #include "NetworkTypes.h" -#include #include #include diff --git a/packages/react-native/ReactCommon/react/performance/cdpmetrics/CdpPerfIssuesReporter.h b/packages/react-native/ReactCommon/react/performance/cdpmetrics/CdpPerfIssuesReporter.h index 12a1ef2222a..617646eb061 100644 --- a/packages/react-native/ReactCommon/react/performance/cdpmetrics/CdpPerfIssuesReporter.h +++ b/packages/react-native/ReactCommon/react/performance/cdpmetrics/CdpPerfIssuesReporter.h @@ -8,7 +8,6 @@ #pragma once #include -#include #include #include #include diff --git a/packages/react-native/ReactCommon/react/renderer/animationbackend/AnimationBackend.h b/packages/react-native/ReactCommon/react/renderer/animationbackend/AnimationBackend.h index deef1fb532e..bc2636df6c1 100644 --- a/packages/react-native/ReactCommon/react/renderer/animationbackend/AnimationBackend.h +++ b/packages/react-native/ReactCommon/react/renderer/animationbackend/AnimationBackend.h @@ -8,7 +8,6 @@ #pragma once #include -#include #include #include #include diff --git a/packages/react-native/ReactCommon/react/renderer/animationbackend/AnimationBackendCommitHook.h b/packages/react-native/ReactCommon/react/renderer/animationbackend/AnimationBackendCommitHook.h index 83b9bcf7899..a9dd272ff34 100644 --- a/packages/react-native/ReactCommon/react/renderer/animationbackend/AnimationBackendCommitHook.h +++ b/packages/react-native/ReactCommon/react/renderer/animationbackend/AnimationBackendCommitHook.h @@ -7,7 +7,6 @@ #pragma once -#include #include #include #include diff --git a/packages/react-native/ReactCommon/react/renderer/attributedstring/conversions.h b/packages/react-native/ReactCommon/react/renderer/attributedstring/conversions.h index a509abfab57..331e2019338 100644 --- a/packages/react-native/ReactCommon/react/renderer/attributedstring/conversions.h +++ b/packages/react-native/ReactCommon/react/renderer/attributedstring/conversions.h @@ -7,7 +7,6 @@ #pragma once -#include #include #include #include diff --git a/packages/react-native/ReactCommon/react/renderer/components/image/conversions.h b/packages/react-native/ReactCommon/react/renderer/components/image/conversions.h index 6cb1d0d4b10..17f1996fff2 100644 --- a/packages/react-native/ReactCommon/react/renderer/components/image/conversions.h +++ b/packages/react-native/ReactCommon/react/renderer/components/image/conversions.h @@ -9,7 +9,6 @@ #include -#include #include #include #include diff --git a/packages/react-native/ReactCommon/react/renderer/components/scrollview/ScrollViewEventEmitter.h b/packages/react-native/ReactCommon/react/renderer/components/scrollview/ScrollViewEventEmitter.h index 1879f155064..a3ae532996f 100644 --- a/packages/react-native/ReactCommon/react/renderer/components/scrollview/ScrollViewEventEmitter.h +++ b/packages/react-native/ReactCommon/react/renderer/components/scrollview/ScrollViewEventEmitter.h @@ -9,7 +9,6 @@ #include -#include #include #include #include diff --git a/packages/react-native/ReactCommon/react/renderer/components/scrollview/conversions.h b/packages/react-native/ReactCommon/react/renderer/components/scrollview/conversions.h index fa0171ae1c1..bd1b92fcb1d 100644 --- a/packages/react-native/ReactCommon/react/renderer/components/scrollview/conversions.h +++ b/packages/react-native/ReactCommon/react/renderer/components/scrollview/conversions.h @@ -7,7 +7,6 @@ #pragma once -#include #include #include #include diff --git a/packages/react-native/ReactCommon/react/renderer/components/text/stateConversions.h b/packages/react-native/ReactCommon/react/renderer/components/text/stateConversions.h index bc630c073bc..593671dcc92 100644 --- a/packages/react-native/ReactCommon/react/renderer/components/text/stateConversions.h +++ b/packages/react-native/ReactCommon/react/renderer/components/text/stateConversions.h @@ -7,7 +7,6 @@ #pragma once -#include #include #include #ifdef RN_SERIALIZABLE_STATE diff --git a/packages/react-native/ReactCommon/react/renderer/components/view/accessibilityPropsConversions.h b/packages/react-native/ReactCommon/react/renderer/components/view/accessibilityPropsConversions.h index de6408c4621..d9c0283a025 100644 --- a/packages/react-native/ReactCommon/react/renderer/components/view/accessibilityPropsConversions.h +++ b/packages/react-native/ReactCommon/react/renderer/components/view/accessibilityPropsConversions.h @@ -7,7 +7,6 @@ #pragma once -#include #include #include #include diff --git a/packages/react-native/ReactCommon/react/renderer/graphics/ColorStop.h b/packages/react-native/ReactCommon/react/renderer/graphics/ColorStop.h index 8914fc81e4e..b3136d4238b 100644 --- a/packages/react-native/ReactCommon/react/renderer/graphics/ColorStop.h +++ b/packages/react-native/ReactCommon/react/renderer/graphics/ColorStop.h @@ -12,7 +12,10 @@ #include #include #include + +#if RN_DEBUG_STRING_CONVERTIBLE #include +#endif namespace facebook::react { diff --git a/packages/react-native/ReactCommon/react/renderer/graphics/LinearGradient.h b/packages/react-native/ReactCommon/react/renderer/graphics/LinearGradient.h index 243333975f2..57168c953b1 100644 --- a/packages/react-native/ReactCommon/react/renderer/graphics/LinearGradient.h +++ b/packages/react-native/ReactCommon/react/renderer/graphics/LinearGradient.h @@ -12,7 +12,10 @@ #include #include +#if RN_DEBUG_STRING_CONVERTIBLE #include +#endif + #include #include diff --git a/packages/react-native/ReactCommon/react/renderer/graphics/RadialGradient.h b/packages/react-native/ReactCommon/react/renderer/graphics/RadialGradient.h index 8e70761b893..012487e7f82 100644 --- a/packages/react-native/ReactCommon/react/renderer/graphics/RadialGradient.h +++ b/packages/react-native/ReactCommon/react/renderer/graphics/RadialGradient.h @@ -12,7 +12,11 @@ #include #include #include + +#if RN_DEBUG_STRING_CONVERTIBLE #include +#endif + #include #include diff --git a/packages/react-native/ReactCommon/react/renderer/uimanager/UIManagerBinding.h b/packages/react-native/ReactCommon/react/renderer/uimanager/UIManagerBinding.h index 8ed65a645e4..0d1910b442b 100644 --- a/packages/react-native/ReactCommon/react/renderer/uimanager/UIManagerBinding.h +++ b/packages/react-native/ReactCommon/react/renderer/uimanager/UIManagerBinding.h @@ -7,7 +7,6 @@ #pragma once -#include #include #include #include