From c301a2525169d3785b79a944ed4bd9962c1caeb5 Mon Sep 17 00:00:00 2001 From: Nick Lefever Date: Wed, 14 May 2025 15:43:33 -0700 Subject: [PATCH] Add hitSlop prop diffing to View component (#51329) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/51329 See title Changelog: [Internal] Reviewed By: sammy-SC Differential Revision: D74741639 fbshipit-source-id: da7317c8800d2f25c69ecd7d3aca9b75350c2a56 --- .../components/view/HostPlatformViewProps.cpp | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/packages/react-native/ReactCommon/react/renderer/components/view/platform/android/react/renderer/components/view/HostPlatformViewProps.cpp b/packages/react-native/ReactCommon/react/renderer/components/view/platform/android/react/renderer/components/view/HostPlatformViewProps.cpp index 7321c4b9d1a..935ff00e987 100644 --- a/packages/react-native/ReactCommon/react/renderer/components/view/platform/android/react/renderer/components/view/HostPlatformViewProps.cpp +++ b/packages/react-native/ReactCommon/react/renderer/components/view/platform/android/react/renderer/components/view/HostPlatformViewProps.cpp @@ -527,6 +527,15 @@ static folly::dynamic toDynamic(const std::vector& filter) { return filterResult; } +static folly::dynamic toDynamic(const EdgeInsets& edgeInsets) { + folly::dynamic edgeInsetsResult = folly::dynamic::object(); + edgeInsetsResult["left"] = edgeInsets.left; + edgeInsetsResult["top"] = edgeInsets.top; + edgeInsetsResult["right"] = edgeInsets.right; + edgeInsetsResult["bottom"] = edgeInsets.bottom; + return edgeInsetsResult; +} + folly::dynamic HostPlatformViewProps::getDiffProps( const Props* prevProps) const { folly::dynamic result = folly::dynamic::object(); @@ -659,6 +668,10 @@ folly::dynamic HostPlatformViewProps::getDiffProps( } } + if (hitSlop != oldProps->hitSlop) { + result["hitSlop"] = toDynamic(hitSlop); + } + if (nativeId != oldProps->nativeId) { result["nativeID"] = nativeId; }