From c2fd35a4429c752dc2d10a789e4c5f48d22b1eeb Mon Sep 17 00:00:00 2001 From: Maddie Lord Date: Fri, 13 Dec 2024 13:35:08 -0800 Subject: [PATCH] Add logging in ReactInstanceManager.onHostPause when activity is incorrectly null (#48226) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/48226 Adding logging to onHostPause to help diagnose cases when the activity is incorrectly null. Reviewed By: fkgozali Differential Revision: D67123351 fbshipit-source-id: f694a3a89e4584776050f6bca2f33f2805528d4b --- .../java/com/facebook/react/ReactInstanceManager.java | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/ReactInstanceManager.java b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/ReactInstanceManager.java index ed7f80bbea4..8422b6ce183 100644 --- a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/ReactInstanceManager.java +++ b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/ReactInstanceManager.java @@ -651,6 +651,16 @@ public class ReactInstanceManager { @ThreadConfined(UI) public void onHostPause(@Nullable Activity activity) { if (mRequireActivity) { + if (mCurrentActivity == null) { + String message = + "ReactInstanceManager.onHostPause called with null activity, expected:" + + mCurrentActivity.getClass().getSimpleName(); + FLog.e(TAG, message); + StackTraceElement[] stackTrace = Thread.currentThread().getStackTrace(); + for (StackTraceElement element : stackTrace) { + FLog.e(TAG, element.toString()); + } + } Assertions.assertCondition(mCurrentActivity != null); } if (mCurrentActivity != null) {