From c2b75901cfb46af79f534f92f11dae9a93c654e7 Mon Sep 17 00:00:00 2001 From: Andrei Shikov Date: Wed, 28 Oct 2020 17:39:31 -0700 Subject: [PATCH] Change the order of handling exception and clearing react instance manager Summary: Changelog: [Internal] Added better explanation to help debugging ViewManager crashes Reviewed By: makovkastar Differential Revision: D24539229 fbshipit-source-id: 36a010324cbf29dfe63784682715b963394a87fb --- .../com/facebook/react/uimanager/ViewManagerRegistry.java | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/ReactAndroid/src/main/java/com/facebook/react/uimanager/ViewManagerRegistry.java b/ReactAndroid/src/main/java/com/facebook/react/uimanager/ViewManagerRegistry.java index 73c37c10f12..a6ceb3e395a 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/uimanager/ViewManagerRegistry.java +++ b/ReactAndroid/src/main/java/com/facebook/react/uimanager/ViewManagerRegistry.java @@ -56,7 +56,11 @@ public final class ViewManagerRegistry { if (mViewManagerResolver != null) { viewManager = getViewManagerFromResolver(className); if (viewManager != null) return viewManager; - throw new IllegalViewOperationException("ViewManagerResolver returned null for " + className); + throw new IllegalViewOperationException( + "ViewManagerResolver returned null for " + + className + + ", existing names are: " + + mViewManagerResolver.getViewManagerNames()); } throw new IllegalViewOperationException("No ViewManager found for class " + className); }