From c205b1d39155d15a51274e0577593fbf743b7e57 Mon Sep 17 00:00:00 2001 From: Amir Shalem Date: Sun, 22 Sep 2019 13:46:35 -0700 Subject: [PATCH] Use direct access to YogaConfig mNativePointer parameter Summary: Use direct access to YogaConfig mNativePointer parameter Results: ``` The following primary metrics showed statistically significant changes at the 95% confidence level: javaFullLifecycleAllocateCalculateReadLayout -1.25% javaLayoutReading 0.44% javaYogaNodeAllocateAndSetProps -1.92% javaYogaNodeAllocation -2.11% javaYogaNodeStylePropAssignment -0.89% ``` Differential Revision: D17519542 fbshipit-source-id: c39bfe1b0ecae9149dc6da2a0a7e936df215ec5b --- .../src/main/java/com/facebook/yoga/YogaConfigJNIBase.java | 2 +- .../src/main/java/com/facebook/yoga/YogaNodeJNIBase.java | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/ReactAndroid/src/main/java/com/facebook/yoga/YogaConfigJNIBase.java b/ReactAndroid/src/main/java/com/facebook/yoga/YogaConfigJNIBase.java index d8362dab9ee..c093c5c24c5 100644 --- a/ReactAndroid/src/main/java/com/facebook/yoga/YogaConfigJNIBase.java +++ b/ReactAndroid/src/main/java/com/facebook/yoga/YogaConfigJNIBase.java @@ -8,7 +8,7 @@ package com.facebook.yoga; public abstract class YogaConfigJNIBase extends YogaConfig { - protected long mNativePointer; + long mNativePointer; private YogaLogger mLogger; private YogaConfigJNIBase(long nativePointer) { diff --git a/ReactAndroid/src/main/java/com/facebook/yoga/YogaNodeJNIBase.java b/ReactAndroid/src/main/java/com/facebook/yoga/YogaNodeJNIBase.java index f253b95cd1a..dcf31bbe4a9 100644 --- a/ReactAndroid/src/main/java/com/facebook/yoga/YogaNodeJNIBase.java +++ b/ReactAndroid/src/main/java/com/facebook/yoga/YogaNodeJNIBase.java @@ -58,7 +58,7 @@ public abstract class YogaNodeJNIBase extends YogaNode implements Cloneable { } YogaNodeJNIBase(YogaConfig config) { - this(YogaNative.jni_YGNodeNewWithConfig(config.getNativePointer())); + this(YogaNative.jni_YGNodeNewWithConfig(((YogaConfigJNIBase)config).mNativePointer)); } public void reset() {