mirror of
https://github.com/facebook/react-native.git
synced 2026-11-18 20:19:07 +00:00
Add selection types to TextInput onChange event (#55043)
Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/55043 This change adds TypeScript/Flow types and RNTester examples for the `selection` data in `TextInput.onChange` event. This is the JS companion to the native changes that add selection data to the onChange event. NOTE:selection only represents the cursor location when returned via onChange as this will not be invoked on a pure selection change without text change. We should also add this note to the documentation. ## Why On the web, text input elements provide `selectionStart` and `selectionEnd` properties that are always accessible during input events. This change exposes the selection data that native now provides, allowing developers to access cursor position during onChange. ## What Changed 1. **Flow Types**: Added optional `selection?: Selection` to `TextInputChangeEventData` 2. **TypeScript Types**: Updated `ReactNativeApi.d.ts` with selection type 3. **RNTester**: Updated examples to display selection in event logs Changelog: [General][Added] - TextInput onChange event types now include optional selection data Reviewed By: cipolleschi, necolas Differential Revision: D90123294 fbshipit-source-id: 5b575b5c14d23ee53cb0de74b2703673af82513b
This commit is contained in:
1 parent
fbe6a686e6
commit
c1f5445f4a
3 files changed
+14
-5
No files matched your search
@@ -29,6 +29,7 @@ type TextInputChangeEventData = Readonly<{
|
||||
eventCount: number,
|
||||
target: number,
|
||||
text: string,
|
||||
selection?: Selection,
|
||||
}>;
|
||||
|
||||
export type TextInputChangeEvent =
|
||||
|
||||
+5
-4
@@ -4,7 +4,7 @@
|
||||
* This source code is licensed under the MIT license found in the
|
||||
* LICENSE file in the root directory of this source tree.
|
||||
*
|
||||
* @generated SignedSource<<da31eef1ef6a26b328457cff2dcd3160>>
|
||||
* @generated SignedSource<<ecbb7c5e2070421bc49b2b819bb05ae1>>
|
||||
*
|
||||
* This file was generated by scripts/js-api/build-types/index.js.
|
||||
*/
|
||||
@@ -5304,6 +5304,7 @@ declare type TextInputChangeEvent =
|
||||
NativeSyntheticEvent<TextInputChangeEventData>
|
||||
declare type TextInputChangeEventData = {
|
||||
readonly eventCount: number
|
||||
readonly selection?: Selection
|
||||
readonly target: number
|
||||
readonly text: string
|
||||
}
|
||||
@@ -6218,15 +6219,15 @@ export {
|
||||
TaskProvider, // 266dedf2
|
||||
Text, // e55ac2e2
|
||||
TextContentType, // 239b3ecc
|
||||
TextInput, // cf7a3331
|
||||
TextInput, // 2e89b91d
|
||||
TextInputAndroidProps, // 3f09ce49
|
||||
TextInputChangeEvent, // 380cbe93
|
||||
TextInputChangeEvent, // 6821f629
|
||||
TextInputContentSizeChangeEvent, // 5fba3f54
|
||||
TextInputEndEditingEvent, // 8c22fac3
|
||||
TextInputFocusEvent, // c36e977c
|
||||
TextInputIOSProps, // 0d05a855
|
||||
TextInputKeyPressEvent, // 967178c2
|
||||
TextInputProps, // a817a7f7
|
||||
TextInputProps, // c75f0362
|
||||
TextInputSelectionChangeEvent, // a1a7622f
|
||||
TextInputSubmitEditingEvent, // 48d903af
|
||||
TextLayoutEvent, // 45b0a8d7
|
||||
|
||||
@@ -393,7 +393,14 @@ class TextEventsExample extends React.Component<{...}, $FlowFixMe> {
|
||||
onFocus={() => this.updateText('onFocus')}
|
||||
onBlur={() => this.updateText('onBlur')}
|
||||
onChange={event =>
|
||||
this.updateText('onChange text: ' + event.nativeEvent.text)
|
||||
this.updateText(
|
||||
'onChange text: ' +
|
||||
event.nativeEvent.text +
|
||||
', selection: ' +
|
||||
(event.nativeEvent.selection != null
|
||||
? JSON.stringify(event.nativeEvent.selection)
|
||||
: 'undefined'),
|
||||
)
|
||||
}
|
||||
onContentSizeChange={event =>
|
||||
this.updateText(
|
||||
|
||||
Reference in new issue
Block a user