Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix download of nightlies with SwiftPM (#52215)

Browse Source 
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/52215

We were not handling the download of the XML properly. Using `Net::HTTP.get` will directly return the body and that won't let us check on the status code of the response.

## Changelog:
[Internal] - use get_response instead of get when downloading the maven metadata

Reviewed By: cortinico

Differential Revision: D77216121

fbshipit-source-id: 4da0abff1624c687977a7b77db8a15f19e6b887d
This commit is contained in:
Riccardo Cipolleschi
2025-06-24 06:01:36 -07:00
committed by Facebook GitHub Bot
parent f238b74658
commit c1bf39bfdf
3 changed files with 6 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/react-native/scripts/cocoapods/rncore.rb
+2 -2
View File
@@ -131,8 +131,8 @@ class ReactNativeCoreUtils
artefact_name = "reactnative-core-debug.tar.gz"
xml_url = "https://central.sonatype.com/repository/maven-snapshots/com/facebook/react/#{artefact_coordinate}/#{version}-SNAPSHOT/maven-metadata.xml"
response = Net::HTTP.get(URI(xml_url))
if response.kind_of? Net::HTTPSuccess
response = Net::HTTP.get_response(URI(xml_url))
if response.is_a?(Net::HTTPSuccess)
xml = REXML::Document.new(response)
timestamp = xml.elements['metadata/versioning/snapshot/timestamp'].text
build_number = xml.elements['metadata/versioning/snapshot/buildNumber'].text
packages/react-native/scripts/cocoapods/rndependencies.rb
+2 -3
View File
@@ -178,9 +178,8 @@ class ReactNativeDependenciesUtils
artifact_name = "reactnative-dependencies-debug.tar.gz"
xml_url = "https://central.sonatype.com/repository/maven-snapshots/com/facebook/react/#{artifact_coordinate}/#{version}-SNAPSHOT/maven-metadata.xml"
response = Net::HTTP.get(URI(xml_url))
if response.kind_of? Net::HTTPSuccess
response = Net::HTTP.get_response(URI(xml_url))
if response.is_a?(Net::HTTPSuccess)
xml = REXML::Document.new(response)
timestamp = xml.elements['metadata/versioning/snapshot/timestamp'].text
build_number = xml.elements['metadata/versioning/snapshot/buildNumber'].text
packages/react-native/sdks/hermes-engine/hermes-utils.rb
+2 -2
View File
@@ -234,8 +234,8 @@ def nightly_tarball_url(version)
artifact_name = "hermes-ios-debug.tar.gz"
xml_url = "https://central.sonatype.com/repository/maven-snapshots/com/facebook/react/#{artifact_coordinate}/#{version}-SNAPSHOT/maven-metadata.xml"
response = Net::HTTP.get(URI(xml_url))
if response.kind_of? Net::HTTPSuccess
response = Net::HTTP.get_response(URI(xml_url))
if response.is_a?(Net::HTTPSuccess)
xml = REXML::Document.new(response)
timestamp = xml.elements['metadata/versioning/snapshot/timestamp'].text
build_number = xml.elements['metadata/versioning/snapshot/buildNumber'].text