From c1ad8ae2ee1bb0cad1806d0a99e8d5a2e9be47f2 Mon Sep 17 00:00:00 2001 From: generatedunixname89002005232357 Date: Wed, 9 Sep 2026 10:22:39 -0700 Subject: [PATCH] Revert D119305530: Clone ObjectMethod before toExpression in preset Differential Revision: D119305530 Original commit changeset: dd30a94e91ed Original Phabricator Diff: D119305530 fbshipit-source-id: a38c93b5f7949126f0a33f801f77b01c574e13a3 --- .../src/__tests__/inline-platform-plugin-test.js | 9 --------- .../src/inline-platform-plugin.js | 4 +--- 2 files changed, 1 insertion(+), 12 deletions(-) diff --git a/packages/react-native-babel-preset/src/__tests__/inline-platform-plugin-test.js b/packages/react-native-babel-preset/src/__tests__/inline-platform-plugin-test.js index fd217bb5258..8c3d53dba1a 100644 --- a/packages/react-native-babel-preset/src/__tests__/inline-platform-plugin-test.js +++ b/packages/react-native-babel-preset/src/__tests__/inline-platform-plugin-test.js @@ -493,15 +493,6 @@ describe('Platform.select', () => { `); }); - test('does not mutate object methods when bailing out on impure initializers', () => { - expectUnchanged(` - const value = require('react-native').Platform.select({ - ios() { return 1; }, - android: sideEffect(), - }); - `); - }); - test('does not inline computed keys', () => { expect(select('{[key]: 1, default: 2}')).toContain('Platform.select'); }); diff --git a/packages/react-native-babel-preset/src/inline-platform-plugin.js b/packages/react-native-babel-preset/src/inline-platform-plugin.js index 2bba88342fa..3981c94787d 100644 --- a/packages/react-native-babel-preset/src/inline-platform-plugin.js +++ b/packages/react-native-babel-preset/src/inline-platform-plugin.js @@ -443,9 +443,7 @@ module.exports = function inlinePlatformPlugin( if (t.isObjectProperty(property)) { return property.value; } - // Clone: toExpression mutates in place, e.g. `ios() {}` would be - // left mutated if the purity check below bails out. - return t.toExpression(t.cloneNode(property)); + return t.toExpression(property); } } return fallback();