From c1a8ae412b3cc49cfe31d9cbce05fc9d41751262 Mon Sep 17 00:00:00 2001 From: Nicola Corti Date: Mon, 22 Jul 2024 06:39:04 -0700 Subject: [PATCH] Properly annotate with @Deprecated methods that are just deprecated in JavaDoc (#45570) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/45570 We do have several methods/classes that are `deprecated` in the JavaDoc but not with an annotation. That's not correct as users will never get those deprecation otherwise and we'll be forced to keep both implementation around for a longer time. Changelog: [Internal] [Changed] - Properly annotate with Deprecated methods that are just deprecated in JavaDoc Reviewed By: javache Differential Revision: D60036159 fbshipit-source-id: 466072d6a3fb4f1220e1dc3deaa51a46c714a388 --- .../java/com/facebook/react/modules/dialog/AlertFragment.java | 1 + .../react/uimanager/drawable/CSSBackgroundDrawable.java | 2 ++ .../facebook/react/views/view/ReactViewBackgroundDrawable.java | 2 ++ .../main/java/com/facebook/react/views/view/ReactViewGroup.java | 2 ++ .../java/com/facebook/react/views/view/ReactViewManager.java | 1 + 5 files changed, 8 insertions(+) diff --git a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/modules/dialog/AlertFragment.java b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/modules/dialog/AlertFragment.java index 00cd846162c..7a8eb59d0f9 100644 --- a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/modules/dialog/AlertFragment.java +++ b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/modules/dialog/AlertFragment.java @@ -151,6 +151,7 @@ public class AlertFragment extends DialogFragment implements DialogInterface.OnC * * @deprecated non-AppCompat dialogs are deprecated and will be removed in a future version. */ + @Deprecated(since = "0.75.0", forRemoval = true) private static Dialog createAppDialog( Context activityContext, Bundle arguments, DialogInterface.OnClickListener fragment) { android.app.AlertDialog.Builder builder = new android.app.AlertDialog.Builder(activityContext); diff --git a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/drawable/CSSBackgroundDrawable.java b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/drawable/CSSBackgroundDrawable.java index 0e438cccc92..7369bc9de44 100644 --- a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/drawable/CSSBackgroundDrawable.java +++ b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/drawable/CSSBackgroundDrawable.java @@ -265,6 +265,7 @@ public class CSSBackgroundDrawable extends Drawable { /** * @deprecated Use {@link #setBorderRadius(BorderRadiusProp, LengthPercentage)} instead. */ + @Deprecated(since = "0.75.0", forRemoval = true) public void setRadius(float radius) { @Nullable Float boxedRadius = Float.isNaN(radius) ? null : Float.valueOf(radius); if (boxedRadius == null) { @@ -279,6 +280,7 @@ public class CSSBackgroundDrawable extends Drawable { /** * @deprecated Use {@link #setBorderRadius(BorderRadiusProp, LengthPercentage)} instead. */ + @Deprecated(since = "0.75.0", forRemoval = true) public void setRadius(float radius, int position) { @Nullable Float boxedRadius = Float.isNaN(radius) ? null : Float.valueOf(radius); diff --git a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/view/ReactViewBackgroundDrawable.java b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/view/ReactViewBackgroundDrawable.java index f9c43850864..7b1dd067c6a 100644 --- a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/view/ReactViewBackgroundDrawable.java +++ b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/view/ReactViewBackgroundDrawable.java @@ -13,10 +13,12 @@ import com.facebook.react.uimanager.drawable.CSSBackgroundDrawable; /** * @deprecated Please use {@link CSSBackgroundDrawable} instead */ +@Deprecated(since = "0.75.0", forRemoval = true) public class ReactViewBackgroundDrawable extends CSSBackgroundDrawable { /** * @deprecated Please use {@link CSSBackgroundDrawable} instead */ + @Deprecated(since = "0.75.0", forRemoval = true) public ReactViewBackgroundDrawable(Context context) { super(context); } diff --git a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/view/ReactViewGroup.java b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/view/ReactViewGroup.java index b50a6257b25..31ed523bdd2 100644 --- a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/view/ReactViewGroup.java +++ b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/view/ReactViewGroup.java @@ -312,6 +312,7 @@ public class ReactViewGroup extends ViewGroup /** * @deprecated Use {@link #setBorderRadius(BorderRadiusProp, Float)} instead. */ + @Deprecated(since = "0.75.0", forRemoval = true) public void setBorderRadius(float borderRadius) { CSSBackgroundDrawable backgroundDrawable = getOrCreateReactViewBackground(); backgroundDrawable.setRadius(borderRadius); @@ -320,6 +321,7 @@ public class ReactViewGroup extends ViewGroup /** * @deprecated Use {@link #setBorderRadius(BorderRadiusProp, Float)} instead. */ + @Deprecated(since = "0.75.0", forRemoval = true) public void setBorderRadius(float borderRadius, int position) { CSSBackgroundDrawable backgroundDrawable = getOrCreateReactViewBackground(); backgroundDrawable.setRadius(borderRadius, position); diff --git a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/view/ReactViewManager.java b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/view/ReactViewManager.java index 4680fc5f237..95fcd8e37ad 100644 --- a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/view/ReactViewManager.java +++ b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/view/ReactViewManager.java @@ -139,6 +139,7 @@ public class ReactViewManager extends ReactClippingViewManager { /** * @deprecated Use {@link #setBorderRadius(ReactViewGroup, int, Dynamic)} instead. */ + @Deprecated(since = "0.75.0", forRemoval = true) public void setBorderRadius(ReactViewGroup view, int index, float borderRadius) { setBorderRadius(view, index, new DynamicFromObject(borderRadius)); }