From c10c147bccd001dcff152fb5c8ea9fd7f590c868 Mon Sep 17 00:00:00 2001 From: Emily Janzer Date: Tue, 22 Oct 2019 19:32:31 -0700 Subject: [PATCH] Fix a parameter type in NativeNetworkingAndroidSpec Summary: `responseType` should be a string, not an Object (which gets converted to a NativeMap by TM). Changelog: [General] [Fixed] Fix the flow type for NativeNetworkingModule Reviewed By: fkgozali Differential Revision: D18019418 fbshipit-source-id: 316470ca82241223eafb5b05a54fc2bbf3074821 --- .../FBReactNativeSpec/FBReactNativeSpec/FBReactNativeSpec.h | 2 +- Libraries/Network/NativeNetworkingAndroid.js | 2 +- .../facebook/fbreact/specs/NativeNetworkingAndroidSpec.java | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/Libraries/FBReactNativeSpec/FBReactNativeSpec/FBReactNativeSpec.h b/Libraries/FBReactNativeSpec/FBReactNativeSpec/FBReactNativeSpec.h index 717a8fc7116..7eed174102d 100644 --- a/Libraries/FBReactNativeSpec/FBReactNativeSpec/FBReactNativeSpec.h +++ b/Libraries/FBReactNativeSpec/FBReactNativeSpec/FBReactNativeSpec.h @@ -1598,7 +1598,7 @@ namespace JS { requestId:(double)requestId headers:(NSArray *)headers data:(NSDictionary *)data - responseType:(NSDictionary *)responseType + responseType:(NSString *)responseType useIncrementalUpdates:(BOOL)useIncrementalUpdates timeout:(double)timeout withCredentials:(BOOL)withCredentials; diff --git a/Libraries/Network/NativeNetworkingAndroid.js b/Libraries/Network/NativeNetworkingAndroid.js index 573090d7d26..3d65967736d 100644 --- a/Libraries/Network/NativeNetworkingAndroid.js +++ b/Libraries/Network/NativeNetworkingAndroid.js @@ -22,7 +22,7 @@ export interface Spec extends TurboModule { requestId: number, headers: Array
, data: Object, - responseType: Object, // TODO: Use stricter type. + responseType: string, useIncrementalUpdates: boolean, timeout: number, withCredentials: boolean, diff --git a/ReactAndroid/src/main/java/com/facebook/fbreact/specs/NativeNetworkingAndroidSpec.java b/ReactAndroid/src/main/java/com/facebook/fbreact/specs/NativeNetworkingAndroidSpec.java index bdeb3ed49e4..22a46d4898d 100644 --- a/ReactAndroid/src/main/java/com/facebook/fbreact/specs/NativeNetworkingAndroidSpec.java +++ b/ReactAndroid/src/main/java/com/facebook/fbreact/specs/NativeNetworkingAndroidSpec.java @@ -37,8 +37,8 @@ public abstract class NativeNetworkingAndroidSpec extends ReactContextBaseJavaMo @ReactMethod public abstract void sendRequest(String method, String url, double requestId, - ReadableArray headers, ReadableMap data, ReadableMap responseType, - boolean useIncrementalUpdates, double timeout, boolean withCredentials); + ReadableArray headers, ReadableMap data, String responseType, boolean useIncrementalUpdates, + double timeout, boolean withCredentials); @ReactMethod public abstract void addListener(String eventName);