From c0c5e2276dd82f088d357a272633984787a8632e Mon Sep 17 00:00:00 2001 From: Onti Vals Date: Thu, 8 Aug 2019 01:35:07 -0700 Subject: [PATCH] React edit text changes (#25964) Summary: Changing showSoftKeyboard and hideSoftKeyboard to be protected, as we need this change for an internal control that extends ReactEditText. ## Changelog [Android] [Changed] - part of our react native platform, we have a control that extends ReactEditText and we need to be able to override these 2 methods. Pull Request resolved: https://github.com/facebook/react-native/pull/25964 Test Plan: The change has been in Microsoft's branch of RN for almost 2 years, and since it's a relatively small change we've done a quick sanity check in RNTester prior to this PR, making sure the TextInput page loads fine and it's functional. Differential Revision: D16686878 Pulled By: cpojer fbshipit-source-id: 63035ee9c58e93bc0fa40e5bec318df05322c6c5 --- .../com/facebook/react/views/textinput/ReactEditText.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ReactAndroid/src/main/java/com/facebook/react/views/textinput/ReactEditText.java b/ReactAndroid/src/main/java/com/facebook/react/views/textinput/ReactEditText.java index 542b5ee0391..46487c48134 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/views/textinput/ReactEditText.java +++ b/ReactAndroid/src/main/java/com/facebook/react/views/textinput/ReactEditText.java @@ -484,11 +484,11 @@ public class ReactEditText extends EditText { return true; } - private boolean showSoftKeyboard() { + protected boolean showSoftKeyboard() { return mInputMethodManager.showSoftInput(this, 0); } - private void hideSoftKeyboard() { + protected void hideSoftKeyboard() { mInputMethodManager.hideSoftInputFromWindow(getWindowToken(), 0); }