diff --git a/packages/react-native/ReactCommon/jserrorhandler/JsErrorHandler.cpp b/packages/react-native/ReactCommon/jserrorhandler/JsErrorHandler.cpp index 1c00b15dc95..d70a4463761 100644 --- a/packages/react-native/ReactCommon/jserrorhandler/JsErrorHandler.cpp +++ b/packages/react-native/ReactCommon/jserrorhandler/JsErrorHandler.cpp @@ -97,13 +97,11 @@ JsErrorHandler::JsErrorHandler( JsErrorHandler::~JsErrorHandler() {} -void JsErrorHandler::handleJsError(const jsi::JSError& error, bool isFatal) { +void JsErrorHandler::handleFatalError(const jsi::JSError& error) { // TODO: Current error parsing works and is stable. Can investigate using // REGEX_HERMES to get additional Hermes data, though it requires JS setup. - if (isFatal) { - _hasHandledFatalError = true; - } - ParsedError parsedError = parseErrorStack(error, isFatal, false); + _hasHandledFatalError = true; + ParsedError parsedError = parseErrorStack(error, true, false); _jsErrorHandlingFunc(parsedError); } diff --git a/packages/react-native/ReactCommon/jserrorhandler/JsErrorHandler.h b/packages/react-native/ReactCommon/jserrorhandler/JsErrorHandler.h index d7e16eb9e6b..53a03367989 100644 --- a/packages/react-native/ReactCommon/jserrorhandler/JsErrorHandler.h +++ b/packages/react-native/ReactCommon/jserrorhandler/JsErrorHandler.h @@ -32,7 +32,7 @@ class JsErrorHandler { explicit JsErrorHandler(JsErrorHandlingFunc jsErrorHandlingFunc); ~JsErrorHandler(); - void handleJsError(const jsi::JSError& error, bool isFatal); + void handleFatalError(const jsi::JSError& error); bool hasHandledFatalError(); private: diff --git a/packages/react-native/ReactCommon/react/runtime/ReactInstance.cpp b/packages/react-native/ReactCommon/react/runtime/ReactInstance.cpp index 1984ab3c3f1..440e9f5de57 100644 --- a/packages/react-native/ReactCommon/react/runtime/ReactInstance.cpp +++ b/packages/react-native/ReactCommon/react/runtime/ReactInstance.cpp @@ -222,7 +222,7 @@ void ReactInstance::loadScript( strongBufferedRuntimeExecuter->flush(); } } catch (jsi::JSError& error) { - jsErrorHandler_->handleJsError(error, true); + jsErrorHandler_->handleFatalError(error); } }); }