From c03d520e161081acd58df4af33d759d29adabefb Mon Sep 17 00:00:00 2001 From: Luna Wei Date: Mon, 2 Oct 2023 10:40:28 -0700 Subject: [PATCH] Set hermes for Android template project in testing Summary: Changelog: [Internal] - Set the hermes value as specified by the test-e2e-local script flag. Right now, the script incorrectly ignores the flag By default, the template project has `hermesEnabled=true` Reviewed By: cipolleschi Differential Revision: D49831355 fbshipit-source-id: 7fb8613fa86f2c6140b7d25b16aeb583e6e26c12 --- scripts/test-e2e-local.js | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/scripts/test-e2e-local.js b/scripts/test-e2e-local.js index 1806d650a0f..63f76324b69 100644 --- a/scripts/test-e2e-local.js +++ b/scripts/test-e2e-local.js @@ -252,6 +252,16 @@ async function testRNTestProject(circleCIArtifacts) { `echo "react.internal.mavenLocalRepo=${mavenLocalPath}" >> android/gradle.properties`, ); + // Update gradle properties to set Hermes as false + if (!argv.hermes) { + sed( + '-i', + 'hermesEnabled=true', + 'hermesEnabled=false', + 'android/gradle.properties', + ); + } + // doing the pod install here so that it's easier to play around RNTestProject cd('ios'); exec('bundle install');