From bfd72ecab1504a13960cfd4aa33a79a7e47b02e6 Mon Sep 17 00:00:00 2001 From: David Vacca Date: Mon, 7 Mar 2022 16:17:46 -0800 Subject: [PATCH] Revert D31628461 Summary: Revert of D31628461 (https://github.com/facebook/react-native/commit/e494e4beb6a124008fd116178cbc38335bd87809), this diff broke Text selections in Android. Also I'm unable to reproduce original bug fixed by D31628461 (https://github.com/facebook/react-native/commit/e494e4beb6a124008fd116178cbc38335bd87809) changelog: [Android][Fixed] Fixed text selection, broken in 0.68 Reviewed By: ShikaSD Differential Revision: D34700739 fbshipit-source-id: 85cde0032632dc77eb77f91b63c5d3c29b1bbbaf --- .../com/facebook/react/views/text/ReactTextView.java | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/ReactAndroid/src/main/java/com/facebook/react/views/text/ReactTextView.java b/ReactAndroid/src/main/java/com/facebook/react/views/text/ReactTextView.java index 77885923046..c71a130419b 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/views/text/ReactTextView.java +++ b/ReactAndroid/src/main/java/com/facebook/react/views/text/ReactTextView.java @@ -19,7 +19,6 @@ import android.text.TextUtils; import android.text.method.LinkMovementMethod; import android.text.util.Linkify; import android.view.Gravity; -import android.view.MotionEvent; import android.view.View; import android.view.ViewGroup; import androidx.annotation.Nullable; @@ -383,16 +382,6 @@ public class ReactTextView extends AppCompatTextView implements ReactCompoundVie return target; } - @Override - public boolean onTouchEvent(MotionEvent ev) { - // The root view always assumes any view that was tapped wants the touch - // and sends the event to JS as such. - // We don't need to do bubbling in native (it's already happening in JS). - // For an explanation of bubbling and capturing, see - // http://javascript.info/tutorial/bubbling-and-capturing#capturing - return true; - } - @Override protected boolean verifyDrawable(Drawable drawable) { if (mContainsImages && getText() instanceof Spanned) {