From bfbd841f3873671a6693f4745df675a0819f25fc Mon Sep 17 00:00:00 2001 From: Samuel Susla Date: Thu, 22 Oct 2020 17:50:17 -0700 Subject: [PATCH] Remove redundant property from ImageRequest Summary: Changelog: [internal] `moved_`, introduced in D8526571 (https://github.com/facebook/react-native/commit/979ea2094e74ae8da0288fd5038f1f2838bd7763), no longer servers its purpose. Let's remove it. Reviewed By: JoshuaGross Differential Revision: D24475715 fbshipit-source-id: 162d1fc4ed3d4a67885d8f140904dd80763dcaa0 --- ReactCommon/react/renderer/imagemanager/ImageRequest.h | 5 ----- .../renderer/imagemanager/platform/ios/ImageRequest.cpp | 1 - 2 files changed, 6 deletions(-) diff --git a/ReactCommon/react/renderer/imagemanager/ImageRequest.h b/ReactCommon/react/renderer/imagemanager/ImageRequest.h index e3f30475664..48da2253099 100644 --- a/ReactCommon/react/renderer/imagemanager/ImageRequest.h +++ b/ReactCommon/react/renderer/imagemanager/ImageRequest.h @@ -96,11 +96,6 @@ class ImageRequest final { * Function we can call to cancel image request (see destructor). */ std::function cancelRequest_; - - /* - * Indicates that the object was moved and hence cannot be used anymore. - */ - bool moved_{false}; }; } // namespace react diff --git a/ReactCommon/react/renderer/imagemanager/platform/ios/ImageRequest.cpp b/ReactCommon/react/renderer/imagemanager/platform/ios/ImageRequest.cpp index ce7f9b2d045..e9ce8dcb9a0 100644 --- a/ReactCommon/react/renderer/imagemanager/platform/ios/ImageRequest.cpp +++ b/ReactCommon/react/renderer/imagemanager/platform/ios/ImageRequest.cpp @@ -21,7 +21,6 @@ ImageRequest::ImageRequest(ImageRequest &&other) noexcept : imageSource_(std::move(other.imageSource_)), telemetry_(std::move(other.telemetry_)), coordinator_(std::move(other.coordinator_)) { - other.moved_ = true; other.coordinator_ = nullptr; other.cancelRequest_ = nullptr; other.telemetry_ = nullptr;