mirror of
https://github.com/facebook/react-native.git
synced 2026-11-18 20:19:07 +00:00
Avoid fmod when rounding layout results to the pixel grid (#2041)
Summary: copysign(x - trunc(x), x) is bit-identical to fmod(x, 1.0) for every double but avoids the libm fmod loop, which is slow on Android's bionic. roundValueToPixelGridDouble runs six times per node on every layout pass. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D125600548 fbshipit-source-id: 7866bfb8619f7a6ec63bf799821a8c2270340a57 Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
1 parent
fd5392494f
commit
bf8d8c9a7a
1 file changed
+9
-1
@@ -10,6 +10,8 @@
|
|||||||
#include <yoga/algorithm/PixelGrid.h>
|
#include <yoga/algorithm/PixelGrid.h>
|
||||||
#include <yoga/numeric/Comparison.h>
|
#include <yoga/numeric/Comparison.h>
|
||||||
|
|
||||||
|
#include <cmath>
|
||||||
|
|
||||||
namespace facebook::yoga {
|
namespace facebook::yoga {
|
||||||
|
|
||||||
namespace {
|
namespace {
|
||||||
@@ -23,7 +25,13 @@ double roundValueToPixelGridDouble(
|
|||||||
// We want to calculate `fractional` such that `floor(scaledValue) =
|
// We want to calculate `fractional` such that `floor(scaledValue) =
|
||||||
// scaledValue
|
// scaledValue
|
||||||
// - fractional`.
|
// - fractional`.
|
||||||
double fractional = fmod(scaledValue, 1.0);
|
//
|
||||||
|
// `copysign(x - trunc(x), x)` is bit-identical to `fmod(x, 1.0)` for every
|
||||||
|
// double (including -0.0, infinities and NaN) but avoids the libm `fmod`
|
||||||
|
// loop, which is slow on some platforms (e.g. Android's bionic). This
|
||||||
|
// function runs six times per node on every layout pass.
|
||||||
|
double fractional =
|
||||||
|
std::copysign(scaledValue - std::trunc(scaledValue), scaledValue);
|
||||||
if (fractional < 0) {
|
if (fractional < 0) {
|
||||||
// This branch is for handling negative numbers for `value`.
|
// This branch is for handling negative numbers for `value`.
|
||||||
//
|
//
|
||||||
|
|||||||
Reference in new issue
Block a user