From bf8037cad0e2893017157abffc49787e0227181b Mon Sep 17 00:00:00 2001 From: David Vacca Date: Fri, 7 May 2021 20:39:25 -0700 Subject: [PATCH] Remove ReactFeatureFlags.useViewManagerDelegates Summary: This diff deleted the ReactFeatureFlags.useViewManagerDelegates, this has been enabled for 9+ months changelog: [internal] internal Reviewed By: JoshuaGross Differential Revision: D28265339 fbshipit-source-id: f5c97e77ca4fc72d2e2b8f891e800e362177d67a --- .../java/com/facebook/react/config/ReactFeatureFlags.java | 7 ------- .../java/com/facebook/react/uimanager/ViewManager.java | 5 ++--- 2 files changed, 2 insertions(+), 10 deletions(-) diff --git a/ReactAndroid/src/main/java/com/facebook/react/config/ReactFeatureFlags.java b/ReactAndroid/src/main/java/com/facebook/react/config/ReactFeatureFlags.java index 16619055908..a2d04534a75 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/config/ReactFeatureFlags.java +++ b/ReactAndroid/src/main/java/com/facebook/react/config/ReactFeatureFlags.java @@ -38,13 +38,6 @@ public class ReactFeatureFlags { */ public static boolean enableFabricLogs = false; - /** - * Should this application use a {@link com.facebook.react.uimanager.ViewManagerDelegate} (if - * provided) to update the view properties. If {@code false}, then the generated {@code - * ...$$PropsSetter} class will be used instead. - */ - public static boolean useViewManagerDelegates = false; - /** * Should this application use a {@link com.facebook.react.uimanager.ViewManagerDelegate} (if * provided) to execute the view commands. If {@code false}, then {@code receiveCommand} method diff --git a/ReactAndroid/src/main/java/com/facebook/react/uimanager/ViewManager.java b/ReactAndroid/src/main/java/com/facebook/react/uimanager/ViewManager.java index ccde14ae9c2..6af66a6f080 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/uimanager/ViewManager.java +++ b/ReactAndroid/src/main/java/com/facebook/react/uimanager/ViewManager.java @@ -15,7 +15,6 @@ import com.facebook.react.bridge.BaseJavaModule; import com.facebook.react.bridge.ReactApplicationContext; import com.facebook.react.bridge.ReadableArray; import com.facebook.react.bridge.ReadableMap; -import com.facebook.react.config.ReactFeatureFlags; import com.facebook.react.touch.JSResponderHandler; import com.facebook.react.touch.ReactInterceptingViewGroup; import com.facebook.react.uimanager.annotations.ReactProp; @@ -41,8 +40,8 @@ public abstract class ViewManager * @param props */ public void updateProperties(@NonNull T viewToUpdate, ReactStylesDiffMap props) { - final ViewManagerDelegate delegate; - if (ReactFeatureFlags.useViewManagerDelegates && (delegate = getDelegate()) != null) { + final ViewManagerDelegate delegate = getDelegate(); + if (delegate != null) { ViewManagerPropertyUpdater.updateProps(delegate, viewToUpdate, props); } else { ViewManagerPropertyUpdater.updateProps(this, viewToUpdate, props);