From bf405d70837e1319cfa83e4c5cbb7c9a69abd820 Mon Sep 17 00:00:00 2001 From: Pieter De Baets Date: Fri, 6 May 2022 02:45:47 -0700 Subject: [PATCH] Fix definition of NativeAnimated.isEmpty Summary: Noticed in D36098912 (https://github.com/facebook/react-native/commit/5de0f145eca36d3263cb8a9928add278cdfffa2b) that the definition of NativeAnimatedModule's OperationQueue.isEmpty was incorrect as it didn't account for `mPeekedOperation`, while `drainQueueIntoList` did. Changelog: [Internal] Reviewed By: mdvacca Differential Revision: D36109810 fbshipit-source-id: afd7059975ce6e5c65d1975d168a03f0881bd7c1 --- .../com/facebook/react/animated/NativeAnimatedModule.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ReactAndroid/src/main/java/com/facebook/react/animated/NativeAnimatedModule.java b/ReactAndroid/src/main/java/com/facebook/react/animated/NativeAnimatedModule.java index 7d9c6421171..a951694427e 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/animated/NativeAnimatedModule.java +++ b/ReactAndroid/src/main/java/com/facebook/react/animated/NativeAnimatedModule.java @@ -113,7 +113,7 @@ public class NativeAnimatedModule extends NativeAnimatedModuleSpec @AnyThread boolean isEmpty() { - return mQueue.isEmpty(); + return mQueue.isEmpty() && mPeekedOperation != null; } void setSynchronizedAccess(boolean isSynchronizedAccess) { @@ -150,7 +150,7 @@ public class NativeAnimatedModule extends NativeAnimatedModuleSpec @UiThread private @Nullable List drainQueueIntoList(long maxBatchNumber) { - if (mQueue.isEmpty() && mPeekedOperation == null) { + if (isEmpty()) { return null; }