From bf32023e505aa1a0378a770c8160bac7b8bf2f3e Mon Sep 17 00:00:00 2001
From: Emily Janzer <janzer@fb.com>
Date: Tue, 4 Feb 2020 11:07:02 -0800
Subject: [PATCH] The life-changing magic of clang-tidying up

Summary:
Adding a `.clang-tidy` to a bunch of dirs under `react-native-github/ReactAndroid` and `react-native-github/ReactCommon`.

I don't want to add a single `.clang-tidy` at the root because we'll need more fine-grained control over what checks are enabled in different parts of the codebase; for example, fabric will and TM will probably have more checks enabled than older parts of the codebase that we're not actively modernizing, and the Hermes team probably wants its own config to be consistent with the rest of their codebase.

Starting off each `.clang-tidy` by only enabling clang-diagnostic; this is just to test that it's working. In the future, we'll work with the community to gradually enable more checks.

Changelog: [Internal]

Reviewed By: mdvacca

Differential Revision: D19705749

fbshipit-source-id: 979cea053b645ac4a9790340033bfcfb49ca0f97
---
 ReactAndroid/src/main/java/com/facebook/hermes/.clang-tidy   | 5 +++++
 .../src/main/java/com/facebook/react/fabric/.clang-tidy      | 5 +++++
 .../src/main/java/com/facebook/react/modules/.clang-tidy     | 5 +++++
 .../src/main/java/com/facebook/react/turbomodule/.clang-tidy | 5 +++++
 ReactAndroid/src/main/jni/react/jni/.clang-tidy              | 5 +++++
 ReactCommon/callinvoker/.clang-tidy                          | 5 +++++
 ReactCommon/cxxreact/.clang-tidy                             | 5 +++++
 ReactCommon/fabric/.clang-tidy                               | 5 +++++
 ReactCommon/hermes/.clang-tidy                               | 5 +++++
 ReactCommon/jscallinvoker/.clang-tidy                        | 5 +++++
 ReactCommon/jsengineinstance/.clang-tidy                     | 5 +++++
 ReactCommon/jsi/.clang-tidy                                  | 5 +++++
 ReactCommon/jsiexecutor/.clang-tidy                          | 5 +++++
 ReactCommon/jsinspector/.clang-tidy                          | 5 +++++
 ReactCommon/turbomodule/.clang-tidy                          | 5 +++++
 ReactCommon/utils/.clang-tidy                                | 5 +++++
 16 files changed, 80 insertions(+)
 create mode 100644 ReactAndroid/src/main/java/com/facebook/hermes/.clang-tidy
 create mode 100644 ReactAndroid/src/main/java/com/facebook/react/fabric/.clang-tidy
 create mode 100644 ReactAndroid/src/main/java/com/facebook/react/modules/.clang-tidy
 create mode 100644 ReactAndroid/src/main/java/com/facebook/react/turbomodule/.clang-tidy
 create mode 100644 ReactAndroid/src/main/jni/react/jni/.clang-tidy
 create mode 100644 ReactCommon/callinvoker/.clang-tidy
 create mode 100644 ReactCommon/cxxreact/.clang-tidy
 create mode 100644 ReactCommon/fabric/.clang-tidy
 create mode 100644 ReactCommon/hermes/.clang-tidy
 create mode 100644 ReactCommon/jscallinvoker/.clang-tidy
 create mode 100644 ReactCommon/jsengineinstance/.clang-tidy
 create mode 100644 ReactCommon/jsi/.clang-tidy
 create mode 100644 ReactCommon/jsiexecutor/.clang-tidy
 create mode 100644 ReactCommon/jsinspector/.clang-tidy
 create mode 100644 ReactCommon/turbomodule/.clang-tidy
 create mode 100644 ReactCommon/utils/.clang-tidy

diff --git a/ReactAndroid/src/main/java/com/facebook/hermes/.clang-tidy b/ReactAndroid/src/main/java/com/facebook/hermes/.clang-tidy
new file mode 100644
index 00000000000..c98fd78ff64
--- /dev/null
+++ b/ReactAndroid/src/main/java/com/facebook/hermes/.clang-tidy
@@ -0,0 +1,5 @@
+---
+Checks: '>
+clang-diagnostic-*,
+'
+...
diff --git a/ReactAndroid/src/main/java/com/facebook/react/fabric/.clang-tidy b/ReactAndroid/src/main/java/com/facebook/react/fabric/.clang-tidy
new file mode 100644
index 00000000000..c98fd78ff64
--- /dev/null
+++ b/ReactAndroid/src/main/java/com/facebook/react/fabric/.clang-tidy
@@ -0,0 +1,5 @@
+---
+Checks: '>
+clang-diagnostic-*,
+'
+...
diff --git a/ReactAndroid/src/main/java/com/facebook/react/modules/.clang-tidy b/ReactAndroid/src/main/java/com/facebook/react/modules/.clang-tidy
new file mode 100644
index 00000000000..c98fd78ff64
--- /dev/null
+++ b/ReactAndroid/src/main/java/com/facebook/react/modules/.clang-tidy
@@ -0,0 +1,5 @@
+---
+Checks: '>
+clang-diagnostic-*,
+'
+...
diff --git a/ReactAndroid/src/main/java/com/facebook/react/turbomodule/.clang-tidy b/ReactAndroid/src/main/java/com/facebook/react/turbomodule/.clang-tidy
new file mode 100644
index 00000000000..c98fd78ff64
--- /dev/null
+++ b/ReactAndroid/src/main/java/com/facebook/react/turbomodule/.clang-tidy
@@ -0,0 +1,5 @@
+---
+Checks: '>
+clang-diagnostic-*,
+'
+...
diff --git a/ReactAndroid/src/main/jni/react/jni/.clang-tidy b/ReactAndroid/src/main/jni/react/jni/.clang-tidy
new file mode 100644
index 00000000000..c98fd78ff64
--- /dev/null
+++ b/ReactAndroid/src/main/jni/react/jni/.clang-tidy
@@ -0,0 +1,5 @@
+---
+Checks: '>
+clang-diagnostic-*,
+'
+...
diff --git a/ReactCommon/callinvoker/.clang-tidy b/ReactCommon/callinvoker/.clang-tidy
new file mode 100644
index 00000000000..c98fd78ff64
--- /dev/null
+++ b/ReactCommon/callinvoker/.clang-tidy
@@ -0,0 +1,5 @@
+---
+Checks: '>
+clang-diagnostic-*,
+'
+...
diff --git a/ReactCommon/cxxreact/.clang-tidy b/ReactCommon/cxxreact/.clang-tidy
new file mode 100644
index 00000000000..c98fd78ff64
--- /dev/null
+++ b/ReactCommon/cxxreact/.clang-tidy
@@ -0,0 +1,5 @@
+---
+Checks: '>
+clang-diagnostic-*,
+'
+...
diff --git a/ReactCommon/fabric/.clang-tidy b/ReactCommon/fabric/.clang-tidy
new file mode 100644
index 00000000000..c98fd78ff64
--- /dev/null
+++ b/ReactCommon/fabric/.clang-tidy
@@ -0,0 +1,5 @@
+---
+Checks: '>
+clang-diagnostic-*,
+'
+...
diff --git a/ReactCommon/hermes/.clang-tidy b/ReactCommon/hermes/.clang-tidy
new file mode 100644
index 00000000000..c98fd78ff64
--- /dev/null
+++ b/ReactCommon/hermes/.clang-tidy
@@ -0,0 +1,5 @@
+---
+Checks: '>
+clang-diagnostic-*,
+'
+...
diff --git a/ReactCommon/jscallinvoker/.clang-tidy b/ReactCommon/jscallinvoker/.clang-tidy
new file mode 100644
index 00000000000..c98fd78ff64
--- /dev/null
+++ b/ReactCommon/jscallinvoker/.clang-tidy
@@ -0,0 +1,5 @@
+---
+Checks: '>
+clang-diagnostic-*,
+'
+...
diff --git a/ReactCommon/jsengineinstance/.clang-tidy b/ReactCommon/jsengineinstance/.clang-tidy
new file mode 100644
index 00000000000..c98fd78ff64
--- /dev/null
+++ b/ReactCommon/jsengineinstance/.clang-tidy
@@ -0,0 +1,5 @@
+---
+Checks: '>
+clang-diagnostic-*,
+'
+...
diff --git a/ReactCommon/jsi/.clang-tidy b/ReactCommon/jsi/.clang-tidy
new file mode 100644
index 00000000000..c98fd78ff64
--- /dev/null
+++ b/ReactCommon/jsi/.clang-tidy
@@ -0,0 +1,5 @@
+---
+Checks: '>
+clang-diagnostic-*,
+'
+...
diff --git a/ReactCommon/jsiexecutor/.clang-tidy b/ReactCommon/jsiexecutor/.clang-tidy
new file mode 100644
index 00000000000..c98fd78ff64
--- /dev/null
+++ b/ReactCommon/jsiexecutor/.clang-tidy
@@ -0,0 +1,5 @@
+---
+Checks: '>
+clang-diagnostic-*,
+'
+...
diff --git a/ReactCommon/jsinspector/.clang-tidy b/ReactCommon/jsinspector/.clang-tidy
new file mode 100644
index 00000000000..c98fd78ff64
--- /dev/null
+++ b/ReactCommon/jsinspector/.clang-tidy
@@ -0,0 +1,5 @@
+---
+Checks: '>
+clang-diagnostic-*,
+'
+...
diff --git a/ReactCommon/turbomodule/.clang-tidy b/ReactCommon/turbomodule/.clang-tidy
new file mode 100644
index 00000000000..c98fd78ff64
--- /dev/null
+++ b/ReactCommon/turbomodule/.clang-tidy
@@ -0,0 +1,5 @@
+---
+Checks: '>
+clang-diagnostic-*,
+'
+...
diff --git a/ReactCommon/utils/.clang-tidy b/ReactCommon/utils/.clang-tidy
new file mode 100644
index 00000000000..c98fd78ff64
--- /dev/null
+++ b/ReactCommon/utils/.clang-tidy
@@ -0,0 +1,5 @@
+---
+Checks: '>
+clang-diagnostic-*,
+'
+...