mirror of
https://github.com/facebook/react-native.git
synced 2026-11-18 20:19:07 +00:00
Reduce JNI allocations when importing native maps (#58274)
Summary: Pull Request resolved: https://github.com/react/react-native/pull/58274 `ReadableNativeMap` materialization copied keys and created temporary JNI references for every imported type. Cache pointers to the stable native values and reuse global `ReadableType` references so importing maps and arrays does less allocation and lookup work. Writable maps can continue mutating after materialization because `folly::dynamic` stores object entries in reference-stable `F14NodeMap` nodes. Changelog: [Internal] Reviewed By: christophpurrer, rubennorte Differential Revision: D118277119 fbshipit-source-id: 955a60ef7f1eb4cb7549d64caa1238416e90b223
This commit is contained in:
1 parent
1b30a1f5a2
commit
bf0e377c0a
15 files changed
+101
-77
No files matched your search
@@ -1066,7 +1066,7 @@ uint8_t facebook::react::blueFromColor(facebook::react::SharedColor color) noexc
|
||||
uint8_t facebook::react::greenFromColor(facebook::react::SharedColor color) noexcept;
|
||||
uint8_t facebook::react::redFromColor(facebook::react::SharedColor color) noexcept;
|
||||
void facebook::react::FBReactNativeSpec_registerComponentDescriptorsFromCodegen(std::shared_ptr<const facebook::react::ComponentDescriptorProviderRegistry> registry);
|
||||
void facebook::react::addDynamicToJArray(jni::local_ref<jni::JArrayClass<jobject>> jarray, jint index, const folly::dynamic& dyn);
|
||||
void facebook::react::addDynamicToJArray(jni::alias_ref<jni::JArrayClass<jobject>> jarray, jint index, const folly::dynamic& dyn);
|
||||
void facebook::react::bindHasComponentProvider(facebook::jsi::Runtime& runtime, facebook::react::HasComponentProviderFunctionType&& provider);
|
||||
void facebook::react::bindNativeLogger(facebook::jsi::Runtime& runtime, facebook::react::Logger logger);
|
||||
void facebook::react::bindNativePerformanceNow(facebook::jsi::Runtime& runtime);
|
||||
@@ -7879,12 +7879,11 @@ struct facebook::react::ReadableNativeMap : public jni::HybridClass<facebook::re
|
||||
public static jni::local_ref<jhybridobject> createWithContents(folly::dynamic&& map);
|
||||
public static void mapException(std::exception_ptr ex);
|
||||
public static void registerNatives();
|
||||
public std::optional<folly::dynamic> keys_;
|
||||
}
|
||||
|
||||
struct facebook::react::ReadableType : public facebook::jni::JavaClass<facebook::react::ReadableType> {
|
||||
public static constexpr auto kJavaDescriptor;
|
||||
public static jni::local_ref<facebook::react::ReadableType> getType(folly::dynamic::Type type);
|
||||
public static jni::alias_ref<facebook::react::ReadableType> getType(folly::dynamic::Type type);
|
||||
}
|
||||
|
||||
struct facebook::react::RecoverableError : public std::exception {
|
||||
|
||||
@@ -1062,7 +1062,7 @@ uint8_t facebook::react::blueFromColor(facebook::react::SharedColor color) noexc
|
||||
uint8_t facebook::react::greenFromColor(facebook::react::SharedColor color) noexcept;
|
||||
uint8_t facebook::react::redFromColor(facebook::react::SharedColor color) noexcept;
|
||||
void facebook::react::FBReactNativeSpec_registerComponentDescriptorsFromCodegen(std::shared_ptr<const facebook::react::ComponentDescriptorProviderRegistry> registry);
|
||||
void facebook::react::addDynamicToJArray(jni::local_ref<jni::JArrayClass<jobject>> jarray, jint index, const folly::dynamic& dyn);
|
||||
void facebook::react::addDynamicToJArray(jni::alias_ref<jni::JArrayClass<jobject>> jarray, jint index, const folly::dynamic& dyn);
|
||||
void facebook::react::bindHasComponentProvider(facebook::jsi::Runtime& runtime, facebook::react::HasComponentProviderFunctionType&& provider);
|
||||
void facebook::react::bindNativeLogger(facebook::jsi::Runtime& runtime, facebook::react::Logger logger);
|
||||
void facebook::react::bindNativePerformanceNow(facebook::jsi::Runtime& runtime);
|
||||
@@ -7639,12 +7639,11 @@ struct facebook::react::ReadableNativeMap : public jni::HybridClass<facebook::re
|
||||
public static jni::local_ref<jhybridobject> createWithContents(folly::dynamic&& map);
|
||||
public static void mapException(std::exception_ptr ex);
|
||||
public static void registerNatives();
|
||||
public std::optional<folly::dynamic> keys_;
|
||||
}
|
||||
|
||||
struct facebook::react::ReadableType : public facebook::jni::JavaClass<facebook::react::ReadableType> {
|
||||
public static constexpr auto kJavaDescriptor;
|
||||
public static jni::local_ref<facebook::react::ReadableType> getType(folly::dynamic::Type type);
|
||||
public static jni::alias_ref<facebook::react::ReadableType> getType(folly::dynamic::Type type);
|
||||
}
|
||||
|
||||
struct facebook::react::RecoverableError : public std::exception {
|
||||
|
||||
@@ -1066,7 +1066,7 @@ uint8_t facebook::react::blueFromColor(facebook::react::SharedColor color) noexc
|
||||
uint8_t facebook::react::greenFromColor(facebook::react::SharedColor color) noexcept;
|
||||
uint8_t facebook::react::redFromColor(facebook::react::SharedColor color) noexcept;
|
||||
void facebook::react::FBReactNativeSpec_registerComponentDescriptorsFromCodegen(std::shared_ptr<const facebook::react::ComponentDescriptorProviderRegistry> registry);
|
||||
void facebook::react::addDynamicToJArray(jni::local_ref<jni::JArrayClass<jobject>> jarray, jint index, const folly::dynamic& dyn);
|
||||
void facebook::react::addDynamicToJArray(jni::alias_ref<jni::JArrayClass<jobject>> jarray, jint index, const folly::dynamic& dyn);
|
||||
void facebook::react::bindHasComponentProvider(facebook::jsi::Runtime& runtime, facebook::react::HasComponentProviderFunctionType&& provider);
|
||||
void facebook::react::bindNativeLogger(facebook::jsi::Runtime& runtime, facebook::react::Logger logger);
|
||||
void facebook::react::bindNativePerformanceNow(facebook::jsi::Runtime& runtime);
|
||||
@@ -7870,12 +7870,11 @@ struct facebook::react::ReadableNativeMap : public jni::HybridClass<facebook::re
|
||||
public static jni::local_ref<jhybridobject> createWithContents(folly::dynamic&& map);
|
||||
public static void mapException(std::exception_ptr ex);
|
||||
public static void registerNatives();
|
||||
public std::optional<folly::dynamic> keys_;
|
||||
}
|
||||
|
||||
struct facebook::react::ReadableType : public facebook::jni::JavaClass<facebook::react::ReadableType> {
|
||||
public static constexpr auto kJavaDescriptor;
|
||||
public static jni::local_ref<facebook::react::ReadableType> getType(folly::dynamic::Type type);
|
||||
public static jni::alias_ref<facebook::react::ReadableType> getType(folly::dynamic::Type type);
|
||||
}
|
||||
|
||||
struct facebook::react::RecoverableError : public std::exception {
|
||||
|
||||
Reference in new issue
Block a user