From becb9a3df67b7933e35c2fc245999ce2a6ec6cf4 Mon Sep 17 00:00:00 2001 From: David Vacca Date: Wed, 28 Feb 2024 08:47:35 -0800 Subject: [PATCH] Mark classes of package uimanager as @Nullsafe Summary: All these classes are NullSafe, let's mark them as NullSafe(Local) to ensure lint detect errors in the future bypass-github-export-checks changelog: [internal] internal Reviewed By: javache Differential Revision: D54027186 fbshipit-source-id: 2cee2b598c3ef15641222018703a7d6a467ba30c --- .../java/com/facebook/react/uimanager/SimpleViewManager.java | 2 ++ .../src/main/java/com/facebook/react/uimanager/Spacing.java | 2 ++ .../facebook/react/uimanager/UIConstantsProviderManager.java | 2 ++ 3 files changed, 6 insertions(+) diff --git a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/SimpleViewManager.java b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/SimpleViewManager.java index ef65aae2f83..18be6800791 100644 --- a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/SimpleViewManager.java +++ b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/SimpleViewManager.java @@ -8,6 +8,7 @@ package com.facebook.react.uimanager; import android.view.View; +import com.facebook.infer.annotation.Nullsafe; /** * Common base class for most of the {@link ViewManager}s. It provides support for most common @@ -17,6 +18,7 @@ import android.view.View; * * @param the view handled by this manager */ +@Nullsafe(Nullsafe.Mode.LOCAL) public abstract class SimpleViewManager extends BaseViewManager { diff --git a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/Spacing.java b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/Spacing.java index 9ff37664d52..889eeade9e4 100644 --- a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/Spacing.java +++ b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/Spacing.java @@ -7,6 +7,7 @@ package com.facebook.react.uimanager; +import com.facebook.infer.annotation.Nullsafe; import com.facebook.yoga.YogaConstants; import java.util.Arrays; @@ -15,6 +16,7 @@ import java.util.Arrays; * properly implement interactions and updates for properties like margin, marginLeft, and * marginHorizontal. */ +@Nullsafe(Nullsafe.Mode.LOCAL) public class Spacing { /** Spacing type that represents the left direction. E.g. {@code marginLeft}. */ diff --git a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/UIConstantsProviderManager.java b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/UIConstantsProviderManager.java index 06af0447224..5fdf6e535e2 100644 --- a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/UIConstantsProviderManager.java +++ b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/UIConstantsProviderManager.java @@ -7,6 +7,7 @@ package com.facebook.react.uimanager; +import com.facebook.infer.annotation.Nullsafe; import com.facebook.jni.HybridData; import com.facebook.proguard.annotations.DoNotStrip; import com.facebook.proguard.annotations.DoNotStripAny; @@ -15,6 +16,7 @@ import com.facebook.react.bridge.RuntimeExecutor; import com.facebook.soloader.SoLoader; import javax.annotation.Nullable; +@Nullsafe(Nullsafe.Mode.LOCAL) @DoNotStripAny public class UIConstantsProviderManager {