From becb47ccb6a6ed77e81b5488561ef6d683933ffe Mon Sep 17 00:00:00 2001 From: Riccardo Cipolleschi Date: Thu, 3 Nov 2022 17:51:33 +0000 Subject: [PATCH] [Fix] Let React Native decide the Hermes version to use in the Codegen --- scripts/cocoapods/__tests__/codegen_utils-test.rb | 2 +- scripts/cocoapods/codegen_utils.rb | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/scripts/cocoapods/__tests__/codegen_utils-test.rb b/scripts/cocoapods/__tests__/codegen_utils-test.rb index 69a5f8c2dc0..ed32aba80be 100644 --- a/scripts/cocoapods/__tests__/codegen_utils-test.rb +++ b/scripts/cocoapods/__tests__/codegen_utils-test.rb @@ -465,7 +465,7 @@ class CodegenUtilsTests < Test::Unit::TestCase "RCTTypeSafety": ["99.98.97"], "React-Core": ["99.98.97"], "React-jsi": ["99.98.97"], - "hermes-engine": ["99.98.97"], + "hermes-engine": [], "ReactCommon/turbomodule/core": ["99.98.97"] } } diff --git a/scripts/cocoapods/codegen_utils.rb b/scripts/cocoapods/codegen_utils.rb index 608d9f210cf..06be2b30be6 100644 --- a/scripts/cocoapods/codegen_utils.rb +++ b/scripts/cocoapods/codegen_utils.rb @@ -118,7 +118,7 @@ class CodegenUtils if hermes_enabled spec[:'dependencies'].merge!({ - 'hermes-engine': [version], + 'hermes-engine': [], # let React Native decide which version of Hermes Engine to be used. Otherwise, this can create conflicts. }); else spec[:'dependencies'].merge!({