From be9cf173165aa1e577e3408f9eeb1d25d12ab3be Mon Sep 17 00:00:00 2001 From: David Vacca Date: Sun, 27 Feb 2022 22:23:48 -0800 Subject: [PATCH] Move TextLayoutManager constructor to Cpp file Summary: Move TextLayoutManager constructor to Cpp file changelog: [internal] internal Reviewed By: genkikondo Differential Revision: D34246014 fbshipit-source-id: a85e144b05e2cefad8cb1757dad14bedacbb8d74 --- .../renderer/textlayoutmanager/TextLayoutManager.cpp | 10 ++++++++++ .../renderer/textlayoutmanager/TextLayoutManager.h | 9 +-------- 2 files changed, 11 insertions(+), 8 deletions(-) diff --git a/ReactCommon/react/renderer/textlayoutmanager/platform/android/react/renderer/textlayoutmanager/TextLayoutManager.cpp b/ReactCommon/react/renderer/textlayoutmanager/platform/android/react/renderer/textlayoutmanager/TextLayoutManager.cpp index 763e3c882c8..14d9a88e67e 100644 --- a/ReactCommon/react/renderer/textlayoutmanager/platform/android/react/renderer/textlayoutmanager/TextLayoutManager.cpp +++ b/ReactCommon/react/renderer/textlayoutmanager/platform/android/react/renderer/textlayoutmanager/TextLayoutManager.cpp @@ -20,6 +20,16 @@ using namespace facebook::jni; namespace facebook { namespace react { +TextLayoutManager::TextLayoutManager( + const ContextContainer::Shared &contextContainer) + : contextContainer_(contextContainer), + mapBufferSerializationEnabled_( + contextContainer->at("MapBufferSerializationEnabled")), + measureCache_( + contextContainer->at("EnableLargeTextMeasureCache") + ? 1024 + : kSimpleThreadSafeCacheSizeCap) {} + void *TextLayoutManager::getNativeTextLayoutManager() const { return self_; } diff --git a/ReactCommon/react/renderer/textlayoutmanager/platform/android/react/renderer/textlayoutmanager/TextLayoutManager.h b/ReactCommon/react/renderer/textlayoutmanager/platform/android/react/renderer/textlayoutmanager/TextLayoutManager.h index 0088e57e779..ad3483b3eb8 100644 --- a/ReactCommon/react/renderer/textlayoutmanager/platform/android/react/renderer/textlayoutmanager/TextLayoutManager.h +++ b/ReactCommon/react/renderer/textlayoutmanager/platform/android/react/renderer/textlayoutmanager/TextLayoutManager.h @@ -26,14 +26,7 @@ using SharedTextLayoutManager = std::shared_ptr; */ class TextLayoutManager { public: - TextLayoutManager(const ContextContainer::Shared &contextContainer) - : contextContainer_(contextContainer), - mapBufferSerializationEnabled_( - contextContainer->at("MapBufferSerializationEnabled")), - measureCache_( - contextContainer->at("EnableLargeTextMeasureCache") - ? 1024 - : kSimpleThreadSafeCacheSizeCap) {} + TextLayoutManager(const ContextContainer::Shared &contextContainer); /* * Not copyable.