From be91c269349e73a285492f9a97b0365a814605fb Mon Sep 17 00:00:00 2001 From: Gori Shanker Suthar Date: Sun, 4 Jan 2026 16:25:02 -0800 Subject: [PATCH] Fix copy-paste error in DevToolsRuntimeSettings (#55010) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Summary: Fixes a copy-paste error in `DevToolsRuntimeSettings::setReloadAndProfileConfig` where `recordChangeDescriptions` was guarded by the wrong optional field. The correct conditional check is already used in https://github.com/facebook/react-native/blob/main/packages/react-native/React/CoreModules/RCTDevToolsRuntimeSettingsModule.mm#L28 ## Changelog: [INTERNAL] [FIXED] Fix incorrect optional field check in DevToolsRuntimeSettings Pull Request resolved: https://github.com/facebook/react-native/pull/55010 Test Plan: Code inspection only – trivial copy-paste fix with no behavior change outside correctly applying `recordChangeDescriptions` when present. Reviewed By: mdvacca Differential Revision: D90011483 Pulled By: cortinico fbshipit-source-id: c00c3340625a11673a7e9011f1e373474d5a37e3 --- .../devtoolsruntimesettings/DevToolsRuntimeSettings.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/react-native/ReactCommon/devtoolsruntimesettings/DevToolsRuntimeSettings.cpp b/packages/react-native/ReactCommon/devtoolsruntimesettings/DevToolsRuntimeSettings.cpp index 02f4da23d92..524005b5bc2 100644 --- a/packages/react-native/ReactCommon/devtoolsruntimesettings/DevToolsRuntimeSettings.cpp +++ b/packages/react-native/ReactCommon/devtoolsruntimesettings/DevToolsRuntimeSettings.cpp @@ -14,7 +14,7 @@ void DevToolsRuntimeSettings::setReloadAndProfileConfig( if (config.shouldReloadAndProfile.has_value()) { _config.shouldReloadAndProfile = config.shouldReloadAndProfile.value(); } - if (config.shouldReloadAndProfile.has_value()) { + if (config.recordChangeDescriptions.has_value()) { _config.recordChangeDescriptions = config.recordChangeDescriptions.value(); } };