From be38ae1169053adf21b907dcffa53ae4ca73744f Mon Sep 17 00:00:00 2001 From: Anoop Chaurasiya Date: Mon, 23 May 2016 11:03:17 -0700 Subject: [PATCH] provide verbose error-message on bundle-load-failure Reviewed By: fkgozali Differential Revision: D3329107 fbshipit-source-id: 33c02ff066ec9ad415a5cc4639347ebdef67c604 --- React/Base/RCTJavaScriptLoader.m | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/React/Base/RCTJavaScriptLoader.m b/React/Base/RCTJavaScriptLoader.m index 71169816dd4..f677db64e23 100755 --- a/React/Base/RCTJavaScriptLoader.m +++ b/React/Base/RCTJavaScriptLoader.m @@ -25,12 +25,15 @@ RCT_NOT_IMPLEMENTED(- (instancetype)init) + (void)loadBundleAtURL:(NSURL *)scriptURL onComplete:(RCTSourceLoadBlock)onComplete { + NSString *unsanitizedScriptURLString = scriptURL.absoluteString; // Sanitize the script URL - scriptURL = [RCTConvert NSURL:scriptURL.absoluteString]; + scriptURL = [RCTConvert NSURL:unsanitizedScriptURLString]; if (!scriptURL) { + NSString *errorDescription = [NSString stringWithFormat:@"No script URL provided." + @"unsanitizedScriptURLString:(%@)", unsanitizedScriptURLString]; NSError *error = [NSError errorWithDomain:@"JavaScriptLoader" code:1 userInfo:@{ - NSLocalizedDescriptionKey: @"No script URL provided." + NSLocalizedDescriptionKey: errorDescription }]; onComplete(error, nil); return;