From bdb5804f32e1c8827ace106ced31cffa6bd29cc1 Mon Sep 17 00:00:00 2001 From: Iwo Plaza Date: Wed, 22 Jan 2025 07:41:04 -0800 Subject: [PATCH] Migrated `Core/ReactNativeVersion` to use `export` syntax. (#48853) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/48853 ## Motivation Modernising the react-native codebase to allow for ingestion by modern Flow tooling. ## This diff - Updates the `ReactNativeVersion` template to use `export` syntax. - Regenerates the `ReactNativeVersion.js` file with the new template. - Updates jest mock. - Updates the public API snapshot *(intented breaking change)* Changelog: [Internal] Reviewed By: robhogan Differential Revision: D68492723 fbshipit-source-id: daa55d3d553aca562cf2e091cd24546681a8db2f --- .../react-native/Libraries/Core/ReactNativeVersion.js | 4 +--- .../Core/__tests__/ReactNativeVersionCheck-test.js | 1 + .../__tests__/__snapshots__/public-api-test.js.snap | 3 +-- .../__snapshots__/set-rn-artifacts-version-test.js.snap | 8 ++------ .../releases/templates/ReactNativeVersion.js-template.js | 4 +--- 5 files changed, 6 insertions(+), 14 deletions(-) diff --git a/packages/react-native/Libraries/Core/ReactNativeVersion.js b/packages/react-native/Libraries/Core/ReactNativeVersion.js index 786a34fcdd1..9cd4e18ab47 100644 --- a/packages/react-native/Libraries/Core/ReactNativeVersion.js +++ b/packages/react-native/Libraries/Core/ReactNativeVersion.js @@ -8,7 +8,7 @@ * @generated by scripts/releases/set-version.js */ -const version: $ReadOnly<{ +export const version: $ReadOnly<{ major: number, minor: number, patch: number, @@ -19,5 +19,3 @@ const version: $ReadOnly<{ patch: 0, prerelease: null, }; - -module.exports = {version}; diff --git a/packages/react-native/Libraries/Core/__tests__/ReactNativeVersionCheck-test.js b/packages/react-native/Libraries/Core/__tests__/ReactNativeVersionCheck-test.js index bf281f9deba..38f805b0292 100644 --- a/packages/react-native/Libraries/Core/__tests__/ReactNativeVersionCheck-test.js +++ b/packages/react-native/Libraries/Core/__tests__/ReactNativeVersionCheck-test.js @@ -118,6 +118,7 @@ function _defineCheckVersionTests() { function _mockJsVersion(major = 0, minor = 0, patch = 0, prerelease = null) { jest.doMock('../ReactNativeVersion', () => ({ + __esModule: true, version: {major, minor, patch, prerelease}, })); } diff --git a/packages/react-native/Libraries/__tests__/__snapshots__/public-api-test.js.snap b/packages/react-native/Libraries/__tests__/__snapshots__/public-api-test.js.snap index f0d37029cc8..c57ba59db09 100644 --- a/packages/react-native/Libraries/__tests__/__snapshots__/public-api-test.js.snap +++ b/packages/react-native/Libraries/__tests__/__snapshots__/public-api-test.js.snap @@ -4434,13 +4434,12 @@ declare export default typeof ReactFiberErrorDialog; `; exports[`public API should not change unintentionally Libraries/Core/ReactNativeVersion.js 1`] = ` -"declare const version: $ReadOnly<{ +"declare export const version: $ReadOnly<{ major: number, minor: number, patch: number, prerelease: string | null, }>; -declare module.exports: { version: version }; " `; diff --git a/scripts/releases/__tests__/__snapshots__/set-rn-artifacts-version-test.js.snap b/scripts/releases/__tests__/__snapshots__/set-rn-artifacts-version-test.js.snap index d0c580171fb..407c8dc7f8c 100644 --- a/scripts/releases/__tests__/__snapshots__/set-rn-artifacts-version-test.js.snap +++ b/scripts/releases/__tests__/__snapshots__/set-rn-artifacts-version-test.js.snap @@ -11,7 +11,7 @@ exports[`updateReactNativeArtifacts should set nightly version: packages/react-n * << GENERATED >> */ -const version: $ReadOnly<{ +export const version: $ReadOnly<{ major: number, minor: number, patch: number, @@ -22,8 +22,6 @@ const version: $ReadOnly<{ patch: 0, prerelease: 'nightly-29282302-abcd1234', }; - -module.exports = {version}; " `; @@ -136,7 +134,7 @@ exports[`updateReactNativeArtifacts should set release version: packages/react-n * << GENERATED >> */ -const version: $ReadOnly<{ +export const version: $ReadOnly<{ major: number, minor: number, patch: number, @@ -147,8 +145,6 @@ const version: $ReadOnly<{ patch: 0, prerelease: null, }; - -module.exports = {version}; " `; diff --git a/scripts/releases/templates/ReactNativeVersion.js-template.js b/scripts/releases/templates/ReactNativeVersion.js-template.js index 42d0d0186d3..841ad65f282 100644 --- a/scripts/releases/templates/ReactNativeVersion.js-template.js +++ b/scripts/releases/templates/ReactNativeVersion.js-template.js @@ -23,7 +23,7 @@ module.exports = ({version} /*: {version: Version} */) /*: string */ => `/** * ${'@'}generated by scripts/releases/set-version.js */ -const version: $ReadOnly<{ +export const version: $ReadOnly<{ major: number, minor: number, patch: number, @@ -36,6 +36,4 @@ const version: $ReadOnly<{ version.prerelease != null ? `'${version.prerelease}'` : 'null' }, }; - -module.exports = {version}; `;