From bd7df8bdaacfe3d623e66d1624e057a6b728315a Mon Sep 17 00:00:00 2001 From: David Vacca Date: Sat, 23 Mar 2019 00:35:47 -0700 Subject: [PATCH] Remove BatchedExecutionTime from Fabric metrics Summary: This diff removes BatchedExecutionTime from the metrics that are measured in Fabric. This does not add much value and it is not easy to compare against current version of RN Reviewed By: shergin Differential Revision: D14541976 fbshipit-source-id: c488e0951815306a978dd7a4246ec8a16d663218 --- .../main/java/com/facebook/react/fabric/FabricUIManager.java | 4 ---- 1 file changed, 4 deletions(-) diff --git a/ReactAndroid/src/main/java/com/facebook/react/fabric/FabricUIManager.java b/ReactAndroid/src/main/java/com/facebook/react/fabric/FabricUIManager.java index 59cc67ce8d8..22b08f14fff 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/fabric/FabricUIManager.java +++ b/ReactAndroid/src/main/java/com/facebook/react/fabric/FabricUIManager.java @@ -114,7 +114,6 @@ public class FabricUIManager implements UIManager, LifecycleEventListener { private long mRunStartTime = 0l; private long mBatchedExecutionTime = 0l; - private long mNonBatchedExecutionTime = 0l; private long mDispatchViewUpdatesTime = 0l; private long mCommitStartTime = 0l; private long mLayoutTime = 0l; @@ -348,7 +347,6 @@ public class FabricUIManager implements UIManager, LifecycleEventListener { @UiThread private void dispatchPreMountItems(long frameTimeNanos) { - long nonBatchedExecutionStartTime = SystemClock.uptimeMillis(); Systrace.beginSection(Systrace.TRACE_TAG_REACT_JAVA_BRIDGE, "FabricUIManager::premountViews"); while (true) { @@ -367,7 +365,6 @@ public class FabricUIManager implements UIManager, LifecycleEventListener { preMountItemsToDispatch.execute(mMountingManager); } - mNonBatchedExecutionTime = SystemClock.uptimeMillis() - nonBatchedExecutionStartTime; Systrace.endSection(Systrace.TRACE_TAG_REACT_JAVA_BRIDGE); } @@ -447,7 +444,6 @@ public class FabricUIManager implements UIManager, LifecycleEventListener { performanceCounters.put("DispatchViewUpdatesTime", mDispatchViewUpdatesTime); performanceCounters.put("RunStartTime", mRunStartTime); performanceCounters.put("BatchedExecutionTime", mBatchedExecutionTime); - performanceCounters.put("NonBatchedExecutionTime", mNonBatchedExecutionTime); performanceCounters.put("FinishFabricTransactionTime", mFinishTransactionTime); performanceCounters.put("FinishFabricTransactionCPPTime", mFinishTransactionCPPTime); return performanceCounters;