From bd314168dd4978f45634b61529a085f274a0f77a Mon Sep 17 00:00:00 2001 From: Joshua Gross Date: Wed, 27 May 2020 13:34:43 -0700 Subject: [PATCH] Reset RootView ID when root view is detached from view hierarchy Summary: I have a theory that T53114059 can be caused by (1) other crashes, and/or (2) reloads. Clear out the ID of a RootView when it is detached. Changelog: [Internal] Reviewed By: mdvacca Differential Revision: D21732066 fbshipit-source-id: 5e607f34cf42ca26bdf199d5d3024fd49a60dc1e --- .../src/main/java/com/facebook/react/ReactInstanceManager.java | 3 +++ 1 file changed, 3 insertions(+) diff --git a/ReactAndroid/src/main/java/com/facebook/react/ReactInstanceManager.java b/ReactAndroid/src/main/java/com/facebook/react/ReactInstanceManager.java index 63ac2ec11df..acaf910025f 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/ReactInstanceManager.java +++ b/ReactAndroid/src/main/java/com/facebook/react/ReactInstanceManager.java @@ -840,6 +840,9 @@ public class ReactInstanceManager { detachViewFromInstance(reactRoot, currentContext.getCatalystInstance()); } } + + // Reset reactRoot content in case it's reused + clearReactRoot(reactRoot); } }