Remove use of TextLayoutManager::Shared and SharedTextLayoutManager

Summary:
changelog: [internal]

For some reason, using `TextLayoutManager::Shared` in `TextInputShadowNode` trips up clang tidy linter. We have a plan to move away from `*::Shared` anyway, so let's remove it from `TextInputShadowNode` now.

Why do we want to move away from `*::Shared`?
Using `TextLayoutManager::Shared` is confusing for people unfamiliar with Fabric's codebase. It expresses a concept of immutability but uses term `shared`. Term shared is already used in C++  `std::shared_ptr`.

Reviewed By: fkgozali

Differential Revision: D33186422

fbshipit-source-id: 10ee588735997f5fedc372a1d1e3d9cd9684178a
This commit is contained in:
Samuel Susla
2021-12-22 04:20:42 -08:00
committed by Facebook GitHub Bot
parent 3e8934b49b
commit bcc4ab35da
9 changed files with 46 additions and 16 deletions
@@ -8,5 +8,27 @@
#include "TextInputState.h"
namespace facebook {
namespace react {} // namespace react
namespace react {
#ifdef ANDROID
TextInputState::TextInputState(
TextInputState const &previousState,
folly::dynamic data){};
/*
* Empty implementation for Android because it doesn't use this class.
*/
folly::dynamic TextInputState::getDynamic() const {
return {};
};
/*
* Empty implementation for Android because it doesn't use this class.
*/
MapBuffer TextInputState::getMapBuffer() const {
return MapBufferBuilder::EMPTY();
};
#endif
} // namespace react
} // namespace facebook