Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove use of TextLayoutManager::Shared and SharedTextLayoutManager

Browse Source 
Summary:
changelog: [internal]

For some reason, using `TextLayoutManager::Shared` in `TextInputShadowNode` trips up clang tidy linter. We have a plan to move away from `*::Shared` anyway, so let's remove it from `TextInputShadowNode` now.

Why do we want to move away from `*::Shared`?
Using `TextLayoutManager::Shared` is confusing for people unfamiliar with Fabric's codebase. It expresses a concept of immutability but uses term `shared`. Term shared is already used in C++  `std::shared_ptr`.

Reviewed By: fkgozali

Differential Revision: D33186422

fbshipit-source-id: 10ee588735997f5fedc372a1d1e3d9cd9684178a
This commit is contained in:
Samuel Susla
2021-12-22 04:20:42 -08:00
committed by Facebook GitHub Bot
parent 3e8934b49b
commit bcc4ab35da
9 changed files with 46 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ReactCommon/react/renderer/components/textinput/iostextinput/TextInputShadowNode.cpp
+2 -2
View File
@@ -71,9 +71,9 @@ AttributedString TextInputShadowNode::getAttributedString(
}
void TextInputShadowNode::setTextLayoutManager(
TextLayoutManager::Shared const &textLayoutManager) {
std::shared_ptr<TextLayoutManager const> textLayoutManager) {
ensureUnsealed();
textLayoutManager_ = textLayoutManager;
textLayoutManager_ = std::move(textLayoutManager);
}
void TextInputShadowNode::updateStateIfNeeded(