From bc68794c674d4eb346e854861284458f0e13ec4c Mon Sep 17 00:00:00 2001 From: Arushi Kesarwani Date: Tue, 7 Nov 2023 12:38:20 -0800 Subject: [PATCH] Rename FabricJSIModuleProvider -> FabricUIManagerProviderImpl (#41296) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/41296 As part of adding new implementation for `FabricUIManagerProviderImpl` APIs renaming the old class `FabricJSIModuleProvider` -> `FabricUIManagerProviderImpl` so as to add the new APIs later and preserve history. Changelog: [Internal] internal Reviewed By: philIip Differential Revision: D50949208 fbshipit-source-id: b833c4783b383c175fa682c558d31d8ecfa9f0ac --- .../facebook/react/defaults/DefaultReactNativeHost.kt | 4 ++-- ...eProvider.java => FabricUIManagerProviderImpl.java} | 10 +++++----- 2 files changed, 7 insertions(+), 7 deletions(-) rename packages/react-native/ReactAndroid/src/main/java/com/facebook/react/fabric/{FabricJSIModuleProvider.java => FabricUIManagerProviderImpl.java} (87%) diff --git a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/defaults/DefaultReactNativeHost.kt b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/defaults/DefaultReactNativeHost.kt index 35d09cb6872..60c1e791912 100644 --- a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/defaults/DefaultReactNativeHost.kt +++ b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/defaults/DefaultReactNativeHost.kt @@ -21,7 +21,7 @@ import com.facebook.react.bridge.JSIModuleType import com.facebook.react.bridge.ReactApplicationContext import com.facebook.react.bridge.UIManager import com.facebook.react.fabric.ComponentFactory -import com.facebook.react.fabric.FabricJSIModuleProvider +import com.facebook.react.fabric.FabricUIManagerProviderImpl import com.facebook.react.fabric.ReactNativeConfig import com.facebook.react.uimanager.ViewManagerRegistry @@ -63,7 +63,7 @@ protected constructor( val viewManagers = reactInstanceManager.getOrCreateViewManagers(reactApplicationContext) val viewManagerRegistry = ViewManagerRegistry(viewManagers) - return FabricJSIModuleProvider( + return FabricUIManagerProviderImpl( reactApplicationContext, componentFactory, ReactNativeConfig.DEFAULT_CONFIG, diff --git a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/fabric/FabricJSIModuleProvider.java b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/fabric/FabricUIManagerProviderImpl.java similarity index 87% rename from packages/react-native/ReactAndroid/src/main/java/com/facebook/react/fabric/FabricJSIModuleProvider.java rename to packages/react-native/ReactAndroid/src/main/java/com/facebook/react/fabric/FabricUIManagerProviderImpl.java index 533b1368b92..bdda0146f5a 100644 --- a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/fabric/FabricJSIModuleProvider.java +++ b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/fabric/FabricUIManagerProviderImpl.java @@ -15,14 +15,14 @@ import com.facebook.react.fabric.events.EventBeatManager; import com.facebook.react.uimanager.ViewManagerRegistry; import com.facebook.systrace.Systrace; -public class FabricJSIModuleProvider implements JSIModuleProvider { +public class FabricUIManagerProviderImpl implements JSIModuleProvider { @NonNull private final ReactApplicationContext mReactApplicationContext; @NonNull private final ComponentFactory mComponentFactory; @NonNull private final ReactNativeConfig mConfig; @NonNull private final ViewManagerRegistry mViewManagerRegistry; - public FabricJSIModuleProvider( + public FabricUIManagerProviderImpl( @NonNull ReactApplicationContext reactApplicationContext, @NonNull ComponentFactory componentFactory, @NonNull ReactNativeConfig config, @@ -35,12 +35,12 @@ public class FabricJSIModuleProvider implements JSIModuleProvider { @Override public UIManager get() { - Systrace.beginSection(Systrace.TRACE_TAG_REACT_JAVA_BRIDGE, "FabricJSIModuleProvider.get"); + Systrace.beginSection(Systrace.TRACE_TAG_REACT_JAVA_BRIDGE, "FabricUIManagerProviderImpl.get"); final EventBeatManager eventBeatManager = new EventBeatManager(); final FabricUIManager uiManager = createUIManager(eventBeatManager); Systrace.beginSection( - Systrace.TRACE_TAG_REACT_JAVA_BRIDGE, "FabricJSIModuleProvider.registerBinding"); + Systrace.TRACE_TAG_REACT_JAVA_BRIDGE, "FabricUIManagerProviderImpl.registerBinding"); final Binding binding = new BindingImpl(); binding.register( @@ -59,7 +59,7 @@ public class FabricJSIModuleProvider implements JSIModuleProvider { private FabricUIManager createUIManager(@NonNull EventBeatManager eventBeatManager) { Systrace.beginSection( - Systrace.TRACE_TAG_REACT_JAVA_BRIDGE, "FabricJSIModuleProvider.createUIManager"); + Systrace.TRACE_TAG_REACT_JAVA_BRIDGE, "FabricUIManagerProviderImpl.createUIManager"); FabricUIManager fabricUIManager; fabricUIManager =