mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
Implement Performance.getEntries* W3C extension for Performance Timeline API (#36314)
Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/36314 ## Changelog: [Internal] - Added support for W3C Performance API extension (Performance,getEntries*) See [here for the details](https://www.w3.org/TR/performance-timeline/#extensions-to-the-performance-interface). This only supports `mark` and `measure` performance entry types (not `events`, as those are not supported by browsers either, they recommend using the `PerformanceObserver` API instead). From the implementation perspective, we already maintained persistent buffer for `mark` entry types, which was required in order to look up measures. The buffer is circular, limited to 1K entries by default. I basically mimic the same behavior for `measure` entry types as well, since it's the simplest way of doing it at this point, If we happen to want adding some other entry types that would be available via `Performance.getEntries*` API in the future, we may want to iterate on the internal data structures representation inside `PerformanceEntryReporter`, but for now I believe this approach should work just fine, and whatever changes we may want to do will be purely internal implementation detail. Reviewed By: rubennorte Differential Revision: D43625488 fbshipit-source-id: dd315b3f8488e910749a8e2a4158246e94d76f99
This commit is contained in:
committed by
Facebook GitHub Bot
parent
3997fc1c66
commit
bc56f66b8d
@@ -87,4 +87,14 @@ void NativePerformanceObserver::clearEntries(
|
||||
entryName ? entryName->c_str() : nullptr);
|
||||
}
|
||||
|
||||
std::vector<RawPerformanceEntry> NativePerformanceObserver::getEntries(
|
||||
jsi::Runtime &rt,
|
||||
std::optional<int32_t> entryType,
|
||||
std::optional<std::string> entryName) {
|
||||
return PerformanceEntryReporter::getInstance().getEntries(
|
||||
entryType ? static_cast<PerformanceEntryType>(*entryType)
|
||||
: PerformanceEntryType::UNDEFINED,
|
||||
entryName ? entryName->c_str() : nullptr);
|
||||
}
|
||||
|
||||
} // namespace facebook::react
|
||||
|
||||
Reference in New Issue
Block a user