From bc54a45542e7b2e537363a2e99a5ef537deac2ba Mon Sep 17 00:00:00 2001 From: Janic Duplessis Date: Tue, 29 Mar 2016 07:25:46 -0700 Subject: [PATCH] Revert strict mode in transform-es2015-modules-commonjs Summary:See discussion here https://github.com/facebook/react-native/pull/5796#issuecomment-202002658 **Test plan (required)** Change the babel-preset-react-native dependency to `"babel-preset-react-native": "file:./babel-preset",` so it uses the local babel-preset instead of the one from npm. ``` ./packager/packager.sh --reset-cache ``` open `http://localhost:8081/Examples/UIExplorer/UIExplorerApp.android.bundle?platform=android&dev=true&hot=false&minify=false` and there should not be any added 'strict mode'. Closes https://github.com/facebook/react-native/pull/6686 Reviewed By: mkonicek Differential Revision: D3103122 Pulled By: bestander fb-gh-sync-id: 85658ee01bb73f13dacb2b6a48ab121324c13118 fbshipit-source-id: 85658ee01bb73f13dacb2b6a48ab121324c13118 --- babel-preset/configs/main.js | 2 +- babel-preset/package.json | 2 +- package.json | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/babel-preset/configs/main.js b/babel-preset/configs/main.js index da6f64efdbf..3322812bd07 100644 --- a/babel-preset/configs/main.js +++ b/babel-preset/configs/main.js @@ -24,7 +24,7 @@ module.exports = { 'transform-es2015-computed-properties', 'transform-es2015-constants', 'transform-es2015-destructuring', - ['transform-es2015-modules-commonjs', { allowTopLevelThis: true }], + ['transform-es2015-modules-commonjs', { strict: false, allowTopLevelThis: true }], 'transform-es2015-parameters', 'transform-es2015-shorthand-properties', 'transform-es2015-spread', diff --git a/babel-preset/package.json b/babel-preset/package.json index 685e8180cfe..468d05e8b6b 100644 --- a/babel-preset/package.json +++ b/babel-preset/package.json @@ -1,6 +1,6 @@ { "name": "babel-preset-react-native", - "version": "1.5.3", + "version": "1.5.4", "description": "Babel preset for React Native applications", "main": "index.js", "repository": "https://github.com/facebook/react-native/tree/master/babel-preset", diff --git a/package.json b/package.json index eff2adc7792..107a52a03e8 100644 --- a/package.json +++ b/package.json @@ -133,7 +133,7 @@ "babel-core": "^6.6.4", "babel-plugin-external-helpers": "^6.5.0", "babel-polyfill": "^6.6.1", - "babel-preset-react-native": "^1.5.2", + "babel-preset-react-native": "1.5.2", "babel-register": "^6.6.0", "babel-types": "^6.6.4", "babylon": "^6.6.4",