diff --git a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/bridge/BaseJavaModule.java b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/bridge/BaseJavaModule.java index 10c60a3e16f..3b4606afdd9 100644 --- a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/bridge/BaseJavaModule.java +++ b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/bridge/BaseJavaModule.java @@ -56,17 +56,12 @@ public abstract class BaseJavaModule implements NativeModule { @Override public boolean canOverrideExistingModule() { - // TODO(t11394819): Make this final and use annotation return false; } @Override public void onCatalystInstanceDestroy() {} - public boolean hasConstants() { - return false; - } - /** * The CatalystInstance is going away with Venice. Therefore, the TurboModule infra introduces the * invalidate() method to allow NativeModules to clean up after themselves. diff --git a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/ViewManager.java b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/ViewManager.java index f50610f059d..1e16571963b 100644 --- a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/ViewManager.java +++ b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/ViewManager.java @@ -67,8 +67,9 @@ public abstract class ViewManager * For the vast majority of ViewManagers, you will not need to override this. Only override this * if you really know what you're doing and have a very unique use-case. * - * @param viewToUpdate - * @param props + * @param viewToUpdate {@link T} View instance that will be updated with the props received by + * parameter. + * @param props {@link ReactStylesDiffMap} props to update the view with */ public void updateProperties(@NonNull T viewToUpdate, ReactStylesDiffMap props) { final ViewManagerDelegate delegate = getDelegate();