From bbb4e4480dc6727729431b8dbbc9f0982c63e77c Mon Sep 17 00:00:00 2001 From: Dulmandakh Date: Fri, 22 Nov 2019 09:41:38 -0800 Subject: [PATCH] fix R8 warning (#27291) Summary: R8 shows warning that **com.facebook.react.bridge.JavaScriptModule**, **com.facebook.react.bridge.NativeModule** are interfaces so proguard rules must use implements instead of extends. This PR changes proguard rules to fix the warnings. ## Changelog [Android] [Changed] - Fix R8 warning Pull Request resolved: https://github.com/facebook/react-native/pull/27291 Test Plan: RNTester builds and runs as expected. Differential Revision: D18658704 Pulled By: mdvacca fbshipit-source-id: a679643542bc55b89141f58c3236a29cf83c20d2 --- ReactAndroid/proguard-rules.pro | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ReactAndroid/proguard-rules.pro b/ReactAndroid/proguard-rules.pro index 67e7aa1ccb9..874ad4f29f6 100644 --- a/ReactAndroid/proguard-rules.pro +++ b/ReactAndroid/proguard-rules.pro @@ -39,8 +39,8 @@ *** get*(); } --keep class * extends com.facebook.react.bridge.JavaScriptModule { *; } --keep class * extends com.facebook.react.bridge.NativeModule { *; } +-keep class * implements com.facebook.react.bridge.JavaScriptModule { *; } +-keep class * implements com.facebook.react.bridge.NativeModule { *; } -keepclassmembers,includedescriptorclasses class * { native ; } -keepclassmembers class * { @com.facebook.react.uimanager.annotations.ReactProp ; } -keepclassmembers class * { @com.facebook.react.uimanager.annotations.ReactPropGroup ; }