diff --git a/Libraries/LogBox/LogBox.js b/Libraries/LogBox/LogBox.js index 92f5133638a..913dfa8daa3 100644 --- a/Libraries/LogBox/LogBox.js +++ b/Libraries/LogBox/LogBox.js @@ -42,7 +42,7 @@ if (__DEV__) { }, ignoreAllLogs: (value?: ?boolean): void => { - LogBoxData.setDisabled(!!value); + LogBoxData.setDisabled(value == null ? true : value); }, uninstall: (): void => { diff --git a/Libraries/LogBox/__tests__/LogBox-test.js b/Libraries/LogBox/__tests__/LogBox-test.js index 974f1cca301..56857f8ba29 100644 --- a/Libraries/LogBox/__tests__/LogBox-test.js +++ b/Libraries/LogBox/__tests__/LogBox-test.js @@ -69,6 +69,30 @@ describe('LogBox', () => { expect(LogBoxData.isDisabled()).toBe(true); }); + it('will not ignore logs for `ignoreAllLogs(false)`', () => { + expect(LogBoxData.isDisabled()).toBe(false); + + LogBox.install(); + + expect(LogBoxData.isDisabled()).toBe(false); + + LogBox.ignoreAllLogs(false); + + expect(LogBoxData.isDisabled()).toBe(false); + }); + + it('will ignore logs for `ignoreAllLogs()`', () => { + expect(LogBoxData.isDisabled()).toBe(false); + + LogBox.install(); + + expect(LogBoxData.isDisabled()).toBe(false); + + LogBox.ignoreAllLogs(); + + expect(LogBoxData.isDisabled()).toBe(true); + }); + it('registers warnings', () => { jest.mock('../Data/LogBoxData');