Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Prop parsing: always require explicit default argument to convertRawProp

Browse Source 
Summary:
Having automatic defaults/an optional arg for `convertRawProp` has caused way more problems than it is worth. Remove the default argument.

Changelog: [Internal]

Reviewed By: shergin

Differential Revision: D19151594

fbshipit-source-id: 839ec8d138b2c3c083f221a2871582454004648c
This commit is contained in:
Joshua Gross
2019-12-18 15:02:09 -08:00
committed by Facebook Github Bot
parent 7980615d37
commit bb5622dd89
11 changed files with 220 additions and 96 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ReactCommon/fabric/components/textinput/androidtextinput/AndroidTextInputProps.cpp
+1 -1
View File
@@ -222,7 +222,7 @@ AndroidTextInputProps::AndroidTextInputProps(
{0})),
text(convertRawProp(rawProps, "text", sourceProps.text, {})),
paragraphAttributes(
convertRawProp(rawProps, sourceProps.paragraphAttributes)) {}
convertRawProp(rawProps, sourceProps.paragraphAttributes, {})) {}
// TODO T53300085: support this in codegen; this was hand-written
folly::dynamic AndroidTextInputProps::getDynamic() const {