From bb460468a4bff2b6cdab7f8d65d739654ed456d2 Mon Sep 17 00:00:00 2001 From: Pieter De Baets Date: Mon, 11 Jul 2022 08:50:57 -0700 Subject: [PATCH] Remove ReactTextViewManager subclasses Summary: Subclassing a ViewManager means an additional PropsSetter class is generated (and other overheads). Instead we can use a Factory/Provider to construct ReactTextViewManager, since we don't actually need a subclass. Changelog: [Internal] Reviewed By: rshest Differential Revision: D36411098 fbshipit-source-id: 11c5ba5c9683a3ae4741cf61338f1983c69d9b69 --- .../com/facebook/react/views/text/ReactTextViewManager.java | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/ReactAndroid/src/main/java/com/facebook/react/views/text/ReactTextViewManager.java b/ReactAndroid/src/main/java/com/facebook/react/views/text/ReactTextViewManager.java index de60d769c09..bdc9d249816 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/views/text/ReactTextViewManager.java +++ b/ReactAndroid/src/main/java/com/facebook/react/views/text/ReactTextViewManager.java @@ -48,8 +48,11 @@ public class ReactTextViewManager protected @Nullable ReactTextViewManagerCallback mReactTextViewManagerCallback; public ReactTextViewManager() { - super(); + this(null); + } + public ReactTextViewManager(@Nullable ReactTextViewManagerCallback reactTextViewManagerCallback) { + mReactTextViewManagerCallback = reactTextViewManagerCallback; setupViewRecycling(); }