mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
Demote electron to devDependency (#53438)
Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/53438 Changelog: [Internal] Makes `flavor: 'prebuilt'` the default mode of launching the RNDT standalone shell, and the *only* mode supported in the published version of the package. See D78351931 for more context. With this, we can demote `electron` from `dependencies` to `devDependencies`. This makes it possible to make `debugger-shell` a dependency of `dev-middleware` (and thus of all major frameworks) without significantly impacting `npm install` times. We'll add this dependency on `debugger-shell` in an upcoming diff (D78351937). We also stop publishing the `dist/electron` subdirectory (and `src/electron` for good measure) since the corresponding code will always be bundled into the prebuilt binary instead. Reviewed By: huntie Differential Revision: D78351934 fbshipit-source-id: 2a4b03e852c4d0330250567c41dca09d1c4f3abd
This commit is contained in:
committed by
Facebook GitHub Bot
parent
b5dfb32ed3
commit
ba24f5f903
@@ -29,7 +29,7 @@ async function unstable_spawnDebuggerShellWithArgs(
|
||||
args: string[],
|
||||
{
|
||||
mode = 'detached',
|
||||
flavor = 'dev',
|
||||
flavor = 'prebuilt',
|
||||
}: $ReadOnly<{
|
||||
// In 'syncAndExit' mode, the current process will block until the spawned process exits, and then it will exit
|
||||
// with the same exit code as the spawned process.
|
||||
|
||||
Reference in New Issue
Block a user