From b7e7e7ff1e74b45709def1f6753fb6421c57a448 Mon Sep 17 00:00:00 2001 From: Luna Wei Date: Mon, 29 Aug 2022 14:43:57 -0700 Subject: [PATCH] ReactSlider onValueChange Summary: Changelog: [Android][Fixed] - Emit the right bubbling event for ReactSliderEvent In [ReactSliderManager.java](https://github.com/facebook/react-native/blob/main/ReactAndroid/src/main/java/com/facebook/react/views/slider/ReactSliderManager.java#L277) we register `topValueChange` yet `ReactSliderEvent` dispatches `topChange`. Reviewed By: NickGerleman Differential Revision: D39064685 fbshipit-source-id: c1e589c2fcaee68ef21f920a950ea36eaa0e5048 --- .../java/com/facebook/react/views/slider/ReactSliderEvent.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ReactAndroid/src/main/java/com/facebook/react/views/slider/ReactSliderEvent.java b/ReactAndroid/src/main/java/com/facebook/react/views/slider/ReactSliderEvent.java index 2ac05779a12..8f97341d295 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/views/slider/ReactSliderEvent.java +++ b/ReactAndroid/src/main/java/com/facebook/react/views/slider/ReactSliderEvent.java @@ -15,7 +15,7 @@ import com.facebook.react.uimanager.events.RCTEventEmitter; /** Event emitted by a ReactSliderManager when user changes slider position. */ public class ReactSliderEvent extends Event { - public static final String EVENT_NAME = "topChange"; + public static final String EVENT_NAME = "topValueChange"; private final double mValue; private final boolean mFromUser;