Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

nullable annotations to ReadableMap, WritableMap, ReadableArray, Writable. (#23329)

Browse Source 
Summary:
Kotlin is getting traction and more developers write RN native modules in it. This PR adds nullable annotations to help with Kotlin null inference and improve developer experience. Also it'll help checking code quality using lint.

I skimmed through JavaOnlyMap.java, JavaOnlyArray.java, ReadableNativeArray.java, ReadableNativeMap.java, WritableNativeArray.java and WritableNativeMap.java to infer nullability.

This is breaking change to Kotlin code.

[Android] [Changed] - Add nullable annotations to ReadableMap, WritableMap, ReadableArray, Writable.
Pull Request resolved: https://github.com/facebook/react-native/pull/23329

Differential Revision: D14002571

Pulled By: cpojer

fbshipit-source-id: 899d8b3b0a5dad43e8300e6c4ea4208cca0f01a9
This commit is contained in:
Dulmandakh
2019-02-08 04:16:24 -08:00
committed by Facebook Github Bot
parent d002d30325
commit b640b6faf7
10 changed files with 114 additions and 88 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ReactAndroid/src/main/java/com/facebook/react/bridge/WritableMap.java
+10 -8
View File
@@ -7,18 +7,20 @@
package com.facebook.react.bridge;
import javax.annotation.Nonnull;
/**
* Interface for a mutable map. Used to pass arguments from Java to JS.
*/
public interface WritableMap extends ReadableMap {
void putNull(String key);
void putBoolean(String key, boolean value);
void putDouble(String key, double value);
void putInt(String key, int value);
void putString(String key, String value);
void putArray(String key, WritableArray value);
void putMap(String key, WritableMap value);
void putNull(@Nonnull String key);
void putBoolean(@Nonnull String key, boolean value);
void putDouble(@Nonnull String key, double value);
void putInt(@Nonnull String key, int value);
void putString(@Nonnull String key, @Nonnull String value);
void putArray(@Nonnull String key, @Nonnull WritableArray value);
void putMap(@Nonnull String key, @Nonnull WritableMap value);
void merge(ReadableMap source);
void merge(@Nonnull ReadableMap source);
}