Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

nullable annotations to ReadableMap, WritableMap, ReadableArray, Writable. (#23329)

Browse Source 
Summary:
Kotlin is getting traction and more developers write RN native modules in it. This PR adds nullable annotations to help with Kotlin null inference and improve developer experience. Also it'll help checking code quality using lint.

I skimmed through JavaOnlyMap.java, JavaOnlyArray.java, ReadableNativeArray.java, ReadableNativeMap.java, WritableNativeArray.java and WritableNativeMap.java to infer nullability.

This is breaking change to Kotlin code.

[Android] [Changed] - Add nullable annotations to ReadableMap, WritableMap, ReadableArray, Writable.
Pull Request resolved: https://github.com/facebook/react-native/pull/23329

Differential Revision: D14002571

Pulled By: cpojer

fbshipit-source-id: 899d8b3b0a5dad43e8300e6c4ea4208cca0f01a9
This commit is contained in:
Dulmandakh
2019-02-08 04:08:37 -08:00
committed by Facebook Github Bot
parent d002d30325
commit b640b6faf7
10 changed files with 114 additions and 88 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ReactAndroid/src/main/java/com/facebook/react/bridge/ReadableNativeArray.java
+8 -6
View File
@@ -13,6 +13,8 @@ import com.facebook.proguard.annotations.DoNotStrip;
import com.facebook.react.config.ReactFeatureFlags;
import java.util.ArrayList;
import java.util.Arrays;
import javax.annotation.Nonnull;
import javax.annotation.Nullable;
/**
@@ -125,7 +127,7 @@ public class ReadableNativeArray extends NativeArray implements ReadableArray {
private native int getIntNative(int index);
@Override
public String getString(int index) {
public @Nullable String getString(int index) {
if (ReactFeatureFlags.useArrayNativeAccessor) {
jniPassCounter++;
return getStringNative(index);
@@ -135,7 +137,7 @@ public class ReadableNativeArray extends NativeArray implements ReadableArray {
private native String getStringNative(int index);
@Override
public ReadableNativeArray getArray(int index) {
public @Nullable ReadableNativeArray getArray(int index) {
if (ReactFeatureFlags.useArrayNativeAccessor) {
jniPassCounter++;
return getArrayNative(index);
@@ -145,7 +147,7 @@ public class ReadableNativeArray extends NativeArray implements ReadableArray {
private native ReadableNativeArray getArrayNative(int index);
@Override
public ReadableNativeMap getMap(int index) {
public @Nullable ReadableNativeMap getMap(int index) {
if (ReactFeatureFlags.useArrayNativeAccessor) {
jniPassCounter++;
return getMapNative(index);
@@ -155,7 +157,7 @@ public class ReadableNativeArray extends NativeArray implements ReadableArray {
private native ReadableNativeMap getMapNative(int index);
@Override
public ReadableType getType(int index) {
public @Nonnull ReadableType getType(int index) {
if (ReactFeatureFlags.useArrayNativeAccessor) {
jniPassCounter++;
return getTypeNative(index);
@@ -166,12 +168,12 @@ public class ReadableNativeArray extends NativeArray implements ReadableArray {
private native ReadableType getTypeNative(int index);
@Override
public Dynamic getDynamic(int index) {
public @Nonnull Dynamic getDynamic(int index) {
return DynamicFromArray.create(this, index);
}
@Override
public ArrayList<Object> toArrayList() {
public @Nonnull ArrayList<Object> toArrayList() {
ArrayList<Object> arrayList = new ArrayList<>();
for (int i = 0; i < this.size(); i++) {