From b60e229d7f57f9ba79d984b85925f979290d31bf Mon Sep 17 00:00:00 2001 From: Joshua Gross Date: Thu, 14 Oct 2021 15:32:47 -0700 Subject: [PATCH] Remove compiler_flags from BUCK modules Summary: Nearly all of these are identical and these compiler_flags are now centralized in rn_defs.bzl. This should have NO CHANGE on build configuration, the flags have just moved for now. Changelog: [Internal] Reviewed By: mdvacca Differential Revision: D31631766 fbshipit-source-id: be40ebeb70ae52b7ded07ca08c4a29f10a0ed925 --- .../com/facebook/hermes/instrumentation/BUCK | 3 ++- .../facebook/react/common/mapbuffer/jni/BUCK | 6 ------ .../java/com/facebook/react/fabric/jni/BUCK | 6 ------ .../java/com/facebook/react/jscexecutor/BUCK | 3 ++- .../com/facebook/react/modules/blob/jni/BUCK | 6 ------ .../facebook/react/reactperflogger/jni/BUCK | 6 ------ .../facebook/react/turbomodule/core/jni/BUCK | 12 ------------ .../java/com/facebook/react/uimanager/jni/BUCK | 6 ------ ReactAndroid/src/main/jni/react/jni/BUCK | 5 ----- ReactAndroid/src/main/jni/react/perftests/BUCK | 4 ---- ReactCommon/better/BUCK | 6 ------ ReactCommon/callinvoker/BUCK | 6 ------ ReactCommon/cxxreact/BUCK | 17 +---------------- ReactCommon/jsi/BUCK | 9 --------- ReactCommon/jsinspector/BUCK | 5 ----- ReactCommon/logger/BUCK | 5 ----- ReactCommon/react/config/BUCK | 6 ------ ReactCommon/react/debug/BUCK | 6 ------ ReactCommon/react/nativemodule/core/BUCK | 5 ----- ReactCommon/react/nativemodule/samples/BUCK | 7 ------- ReactCommon/react/renderer/animations/BUCK | 4 ---- .../react/renderer/attributedstring/BUCK | 6 ------ .../react/renderer/componentregistry/BUCK | 6 ------ .../renderer/componentregistry/native/BUCK | 6 ------ .../react/renderer/components/image/BUCK | 6 ------ .../renderer/components/inputaccessory/BUCK | 6 ------ .../components/legacyviewmanagerinterop/BUCK | 6 ------ .../react/renderer/components/modal/BUCK | 6 ------ .../react/renderer/components/progressbar/BUCK | 6 ------ .../react/renderer/components/root/BUCK | 6 ------ .../renderer/components/safeareaview/BUCK | 6 ------ .../react/renderer/components/scrollview/BUCK | 6 ------ .../react/renderer/components/slider/BUCK | 6 ------ .../react/renderer/components/switch/BUCK | 6 ------ .../react/renderer/components/text/BUCK | 6 ------ .../react/renderer/components/textinput/BUCK | 6 ------ .../androidtextinput/AndroidTextInputProps.h | 2 ++ .../components/textinput/iostextinput/BUCK | 6 ------ .../renderer/components/unimplementedview/BUCK | 6 ------ .../react/renderer/components/view/BUCK | 6 ------ ReactCommon/react/renderer/core/BUCK | 6 ------ ReactCommon/react/renderer/debug/BUCK | 6 ------ ReactCommon/react/renderer/element/BUCK | 6 ------ ReactCommon/react/renderer/graphics/BUCK | 6 ------ ReactCommon/react/renderer/imagemanager/BUCK | 6 ------ ReactCommon/react/renderer/leakchecker/BUCK | 6 ------ ReactCommon/react/renderer/mapbuffer/BUCK | 6 ------ ReactCommon/react/renderer/mounting/BUCK | 6 ------ .../react/renderer/runtimescheduler/BUCK | 6 ------ ReactCommon/react/renderer/scheduler/BUCK | 6 ------ ReactCommon/react/renderer/telemetry/BUCK | 6 ------ .../react/renderer/templateprocessor/BUCK | 6 ------ .../react/renderer/textlayoutmanager/BUCK | 6 ------ ReactCommon/react/renderer/timeline/BUCK | 6 ------ ReactCommon/react/renderer/uimanager/BUCK | 6 ------ ReactCommon/react/test_utils/BUCK | 6 ------ ReactCommon/react/utils/BUCK | 6 ------ ReactCommon/reactperflogger/BUCK | 4 ---- ReactCommon/runtimeexecutor/BUCK | 6 ------ ReactCommon/yoga/BUCK | 6 +----- packages/react-native-codegen/BUCK | 12 ------------ packages/react-native-codegen/DEFS.bzl | 18 ------------------ 62 files changed, 8 insertions(+), 383 deletions(-) diff --git a/ReactAndroid/src/main/java/com/facebook/hermes/instrumentation/BUCK b/ReactAndroid/src/main/java/com/facebook/hermes/instrumentation/BUCK index c78901a85f6..ead8aae637e 100644 --- a/ReactAndroid/src/main/java/com/facebook/hermes/instrumentation/BUCK +++ b/ReactAndroid/src/main/java/com/facebook/hermes/instrumentation/BUCK @@ -31,7 +31,8 @@ rn_xplat_cxx_library( ], headers = ["HermesSamplingProfiler.h"], header_namespace = "", - compiler_flags = ["-fexceptions"], + compiler_flags_enable_exceptions = True, # TODO: is this necessary? + compiler_flags_enable_rtti = True, # TODO: is this necessary? labels = ["supermodule:xplat/default/public.react_native.infra"], platforms = ANDROID, soname = "libjsijniprofiler.$(ext)", diff --git a/ReactAndroid/src/main/java/com/facebook/react/common/mapbuffer/jni/BUCK b/ReactAndroid/src/main/java/com/facebook/react/common/mapbuffer/jni/BUCK index 0e5d2d726d9..c2ac7a7ffbc 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/common/mapbuffer/jni/BUCK +++ b/ReactAndroid/src/main/java/com/facebook/react/common/mapbuffer/jni/BUCK @@ -11,12 +11,6 @@ rn_xplat_cxx_library( ], prefix = "react/common/mapbuffer", ), - compiler_flags = [ - "-fexceptions", - "-frtti", - "-std=c++17", - "-Wall", - ], fbandroid_allow_jni_merging = True, labels = ["supermodule:xplat/default/public.react_native.infra"], platforms = ANDROID, diff --git a/ReactAndroid/src/main/java/com/facebook/react/fabric/jni/BUCK b/ReactAndroid/src/main/java/com/facebook/react/fabric/jni/BUCK index a534958295f..c4297f303ae 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/fabric/jni/BUCK +++ b/ReactAndroid/src/main/java/com/facebook/react/fabric/jni/BUCK @@ -11,12 +11,6 @@ rn_xplat_cxx_library( ], prefix = "react/fabric", ), - compiler_flags = [ - "-fexceptions", - "-frtti", - "-std=c++17", - "-Wall", - ], fbandroid_allow_jni_merging = True, labels = ["supermodule:xplat/default/public.react_native.infra"], platforms = ANDROID, diff --git a/ReactAndroid/src/main/java/com/facebook/react/jscexecutor/BUCK b/ReactAndroid/src/main/java/com/facebook/react/jscexecutor/BUCK index d601632a0f3..54036fce0cf 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/jscexecutor/BUCK +++ b/ReactAndroid/src/main/java/com/facebook/react/jscexecutor/BUCK @@ -20,7 +20,8 @@ rn_xplat_cxx_library( srcs = glob(["*.cpp"]), headers = glob(["*.h"]), header_namespace = "", - compiler_flags = ["-fexceptions"], + compiler_flags_enable_exceptions = True, # TODO: is this necessary? + compiler_flags_enable_rtti = True, # TODO: is this necessary? fbandroid_allow_jni_merging = True, platforms = ANDROID, soname = "libjscexecutor.$(ext)", diff --git a/ReactAndroid/src/main/java/com/facebook/react/modules/blob/jni/BUCK b/ReactAndroid/src/main/java/com/facebook/react/modules/blob/jni/BUCK index a6e6c32e364..e706c5bba91 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/modules/blob/jni/BUCK +++ b/ReactAndroid/src/main/java/com/facebook/react/modules/blob/jni/BUCK @@ -5,12 +5,6 @@ rn_xplat_cxx_library( srcs = glob(["*.cpp"]), headers = glob(["*.h"]), header_namespace = "", - compiler_flags = [ - "-fexceptions", - "-frtti", - "-std=c++17", - "-Wall", - ], labels = ["supermodule:xplat/default/public.react_native.infra"], platforms = ANDROID, soname = "libreactnativeblob.$(ext)", diff --git a/ReactAndroid/src/main/java/com/facebook/react/reactperflogger/jni/BUCK b/ReactAndroid/src/main/java/com/facebook/react/reactperflogger/jni/BUCK index cd3246bef1f..956b28f2a66 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/reactperflogger/jni/BUCK +++ b/ReactAndroid/src/main/java/com/facebook/react/reactperflogger/jni/BUCK @@ -9,12 +9,6 @@ rn_xplat_cxx_library( exported_headers = { "reactperflogger/JNativeModulePerfLogger.h": "reactperflogger/JNativeModulePerfLogger.h", }, - compiler_flags = [ - "-fexceptions", - "-frtti", - "-std=c++17", - "-Wall", - ], fbandroid_allow_jni_merging = True, fbandroid_labels = [ "supermodule:xplat/default/public.react_native.infra", diff --git a/ReactAndroid/src/main/java/com/facebook/react/turbomodule/core/jni/BUCK b/ReactAndroid/src/main/java/com/facebook/react/turbomodule/core/jni/BUCK index 96ade8eaea0..4291e2ae40f 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/turbomodule/core/jni/BUCK +++ b/ReactAndroid/src/main/java/com/facebook/react/turbomodule/core/jni/BUCK @@ -11,12 +11,6 @@ rn_xplat_cxx_library( "ReactCommon/TurboModuleManager.h": "ReactCommon/TurboModuleManager.h", "ReactCommon/TurboModuleManagerDelegate.h": "ReactCommon/TurboModuleManagerDelegate.h", }, - compiler_flags = [ - "-fexceptions", - "-frtti", - "-std=c++17", - "-Wall", - ], labels = ["supermodule:xplat/default/public.react_native.infra"], platforms = ANDROID, preprocessor_flags = [ @@ -49,12 +43,6 @@ rn_xplat_cxx_library( exported_headers = { "ReactCommon/CallInvokerHolder.h": "ReactCommon/CallInvokerHolder.h", }, - compiler_flags = [ - "-fexceptions", - "-frtti", - "-std=c++17", - "-Wall", - ], fbandroid_deps = [ FBJNI_TARGET, ], diff --git a/ReactAndroid/src/main/java/com/facebook/react/uimanager/jni/BUCK b/ReactAndroid/src/main/java/com/facebook/react/uimanager/jni/BUCK index de237564290..5ded7919230 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/uimanager/jni/BUCK +++ b/ReactAndroid/src/main/java/com/facebook/react/uimanager/jni/BUCK @@ -11,12 +11,6 @@ rn_xplat_cxx_library( ], prefix = "react/uimanager/jni", ), - compiler_flags = [ - "-fexceptions", - "-frtti", - "-std=c++17", - "-Wall", - ], fbandroid_allow_jni_merging = True, labels = ["supermodule:xplat/default/public.react_native.infra"], platforms = ANDROID, diff --git a/ReactAndroid/src/main/jni/react/jni/BUCK b/ReactAndroid/src/main/jni/react/jni/BUCK index 99160d55a3c..39514497ecd 100644 --- a/ReactAndroid/src/main/jni/react/jni/BUCK +++ b/ReactAndroid/src/main/jni/react/jni/BUCK @@ -35,11 +35,6 @@ rn_xplat_cxx_library( header_namespace = "react/jni", exported_headers = EXPORTED_HEADERS, compiler_flags = [ - "-Wall", - "-Werror", - "-fexceptions", - "-std=c++1y", - "-frtti", "-Wno-pessimizing-move", "-Wno-inconsistent-missing-override", ], diff --git a/ReactAndroid/src/main/jni/react/perftests/BUCK b/ReactAndroid/src/main/jni/react/perftests/BUCK index fbff1d65250..3675a6157b2 100644 --- a/ReactAndroid/src/main/jni/react/perftests/BUCK +++ b/ReactAndroid/src/main/jni/react/perftests/BUCK @@ -3,10 +3,6 @@ load("//tools/build_defs/oss:rn_defs.bzl", "ANDROID", "react_native_xplat_target rn_xplat_cxx_library( name = "perftests", srcs = ["OnLoad.cpp"], - compiler_flags = [ - "-fexceptions", - "-std=c++1y", - ], platforms = ANDROID, soname = "libnativereactperftests.$(ext)", visibility = [ diff --git a/ReactCommon/better/BUCK b/ReactCommon/better/BUCK index 1bff7fd8579..c287ec79652 100644 --- a/ReactCommon/better/BUCK +++ b/ReactCommon/better/BUCK @@ -29,12 +29,6 @@ rn_xplat_cxx_library( ], prefix = "better", ), - compiler_flags = [ - "-fexceptions", - "-frtti", - "-std=c++17", - "-Wall", - ], fbobjc_compiler_flags = APPLE_COMPILER_FLAGS, fbobjc_preprocessor_flags = get_preprocessor_flags_for_build_mode() + get_apple_inspector_flags(), force_static = True, diff --git a/ReactCommon/callinvoker/BUCK b/ReactCommon/callinvoker/BUCK index b86dfb7c9a8..d6ff5cdb39a 100644 --- a/ReactCommon/callinvoker/BUCK +++ b/ReactCommon/callinvoker/BUCK @@ -10,12 +10,6 @@ rn_xplat_cxx_library( ], prefix = "ReactCommon", ), - compiler_flags = [ - "-fexceptions", - "-frtti", - "-std=c++17", - "-Wall", - ], labels = ["supermodule:xplat/default/public.react_native.infra"], platforms = (ANDROID, APPLE, CXX), preferred_linkage = "static", diff --git a/ReactCommon/cxxreact/BUCK b/ReactCommon/cxxreact/BUCK index 095e3d98b2c..a662a78414b 100644 --- a/ReactCommon/cxxreact/BUCK +++ b/ReactCommon/cxxreact/BUCK @@ -1,11 +1,6 @@ load("@fbsource//tools/build_defs:glob_defs.bzl", "subdir_glob") load("//tools/build_defs/oss:rn_defs.bzl", "ANDROID", "APPLE", "get_android_inspector_flags", "get_apple_compiler_flags", "get_apple_inspector_flags", "get_preprocessor_flags_for_build_mode", "react_native_xplat_target", "rn_xplat_cxx_library") -CXX_LIBRARY_COMPILER_FLAGS = [ - "-std=c++17", - "-Wall", -] - rn_xplat_cxx_library( name = "module", header_namespace = "", @@ -17,7 +12,6 @@ rn_xplat_cxx_library( ], prefix = "cxxreact", ), - compiler_flags = CXX_LIBRARY_COMPILER_FLAGS, fbobjc_compiler_flags = get_apple_compiler_flags(), force_static = True, labels = ["supermodule:xplat/default/public.react_native.infra"], @@ -39,10 +33,6 @@ rn_xplat_cxx_library( [("", "JSBigString.h")], prefix = "cxxreact", ), - compiler_flags = CXX_LIBRARY_COMPILER_FLAGS + [ - "-fexceptions", - "-frtti", - ], fbobjc_compiler_flags = get_apple_compiler_flags(), force_static = True, labels = ["supermodule:xplat/default/public.react_native.infra"], @@ -61,9 +51,8 @@ rn_xplat_cxx_library( srcs = ["SampleCxxModule.cpp"], header_namespace = "", exported_headers = ["SampleCxxModule.h"], - compiler_flags = CXX_LIBRARY_COMPILER_FLAGS + [ + compiler_flags = [ "-fno-omit-frame-pointer", - "-fexceptions", ], fbobjc_compiler_flags = get_apple_compiler_flags(), labels = ["supermodule:xplat/default/public.react_native.infra"], @@ -120,10 +109,6 @@ rn_xplat_cxx_library( ) for header in CXXREACT_PUBLIC_HEADERS ]), - compiler_flags = CXX_LIBRARY_COMPILER_FLAGS + [ - "-fexceptions", - "-frtti", - ], fbandroid_preprocessor_flags = get_android_inspector_flags(), fbobjc_compiler_flags = get_apple_compiler_flags(), fbobjc_force_static = True, diff --git a/ReactCommon/jsi/BUCK b/ReactCommon/jsi/BUCK index 1fc3de0f7d8..a3bfde64b98 100644 --- a/ReactCommon/jsi/BUCK +++ b/ReactCommon/jsi/BUCK @@ -14,11 +14,6 @@ rn_xplat_cxx_library( ], compiler_flags = [ "-O3", - "-fexceptions", - "-frtti", - "-std=c++17", - "-Wall", - "-Werror", "-Wextra", "-Wcast-qual", "-Wdelete-non-virtual-dtor", @@ -45,10 +40,6 @@ rn_xplat_cxx_library( exported_headers = [ "jsi/JSIDynamic.h", ], - compiler_flags = [ - "-fexceptions", - "-frtti", - ], fbobjc_force_static = True, labels = ["supermodule:xplat/default/public.react_native.infra"], visibility = [ diff --git a/ReactCommon/jsinspector/BUCK b/ReactCommon/jsinspector/BUCK index 1a7502a5fd6..c298131a299 100644 --- a/ReactCommon/jsinspector/BUCK +++ b/ReactCommon/jsinspector/BUCK @@ -26,11 +26,6 @@ rn_xplat_cxx_library( ], prefix = "jsinspector", ), - compiler_flags = [ - "-Wall", - "-fexceptions", - "-std=c++1y", - ], fbandroid_preferred_linkage = "shared", labels = ["supermodule:xplat/default/public.react_native.infra"], platforms = (ANDROID, APPLE, CXX, FBCODE, WINDOWS), diff --git a/ReactCommon/logger/BUCK b/ReactCommon/logger/BUCK index c40d9fbe170..59976e3cb06 100644 --- a/ReactCommon/logger/BUCK +++ b/ReactCommon/logger/BUCK @@ -26,11 +26,6 @@ rn_xplat_cxx_library( ], prefix = "logger", ), - compiler_flags = [ - "-Wall", - "-fexceptions", - "-std=c++17", - ], fbandroid_preferred_linkage = "shared", labels = ["supermodule:xplat/default/public.react_native.infra"], platforms = (ANDROID, APPLE, CXX, FBCODE, WINDOWS), diff --git a/ReactCommon/react/config/BUCK b/ReactCommon/react/config/BUCK index 2cadc9a2979..3fec8b7c1d5 100644 --- a/ReactCommon/react/config/BUCK +++ b/ReactCommon/react/config/BUCK @@ -18,12 +18,6 @@ rn_xplat_cxx_library( ], prefix = "react/config", ), - compiler_flags = [ - "-fexceptions", - "-frtti", - "-std=c++17", - "-Wall", - ], fbobjc_compiler_flags = APPLE_COMPILER_FLAGS, fbobjc_preprocessor_flags = get_preprocessor_flags_for_build_mode() + get_apple_inspector_flags(), force_static = True, diff --git a/ReactCommon/react/debug/BUCK b/ReactCommon/react/debug/BUCK index 55c5584d266..603c6146e52 100644 --- a/ReactCommon/react/debug/BUCK +++ b/ReactCommon/react/debug/BUCK @@ -29,12 +29,6 @@ rn_xplat_cxx_library( ], prefix = "react/debug", ), - compiler_flags = [ - "-fexceptions", - "-frtti", - "-std=c++17", - "-Wall", - ], exported_platform_linker_flags = [ ( "^android.*", diff --git a/ReactCommon/react/nativemodule/core/BUCK b/ReactCommon/react/nativemodule/core/BUCK index 93321356d65..b0e29b37c24 100644 --- a/ReactCommon/react/nativemodule/core/BUCK +++ b/ReactCommon/react/nativemodule/core/BUCK @@ -13,10 +13,6 @@ rn_xplat_cxx_library( prefix = "ReactCommon", ), compiler_flags = [ - "-fexceptions", - "-frtti", - "-std=c++17", - "-Wall", "-Wno-global-constructors", ], fbandroid_deps = [ @@ -35,7 +31,6 @@ rn_xplat_cxx_library( ], ), fbobjc_compiler_flags = [ - "-Wall", "-fobjc-arc-exceptions", ], fbobjc_inherited_buck_flags = get_static_library_ios_flags(), diff --git a/ReactCommon/react/nativemodule/samples/BUCK b/ReactCommon/react/nativemodule/samples/BUCK index 693bf74aaf4..d3ef2a8d956 100644 --- a/ReactCommon/react/nativemodule/samples/BUCK +++ b/ReactCommon/react/nativemodule/samples/BUCK @@ -12,12 +12,6 @@ rn_xplat_cxx_library( ], prefix = "ReactCommon", ), - compiler_flags = [ - "-fexceptions", - "-frtti", - "-std=c++17", - "-Wall", - ], fbandroid_deps = [ react_native_target("jni/react/jni:jni"), FBJNI_TARGET, @@ -34,7 +28,6 @@ rn_xplat_cxx_library( ], ), fbobjc_compiler_flags = [ - "-Wall", "-fobjc-arc-exceptions", ], fbobjc_inherited_buck_flags = get_static_library_ios_flags(), diff --git a/ReactCommon/react/renderer/animations/BUCK b/ReactCommon/react/renderer/animations/BUCK index 1998f8d9717..72a29efdfc0 100644 --- a/ReactCommon/react/renderer/animations/BUCK +++ b/ReactCommon/react/renderer/animations/BUCK @@ -32,10 +32,6 @@ rn_xplat_cxx_library( prefix = "react/renderer/animations", ), compiler_flags = [ - "-fexceptions", - "-frtti", - "-std=c++17", - "-Wall", "-lm", ], fbobjc_compiler_flags = APPLE_COMPILER_FLAGS, diff --git a/ReactCommon/react/renderer/attributedstring/BUCK b/ReactCommon/react/renderer/attributedstring/BUCK index c6d8371a414..4c79645fcf3 100644 --- a/ReactCommon/react/renderer/attributedstring/BUCK +++ b/ReactCommon/react/renderer/attributedstring/BUCK @@ -31,12 +31,6 @@ rn_xplat_cxx_library( ], prefix = "react/renderer/attributedstring", ), - compiler_flags = [ - "-fexceptions", - "-frtti", - "-std=c++17", - "-Wall", - ], fbandroid_deps = [ react_native_xplat_target("react/renderer/mapbuffer:mapbuffer"), ], diff --git a/ReactCommon/react/renderer/componentregistry/BUCK b/ReactCommon/react/renderer/componentregistry/BUCK index a9f8d697179..4ffce4a8be3 100644 --- a/ReactCommon/react/renderer/componentregistry/BUCK +++ b/ReactCommon/react/renderer/componentregistry/BUCK @@ -30,12 +30,6 @@ rn_xplat_cxx_library( ], prefix = "react/renderer/componentregistry", ), - compiler_flags = [ - "-fexceptions", - "-frtti", - "-std=c++17", - "-Wall", - ], fbobjc_compiler_flags = APPLE_COMPILER_FLAGS, fbobjc_preprocessor_flags = get_preprocessor_flags_for_build_mode() + get_apple_inspector_flags(), force_static = True, diff --git a/ReactCommon/react/renderer/componentregistry/native/BUCK b/ReactCommon/react/renderer/componentregistry/native/BUCK index c60fb13920a..a6aceadb768 100644 --- a/ReactCommon/react/renderer/componentregistry/native/BUCK +++ b/ReactCommon/react/renderer/componentregistry/native/BUCK @@ -29,12 +29,6 @@ rn_xplat_cxx_library( ], prefix = "react/renderer/componentregistry/native", ), - compiler_flags = [ - "-fexceptions", - "-frtti", - "-std=c++17", - "-Wall", - ], fbobjc_compiler_flags = APPLE_COMPILER_FLAGS, fbobjc_preprocessor_flags = get_preprocessor_flags_for_build_mode() + get_apple_inspector_flags(), force_static = True, diff --git a/ReactCommon/react/renderer/components/image/BUCK b/ReactCommon/react/renderer/components/image/BUCK index 44fbbfe147c..36ad159d49e 100644 --- a/ReactCommon/react/renderer/components/image/BUCK +++ b/ReactCommon/react/renderer/components/image/BUCK @@ -29,12 +29,6 @@ rn_xplat_cxx_library( ], prefix = "react/renderer/components/image", ), - compiler_flags = [ - "-fexceptions", - "-frtti", - "-std=c++17", - "-Wall", - ], fbandroid_deps = [ react_native_xplat_target("react/renderer/mapbuffer:mapbuffer"), ], diff --git a/ReactCommon/react/renderer/components/inputaccessory/BUCK b/ReactCommon/react/renderer/components/inputaccessory/BUCK index 3cddfd26afe..f50bb4337bf 100644 --- a/ReactCommon/react/renderer/components/inputaccessory/BUCK +++ b/ReactCommon/react/renderer/components/inputaccessory/BUCK @@ -24,12 +24,6 @@ rn_xplat_cxx_library( ], prefix = "react/renderer/components/inputaccessory", ), - compiler_flags = [ - "-fexceptions", - "-frtti", - "-std=c++17", - "-Wall", - ], fbobjc_compiler_flags = APPLE_COMPILER_FLAGS, fbobjc_preprocessor_flags = get_preprocessor_flags_for_build_mode() + get_apple_inspector_flags(), force_static = True, diff --git a/ReactCommon/react/renderer/components/legacyviewmanagerinterop/BUCK b/ReactCommon/react/renderer/components/legacyviewmanagerinterop/BUCK index 93ee20de397..6a5f2da93f5 100644 --- a/ReactCommon/react/renderer/components/legacyviewmanagerinterop/BUCK +++ b/ReactCommon/react/renderer/components/legacyviewmanagerinterop/BUCK @@ -27,12 +27,6 @@ rn_xplat_cxx_library( ], prefix = "react/renderer/components/legacyviewmanagerinterop", ), - compiler_flags = [ - "-fexceptions", - "-frtti", - "-std=c++17", - "-Wall", - ], fbobjc_compiler_flags = APPLE_COMPILER_FLAGS, fbobjc_preprocessor_flags = get_preprocessor_flags_for_build_mode() + get_apple_inspector_flags(), force_static = True, diff --git a/ReactCommon/react/renderer/components/modal/BUCK b/ReactCommon/react/renderer/components/modal/BUCK index 1b7d859bc13..10c9e229be2 100644 --- a/ReactCommon/react/renderer/components/modal/BUCK +++ b/ReactCommon/react/renderer/components/modal/BUCK @@ -31,12 +31,6 @@ rn_xplat_cxx_library( ], prefix = "react/renderer/components/modal", ), - compiler_flags = [ - "-fexceptions", - "-frtti", - "-std=c++17", - "-Wall", - ], fbandroid_deps = [ react_native_xplat_target("react/renderer/mapbuffer:mapbuffer"), ], diff --git a/ReactCommon/react/renderer/components/progressbar/BUCK b/ReactCommon/react/renderer/components/progressbar/BUCK index f9c4c3ea337..b45bde96a1a 100644 --- a/ReactCommon/react/renderer/components/progressbar/BUCK +++ b/ReactCommon/react/renderer/components/progressbar/BUCK @@ -32,12 +32,6 @@ rn_xplat_cxx_library( ], prefix = "react/renderer/components/progressbar", ), - compiler_flags = [ - "-fexceptions", - "-frtti", - "-std=c++17", - "-Wall", - ], cxx_tests = [":tests"], fbandroid_deps = [ react_native_target("jni/react/jni:jni"), diff --git a/ReactCommon/react/renderer/components/root/BUCK b/ReactCommon/react/renderer/components/root/BUCK index b09dc8c12d1..59cd4b32a04 100644 --- a/ReactCommon/react/renderer/components/root/BUCK +++ b/ReactCommon/react/renderer/components/root/BUCK @@ -29,12 +29,6 @@ rn_xplat_cxx_library( ], prefix = "react/renderer/components/root", ), - compiler_flags = [ - "-fexceptions", - "-frtti", - "-std=c++17", - "-Wall", - ], fbobjc_compiler_flags = APPLE_COMPILER_FLAGS, fbobjc_preprocessor_flags = get_preprocessor_flags_for_build_mode() + get_apple_inspector_flags(), labels = ["supermodule:xplat/default/public.react_native.infra"], diff --git a/ReactCommon/react/renderer/components/safeareaview/BUCK b/ReactCommon/react/renderer/components/safeareaview/BUCK index fcb7febca17..fb85f5b0f07 100644 --- a/ReactCommon/react/renderer/components/safeareaview/BUCK +++ b/ReactCommon/react/renderer/components/safeareaview/BUCK @@ -24,12 +24,6 @@ rn_xplat_cxx_library( ], prefix = "react/renderer/components/safeareaview", ), - compiler_flags = [ - "-fexceptions", - "-frtti", - "-std=c++17", - "-Wall", - ], fbobjc_compiler_flags = APPLE_COMPILER_FLAGS, fbobjc_preprocessor_flags = get_preprocessor_flags_for_build_mode() + get_apple_inspector_flags(), force_static = True, diff --git a/ReactCommon/react/renderer/components/scrollview/BUCK b/ReactCommon/react/renderer/components/scrollview/BUCK index f75195782dc..d5c0d3f2468 100644 --- a/ReactCommon/react/renderer/components/scrollview/BUCK +++ b/ReactCommon/react/renderer/components/scrollview/BUCK @@ -32,12 +32,6 @@ rn_xplat_cxx_library( ], prefix = "react/renderer/components/scrollview", ), - compiler_flags = [ - "-fexceptions", - "-frtti", - "-std=c++17", - "-Wall", - ], fbandroid_deps = [ react_native_xplat_target("react/renderer/mapbuffer:mapbuffer"), ], diff --git a/ReactCommon/react/renderer/components/slider/BUCK b/ReactCommon/react/renderer/components/slider/BUCK index dd7d12dc281..01ac302615e 100644 --- a/ReactCommon/react/renderer/components/slider/BUCK +++ b/ReactCommon/react/renderer/components/slider/BUCK @@ -33,12 +33,6 @@ rn_xplat_cxx_library( ], prefix = "react/renderer/components/slider", ), - compiler_flags = [ - "-fexceptions", - "-frtti", - "-std=c++17", - "-Wall", - ], cxx_tests = [":tests"], fbandroid_deps = [ react_native_target("jni/react/jni:jni"), diff --git a/ReactCommon/react/renderer/components/switch/BUCK b/ReactCommon/react/renderer/components/switch/BUCK index f26b6ba6605..82ca7c4074e 100644 --- a/ReactCommon/react/renderer/components/switch/BUCK +++ b/ReactCommon/react/renderer/components/switch/BUCK @@ -34,12 +34,6 @@ rn_xplat_cxx_library( ], prefix = "react/renderer/components/androidswitch", ), - compiler_flags = [ - "-fexceptions", - "-frtti", - "-std=c++17", - "-Wall", - ], cxx_tests = [":tests"], fbandroid_deps = [ react_native_target("jni/react/jni:jni"), diff --git a/ReactCommon/react/renderer/components/text/BUCK b/ReactCommon/react/renderer/components/text/BUCK index 660a7f2e0f0..47f41977a11 100644 --- a/ReactCommon/react/renderer/components/text/BUCK +++ b/ReactCommon/react/renderer/components/text/BUCK @@ -36,12 +36,6 @@ rn_xplat_cxx_library( ], prefix = "react/renderer/components/text", ), - compiler_flags = [ - "-fexceptions", - "-frtti", - "-std=c++17", - "-Wall", - ], cxx_tests = [":tests"], fbandroid_deps = [ react_native_xplat_target("react/renderer/mapbuffer:mapbuffer"), diff --git a/ReactCommon/react/renderer/components/textinput/BUCK b/ReactCommon/react/renderer/components/textinput/BUCK index ad12c3b63e5..76f69e93aa2 100644 --- a/ReactCommon/react/renderer/components/textinput/BUCK +++ b/ReactCommon/react/renderer/components/textinput/BUCK @@ -33,12 +33,6 @@ rn_xplat_cxx_library( ], prefix = "react/renderer/components/androidtextinput", ), - compiler_flags = [ - "-fexceptions", - "-frtti", - "-std=c++17", - "-Wall", - ], cxx_tests = [":tests"], fbandroid_deps = [ react_native_xplat_target("react/renderer/mapbuffer:mapbuffer"), diff --git a/ReactCommon/react/renderer/components/textinput/androidtextinput/react/renderer/components/androidtextinput/AndroidTextInputProps.h b/ReactCommon/react/renderer/components/textinput/androidtextinput/react/renderer/components/androidtextinput/AndroidTextInputProps.h index 07daa9e2cd0..34048ddf910 100644 --- a/ReactCommon/react/renderer/components/textinput/androidtextinput/react/renderer/components/androidtextinput/AndroidTextInputProps.h +++ b/ReactCommon/react/renderer/components/textinput/androidtextinput/react/renderer/components/androidtextinput/AndroidTextInputProps.h @@ -7,6 +7,8 @@ #pragma once +// foo bar 2 + // #include #include #include diff --git a/ReactCommon/react/renderer/components/textinput/iostextinput/BUCK b/ReactCommon/react/renderer/components/textinput/iostextinput/BUCK index b6c933480d4..414f2d39855 100644 --- a/ReactCommon/react/renderer/components/textinput/iostextinput/BUCK +++ b/ReactCommon/react/renderer/components/textinput/iostextinput/BUCK @@ -33,12 +33,6 @@ rn_xplat_cxx_library( # TODO(shergin) T26519801 Figure out better directories structure prefix = "react/renderer/components/iostextinput", ), - compiler_flags = [ - "-fexceptions", - "-frtti", - "-std=c++17", - "-Wall", - ], cxx_tests = [":tests"], fbobjc_compiler_flags = APPLE_COMPILER_FLAGS, fbobjc_preprocessor_flags = get_preprocessor_flags_for_build_mode() + get_apple_inspector_flags(), diff --git a/ReactCommon/react/renderer/components/unimplementedview/BUCK b/ReactCommon/react/renderer/components/unimplementedview/BUCK index b3c76b9d7d2..8e59dd374ad 100644 --- a/ReactCommon/react/renderer/components/unimplementedview/BUCK +++ b/ReactCommon/react/renderer/components/unimplementedview/BUCK @@ -29,12 +29,6 @@ rn_xplat_cxx_library( ], prefix = "react/renderer/components/unimplementedview", ), - compiler_flags = [ - "-fexceptions", - "-frtti", - "-std=c++17", - "-Wall", - ], fbobjc_compiler_flags = APPLE_COMPILER_FLAGS, fbobjc_preprocessor_flags = get_preprocessor_flags_for_build_mode() + get_apple_inspector_flags(), labels = ["supermodule:xplat/default/public.react_native.infra"], diff --git a/ReactCommon/react/renderer/components/view/BUCK b/ReactCommon/react/renderer/components/view/BUCK index c3640ab3b40..d78b21f2cf8 100644 --- a/ReactCommon/react/renderer/components/view/BUCK +++ b/ReactCommon/react/renderer/components/view/BUCK @@ -35,12 +35,6 @@ rn_xplat_cxx_library( ], prefix = "react/renderer/components/view", ), - compiler_flags = [ - "-fexceptions", - "-frtti", - "-std=c++17", - "-Wall", - ], fbobjc_compiler_flags = APPLE_COMPILER_FLAGS, fbobjc_preprocessor_flags = get_preprocessor_flags_for_build_mode() + get_apple_inspector_flags(), force_static = True, diff --git a/ReactCommon/react/renderer/core/BUCK b/ReactCommon/react/renderer/core/BUCK index 8ed779f4283..f10420823e3 100644 --- a/ReactCommon/react/renderer/core/BUCK +++ b/ReactCommon/react/renderer/core/BUCK @@ -32,12 +32,6 @@ rn_xplat_cxx_library( ], prefix = "react/renderer/core", ), - compiler_flags = [ - "-fexceptions", - "-frtti", - "-std=c++17", - "-Wall", - ], fbobjc_compiler_flags = APPLE_COMPILER_FLAGS, fbobjc_preprocessor_flags = get_preprocessor_flags_for_build_mode() + get_apple_inspector_flags(), force_static = True, diff --git a/ReactCommon/react/renderer/debug/BUCK b/ReactCommon/react/renderer/debug/BUCK index 26e3e9f793f..e4b2ee23035 100644 --- a/ReactCommon/react/renderer/debug/BUCK +++ b/ReactCommon/react/renderer/debug/BUCK @@ -31,12 +31,6 @@ rn_xplat_cxx_library( ], prefix = "react/renderer/debug", ), - compiler_flags = [ - "-fexceptions", - "-frtti", - "-std=c++17", - "-Wall", - ], fbobjc_compiler_flags = APPLE_COMPILER_FLAGS, fbobjc_preprocessor_flags = get_preprocessor_flags_for_build_mode() + get_apple_inspector_flags(), force_static = True, diff --git a/ReactCommon/react/renderer/element/BUCK b/ReactCommon/react/renderer/element/BUCK index 88712f55955..6db4cf614b9 100644 --- a/ReactCommon/react/renderer/element/BUCK +++ b/ReactCommon/react/renderer/element/BUCK @@ -31,12 +31,6 @@ rn_xplat_cxx_library( ], prefix = "react/renderer/element", ), - compiler_flags = [ - "-fexceptions", - "-frtti", - "-std=c++17", - "-Wall", - ], fbobjc_compiler_flags = APPLE_COMPILER_FLAGS, fbobjc_preprocessor_flags = get_preprocessor_flags_for_build_mode() + get_apple_inspector_flags(), force_static = True, diff --git a/ReactCommon/react/renderer/graphics/BUCK b/ReactCommon/react/renderer/graphics/BUCK index 7c300c3c3e7..34748db2427 100644 --- a/ReactCommon/react/renderer/graphics/BUCK +++ b/ReactCommon/react/renderer/graphics/BUCK @@ -36,12 +36,6 @@ rn_xplat_cxx_library( ], prefix = "react/renderer/graphics", ), - compiler_flags = [ - "-fexceptions", - "-frtti", - "-std=c++17", - "-Wall", - ], cxx_exported_headers = subdir_glob( [ ("platform/cxx/react/renderer/graphics", "**/*.h"), diff --git a/ReactCommon/react/renderer/imagemanager/BUCK b/ReactCommon/react/renderer/imagemanager/BUCK index 8227c1dd680..557d5f3c294 100644 --- a/ReactCommon/react/renderer/imagemanager/BUCK +++ b/ReactCommon/react/renderer/imagemanager/BUCK @@ -31,12 +31,6 @@ rn_xplat_cxx_library( ], prefix = "react/renderer/imagemanager", ), - compiler_flags = [ - "-fexceptions", - "-frtti", - "-std=c++17", - "-Wall", - ], contacts = ["oncall+react_native@xmail.facebook.com"], fbandroid_exported_headers = subdir_glob( [ diff --git a/ReactCommon/react/renderer/leakchecker/BUCK b/ReactCommon/react/renderer/leakchecker/BUCK index a927f7214e9..c0796f177a3 100644 --- a/ReactCommon/react/renderer/leakchecker/BUCK +++ b/ReactCommon/react/renderer/leakchecker/BUCK @@ -30,12 +30,6 @@ rn_xplat_cxx_library( ], prefix = "react/renderer/leakchecker", ), - compiler_flags = [ - "-fexceptions", - "-frtti", - "-std=c++17", - "-Wall", - ], fbobjc_compiler_flags = APPLE_COMPILER_FLAGS, fbobjc_preprocessor_flags = get_preprocessor_flags_for_build_mode() + get_apple_inspector_flags(), force_static = True, diff --git a/ReactCommon/react/renderer/mapbuffer/BUCK b/ReactCommon/react/renderer/mapbuffer/BUCK index 3c946f02fa4..8e57a23c757 100644 --- a/ReactCommon/react/renderer/mapbuffer/BUCK +++ b/ReactCommon/react/renderer/mapbuffer/BUCK @@ -29,12 +29,6 @@ rn_xplat_cxx_library( ], prefix = "react/renderer/mapbuffer", ), - compiler_flags = [ - "-fexceptions", - "-frtti", - "-std=c++17", - "-Wall", - ], fbobjc_compiler_flags = APPLE_COMPILER_FLAGS, fbobjc_preprocessor_flags = get_preprocessor_flags_for_build_mode() + get_apple_inspector_flags(), force_static = True, diff --git a/ReactCommon/react/renderer/mounting/BUCK b/ReactCommon/react/renderer/mounting/BUCK index 2d0d42e5855..20a434f8687 100644 --- a/ReactCommon/react/renderer/mounting/BUCK +++ b/ReactCommon/react/renderer/mounting/BUCK @@ -32,12 +32,6 @@ rn_xplat_cxx_library( ], prefix = "react/renderer/mounting", ), - compiler_flags = [ - "-fexceptions", - "-frtti", - "-std=c++17", - "-Wall", - ], fbobjc_compiler_flags = APPLE_COMPILER_FLAGS, fbobjc_preprocessor_flags = get_preprocessor_flags_for_build_mode() + get_apple_inspector_flags(), force_static = True, diff --git a/ReactCommon/react/renderer/runtimescheduler/BUCK b/ReactCommon/react/renderer/runtimescheduler/BUCK index d313bb670a0..81f2b99954f 100644 --- a/ReactCommon/react/renderer/runtimescheduler/BUCK +++ b/ReactCommon/react/renderer/runtimescheduler/BUCK @@ -31,12 +31,6 @@ rn_xplat_cxx_library( ], prefix = "react/renderer/runtimescheduler", ), - compiler_flags = [ - "-fexceptions", - "-frtti", - "-std=c++17", - "-Wall", - ], fbobjc_compiler_flags = APPLE_COMPILER_FLAGS, fbobjc_preprocessor_flags = get_preprocessor_flags_for_build_mode() + get_apple_inspector_flags(), force_static = True, diff --git a/ReactCommon/react/renderer/scheduler/BUCK b/ReactCommon/react/renderer/scheduler/BUCK index be576471252..ee76e263bb1 100644 --- a/ReactCommon/react/renderer/scheduler/BUCK +++ b/ReactCommon/react/renderer/scheduler/BUCK @@ -30,12 +30,6 @@ rn_xplat_cxx_library( ], prefix = "react/renderer/scheduler", ), - compiler_flags = [ - "-fexceptions", - "-frtti", - "-std=c++17", - "-Wall", - ], fbobjc_compiler_flags = APPLE_COMPILER_FLAGS, fbobjc_preprocessor_flags = get_preprocessor_flags_for_build_mode() + get_apple_inspector_flags(), force_static = True, diff --git a/ReactCommon/react/renderer/telemetry/BUCK b/ReactCommon/react/renderer/telemetry/BUCK index 3ec301b4839..d6b46e35dec 100644 --- a/ReactCommon/react/renderer/telemetry/BUCK +++ b/ReactCommon/react/renderer/telemetry/BUCK @@ -32,12 +32,6 @@ rn_xplat_cxx_library( ], prefix = "react/renderer/telemetry", ), - compiler_flags = [ - "-fexceptions", - "-frtti", - "-std=c++17", - "-Wall", - ], fbobjc_compiler_flags = APPLE_COMPILER_FLAGS, fbobjc_preprocessor_flags = get_preprocessor_flags_for_build_mode() + get_apple_inspector_flags(), force_static = True, diff --git a/ReactCommon/react/renderer/templateprocessor/BUCK b/ReactCommon/react/renderer/templateprocessor/BUCK index 1f106c4b944..430b0bdb1d3 100644 --- a/ReactCommon/react/renderer/templateprocessor/BUCK +++ b/ReactCommon/react/renderer/templateprocessor/BUCK @@ -31,12 +31,6 @@ rn_xplat_cxx_library( ], prefix = "react/renderer/templateprocessor", ), - compiler_flags = [ - "-fexceptions", - "-frtti", - "-std=c++17", - "-Wall", - ], fbobjc_compiler_flags = APPLE_COMPILER_FLAGS, fbobjc_preprocessor_flags = get_preprocessor_flags_for_build_mode() + get_apple_inspector_flags(), force_static = True, diff --git a/ReactCommon/react/renderer/textlayoutmanager/BUCK b/ReactCommon/react/renderer/textlayoutmanager/BUCK index 18a9ddeb0f3..1e7e142f4cb 100644 --- a/ReactCommon/react/renderer/textlayoutmanager/BUCK +++ b/ReactCommon/react/renderer/textlayoutmanager/BUCK @@ -36,12 +36,6 @@ rn_xplat_cxx_library( ], prefix = "react/renderer/textlayoutmanager", ), - compiler_flags = [ - "-fexceptions", - "-frtti", - "-std=c++17", - "-Wall", - ], cxx_exported_headers = subdir_glob( [ ("platform/cxx", "*.h"), diff --git a/ReactCommon/react/renderer/timeline/BUCK b/ReactCommon/react/renderer/timeline/BUCK index d9887cc2c4e..a8888cb22f7 100644 --- a/ReactCommon/react/renderer/timeline/BUCK +++ b/ReactCommon/react/renderer/timeline/BUCK @@ -31,12 +31,6 @@ rn_xplat_cxx_library( ], prefix = "react/renderer/timeline", ), - compiler_flags = [ - "-fexceptions", - "-frtti", - "-std=c++17", - "-Wall", - ], fbobjc_compiler_flags = APPLE_COMPILER_FLAGS, fbobjc_labels = ["supermodule:ios/isolation/infra.react_native"], fbobjc_preprocessor_flags = get_preprocessor_flags_for_build_mode() + get_apple_inspector_flags(), diff --git a/ReactCommon/react/renderer/uimanager/BUCK b/ReactCommon/react/renderer/uimanager/BUCK index 4a583781475..d518a76c385 100644 --- a/ReactCommon/react/renderer/uimanager/BUCK +++ b/ReactCommon/react/renderer/uimanager/BUCK @@ -31,12 +31,6 @@ rn_xplat_cxx_library( ], prefix = "react/renderer/uimanager", ), - compiler_flags = [ - "-fexceptions", - "-frtti", - "-std=c++17", - "-Wall", - ], fbobjc_compiler_flags = APPLE_COMPILER_FLAGS, fbobjc_preprocessor_flags = get_preprocessor_flags_for_build_mode() + get_apple_inspector_flags(), force_static = True, diff --git a/ReactCommon/react/test_utils/BUCK b/ReactCommon/react/test_utils/BUCK index 8cd75144aaa..55a8cac9d0f 100644 --- a/ReactCommon/react/test_utils/BUCK +++ b/ReactCommon/react/test_utils/BUCK @@ -27,12 +27,6 @@ rn_xplat_cxx_library( ], prefix = "react/test_utils", ), - compiler_flags = [ - "-fexceptions", - "-frtti", - "-std=c++17", - "-Wall", - ], fbobjc_compiler_flags = APPLE_COMPILER_FLAGS, fbobjc_frameworks = ["Foundation"], fbobjc_preprocessor_flags = get_preprocessor_flags_for_build_mode() + get_apple_inspector_flags(), diff --git a/ReactCommon/react/utils/BUCK b/ReactCommon/react/utils/BUCK index 3d4bfde9b0f..6525d5b9b5d 100644 --- a/ReactCommon/react/utils/BUCK +++ b/ReactCommon/react/utils/BUCK @@ -34,12 +34,6 @@ rn_xplat_cxx_library( ], prefix = "react/utils", ), - compiler_flags = [ - "-fexceptions", - "-frtti", - "-std=c++17", - "-Wall", - ], fbandroid_deps = [ react_native_target("java/com/facebook/react/common/mapbuffer/jni:jni"), react_native_xplat_target("react/renderer/mapbuffer:mapbuffer"), diff --git a/ReactCommon/reactperflogger/BUCK b/ReactCommon/reactperflogger/BUCK index 09928787c7e..d1a06c09571 100644 --- a/ReactCommon/reactperflogger/BUCK +++ b/ReactCommon/reactperflogger/BUCK @@ -9,10 +9,6 @@ rn_xplat_cxx_library( "reactperflogger/NativeModulePerfLogger.h": "reactperflogger/NativeModulePerfLogger.h", }, compiler_flags = [ - "-fexceptions", - "-frtti", - "-std=c++17", - "-Wall", "-Wno-global-constructors", ], labels = ["supermodule:xplat/default/public.react_native.infra"], diff --git a/ReactCommon/runtimeexecutor/BUCK b/ReactCommon/runtimeexecutor/BUCK index 60dc08ebb13..b8e04dfaf72 100644 --- a/ReactCommon/runtimeexecutor/BUCK +++ b/ReactCommon/runtimeexecutor/BUCK @@ -28,12 +28,6 @@ rn_xplat_cxx_library( exported_headers = { "ReactCommon/RuntimeExecutor.h": "ReactCommon/RuntimeExecutor.h", }, - compiler_flags = [ - "-fexceptions", - "-frtti", - "-std=c++17", - "-Wall", - ], fbobjc_compiler_flags = APPLE_COMPILER_FLAGS, fbobjc_frameworks = ["Foundation"], fbobjc_preprocessor_flags = get_preprocessor_flags_for_build_mode() + get_apple_inspector_flags(), diff --git a/ReactCommon/yoga/BUCK b/ReactCommon/yoga/BUCK index 13e624f86b7..c6e4116f0ba 100644 --- a/ReactCommon/yoga/BUCK +++ b/ReactCommon/yoga/BUCK @@ -7,11 +7,7 @@ cxx_library( exported_headers = glob(["yoga/**/*.h"]), compiler_flags = [ "-fno-omit-frame-pointer", - "-fexceptions", - "-Wall", - "-Werror", - "-std=c++1y", - "-O3", + "-O3" ], force_static = True, visibility = ["PUBLIC"], diff --git a/packages/react-native-codegen/BUCK b/packages/react-native-codegen/BUCK index 138f9de91ae..04c7639d8f9 100644 --- a/packages/react-native-codegen/BUCK +++ b/packages/react-native-codegen/BUCK @@ -55,12 +55,6 @@ rn_xplat_cxx_library( name = "rn_codegen_library", srcs = ["buck_tests/emptyFile.cpp"], headers = [], - compiler_flags = [ - "-fexceptions", - "-frtti", - "-std=c++17", - "-Wall", - ], platforms = (ANDROID, APPLE), preprocessor_flags = [ "-DLOG_TAG=\"ReactNative\"", @@ -79,12 +73,6 @@ rn_xplat_cxx_library( srcs = ["buck_tests/emptyFile.mm"], headers = [], apple_sdks = (IOS,), - compiler_flags = [ - "-fexceptions", - "-frtti", - "-std=c++17", - "-Wall", - ], platforms = APPLE, preprocessor_flags = [ "-DLOG_TAG=\"ReactNative\"", diff --git a/packages/react-native-codegen/DEFS.bzl b/packages/react-native-codegen/DEFS.bzl index 43ac82e0aeb..a5211ce5858 100644 --- a/packages/react-native-codegen/DEFS.bzl +++ b/packages/react-native-codegen/DEFS.bzl @@ -195,12 +195,6 @@ def rn_codegen_modules( exported_headers = { "{}/{}.h".format(name, name): ":{}".format(generate_module_jni_h_name), }, - compiler_flags = [ - "-fexceptions", - "-frtti", - "-std=c++14", - "-Wall", - ], force_static = True, preprocessor_flags = [ "-DLOG_TAG=\"ReactNative\"", @@ -416,12 +410,6 @@ def rn_codegen_components( "RCTComponentViewHelpers.h": ":{}".format(generate_component_hobjcpp_name), "ShadowNodes.h": ":{}".format(generate_shadow_node_h_name), }, - compiler_flags = [ - "-fexceptions", - "-frtti", - "-std=c++14", - "-Wall", - ], fbobjc_compiler_flags = get_apple_compiler_flags(), fbobjc_preprocessor_flags = get_preprocessor_flags_for_build_mode() + get_apple_inspector_flags(), ios_exported_headers = { @@ -563,12 +551,6 @@ def rn_codegen_cxx_modules( "NativeModules.cpp": ":{}".format(generate_module_cpp_name), "NativeModules.h": ":{}".format(generate_module_h_name), }, - compiler_flags = [ - "-fexceptions", - "-frtti", - "-std=c++14", - "-Wall", - ], fbobjc_compiler_flags = get_apple_compiler_flags(), fbobjc_preprocessor_flags = get_preprocessor_flags_for_build_mode() + get_apple_inspector_flags(), labels = ["codegen_rule"],