From b60651dd099c22757e993d67e1a437801a02e71b Mon Sep 17 00:00:00 2001 From: zhongwuzw Date: Sun, 14 Apr 2019 06:03:32 -0700 Subject: [PATCH] Add indent for event emitter header generation of codegen (#24445) Summary: Part of #24438, add indent foe event emitter header codegen. cc. cpojer rickhanlonii. [General] [Fixed] - Add indent for event emitter header generation of codegen Pull Request resolved: https://github.com/facebook/react-native/pull/24445 Differential Revision: D14930352 Pulled By: cpojer fbshipit-source-id: 8bd03b8e12ccf9bd06546acdb744541fcb92eea1 --- .../src/generators/GenerateEventEmitterH.js | 4 ++-- .../__snapshots__/GenerateEventEmitterH-test.js.snap | 12 ++++++------ 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/packages/react-native-codegen/src/generators/GenerateEventEmitterH.js b/packages/react-native-codegen/src/generators/GenerateEventEmitterH.js index 75d89d5a1bd..2b4909837a9 100644 --- a/packages/react-native-codegen/src/generators/GenerateEventEmitterH.js +++ b/packages/react-native-codegen/src/generators/GenerateEventEmitterH.js @@ -108,7 +108,7 @@ function generateStruct( structNameParts, )} ${property.name};`; }) - .join('\n'); + .join('\n' + ' '); properties.forEach((property: ObjectPropertyType) => { const name = property.name; @@ -165,7 +165,7 @@ function generateEvent(componentName: string, event: EventTypeShape): string { function generateEvents(componentName: string, component): string { return component.events .map(event => generateEvent(componentName, event)) - .join('\n\n'); + .join('\n\n' + ' '); } module.exports = { diff --git a/packages/react-native-codegen/src/generators/__tests__/__snapshots__/GenerateEventEmitterH-test.js.snap b/packages/react-native-codegen/src/generators/__tests__/__snapshots__/GenerateEventEmitterH-test.js.snap index f7d7ca0508c..bf3c4da2b95 100644 --- a/packages/react-native-codegen/src/generators/__tests__/__snapshots__/GenerateEventEmitterH-test.js.snap +++ b/packages/react-native-codegen/src/generators/__tests__/__snapshots__/GenerateEventEmitterH-test.js.snap @@ -118,8 +118,8 @@ struct EventsNestedObjectNativeComponentOnChangeLocationSourceStruct { struct EventsNestedObjectNativeComponentOnChangeLocationStruct { EventsNestedObjectNativeComponentOnChangeLocationSourceStruct source; -int x; -int y; + int x; + int y; }; struct EventsNestedObjectNativeComponentOnChangeStruct { @@ -157,9 +157,9 @@ namespace react { struct EventsNativeComponentOnChangeStruct { bool value; -std::string source; -int progress; -Float scale; + std::string source; + int progress; + Float scale; }; struct EventsNativeComponentOnEventDirectStruct { @@ -172,7 +172,7 @@ class EventsNativeComponentEventEmitter : public ViewEventEmitter { void onChange(EventsNativeComponentOnChangeStruct value) const; -void onEventDirect(EventsNativeComponentOnEventDirectStruct value) const; + void onEventDirect(EventsNativeComponentOnEventDirectStruct value) const; }; } // namespace react