From b3c41cef98a9fbbe436e5034cf07bf8d674cf8d1 Mon Sep 17 00:00:00 2001 From: David Vacca Date: Thu, 13 Feb 2025 18:27:59 -0800 Subject: [PATCH] EZ refactor in ViewManager (#49415) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/49415 Refactoring NAME -> TAG for consistency with other classes changelog: [internal] internal Reviewed By: Abbondanzo Differential Revision: D69622546 fbshipit-source-id: 314db29ddfdbbd7fc614b355b9b18c0a8afe31df --- .../java/com/facebook/react/uimanager/ViewManager.java | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/ViewManager.java b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/ViewManager.java index f52aaf8787d..b1d88ae7590 100644 --- a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/ViewManager.java +++ b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/ViewManager.java @@ -42,7 +42,7 @@ import java.util.Stack; public abstract class ViewManager extends BaseJavaModule { - private static final String NAME = ViewManager.class.getSimpleName(); + private static final String TAG = "ViewManager"; private @Nullable ViewManagerDelegate mDelegate = null; @@ -117,7 +117,7 @@ public abstract class ViewManager protected ViewManagerDelegate getDelegate() { if (this instanceof ViewManagerWithGeneratedInterface) { ReactSoftExceptionLogger.logSoftException( - NAME, + TAG, new ReactNoCrashSoftException( "ViewManager using codegen must override getDelegate method (name: " + getName() @@ -237,12 +237,12 @@ public abstract class ViewManager if (viewContext == null) { // Who knows! Anything is possible. Checking instanceof on null is an NPE, // So this is not redundant. - FLog.e(NAME, "onDropViewInstance: view [" + view.getId() + "] has a null context"); + FLog.e(TAG, "onDropViewInstance: view [" + view.getId() + "] has a null context"); return; } if (!(viewContext instanceof ThemedReactContext)) { FLog.e( - NAME, + TAG, "onDropViewInstance: view [" + view.getId() + "] has a context that is not a ThemedReactContext: "